Ghost/test
Kevin Ansfield a485509a2f
🐛 Fixed GA labs flags not appearing enabled in settings API (#13681)
no issue

The way GA flags were introduced means that they stop existing in the `'labs'` setting in the db and are instead forced to always return `true` when checking the flag in the labs service. However, Admin which uses the flags fetches them via the `/settings/` API endpoint which was only returning the raw labs setting db value meaning GA flags appeared to be disabled unless the flag had previously been enabled and no settings save had occured.

- updated the settings bread service to replace the labs setting value with the JSON stringified output of `labs.getAll()` which is the ultimate source-of-truth for a feature being enabled/disabled
  - extracted `browse()` behaviour to an internal `_formatBrowse()` method so we can apply the same filtering/modification for output of `browse()` and `edit()`

Co-authored-by: Fabien O'Carroll <fabien@allou.is>
2021-10-22 19:59:13 +01:00
..
e2e-api 🐛 Fixed GA labs flags not appearing enabled in settings API (#13681) 2021-10-22 19:59:13 +01:00
e2e-frontend Updated e2e tests to be async/await 2021-10-06 15:51:05 +01:00
e2e-server Fixed ETag header for admin templates not changing between versions (#13680) 2021-10-22 14:25:58 +01:00
integration Moved URL service to backend 2021-10-19 07:29:09 +13:00
regression 🐛 Fixed GA labs flags not appearing enabled in settings API (#13681) 2021-10-22 19:59:13 +01:00
unit Added Offers feature to Ghost 2021-10-22 17:55:34 +02:00
utils Fixed ETag header for admin templates not changing between versions (#13680) 2021-10-22 14:25:58 +01:00
.eslintignore Move tests from core to root (#11700) 2020-03-30 16:26:47 +01:00
.eslintrc.js Upgraded no-skipped-test rule to error 2021-05-26 14:57:43 +01:00
.jshintrc Move tests from core to root (#11700) 2020-03-30 16:26:47 +01:00