mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-26 20:34:02 +03:00
3d3b3ff701
ref ENG-774 ref https://linear.app/tryghost/issue/ENG-774 Staff Tokens will have both a `user` and an `apiKey` present on the `loadedPermissions`. The check here for `apiKey` was written when we could assume that an `apiKey` was an Admin Integration - so it completely overwrote the previous `allowed` list. When we added the concept of Staff Tokens - this resulted in a privilege escalation. This is a good lesson in not using proxies or indicators for data, as changes elsewhere can invalidate them - if we had been specific and checked the role of the current actor we wouldn't've had this bug! |
||
---|---|---|
.. | ||
e2e-api | ||
e2e-browser | ||
e2e-frontend | ||
e2e-server | ||
e2e-webhooks | ||
integration | ||
regression | ||
unit | ||
utils | ||
.eslintignore | ||
.eslintrc.js |