3d6fae3ea7
closes https://linear.app/tryghost/issue/MOM-60 - when the dropdown opens near the end of the document, clicking the links sometimes did nothing and showed an error in the console - we have a mousedown event handler on an element that surrounds the main editing element that re-focuses the editor when clicked in order to make the "focus editor" click target larger and more natural-feeling but it was inadvertently re-focusing when the mousedown event fired for an element in the dropdown list when the list was positioned outside of the main editor element. This lead to timing issues with the bookmark node being removed on blur because it was empty followed by an error from the node's component's async event handlers which were trying to set values on the now-removed node - by switching from `event.target.closest()` to looping over `event.composedPath()` when checking to see if we should skip re-focusing we're more resilient to DOM manipulations occurring between event triggers and function calls because we'll always be given the list of elements that existed at the time the event fired |
||
|---|---|---|
| .. | ||
| app | ||
| config | ||
| lib | ||
| mirage | ||
| public/assets | ||
| tests | ||
| .editorconfig | ||
| .ember-cli | ||
| .eslintignore | ||
| .eslintrc.js | ||
| .lint-todo | ||
| .lint-todorc.js | ||
| .template-lintrc.js | ||
| .watchmanconfig | ||
| ember-cli-build.js | ||
| ember-cli-update.json | ||
| jsconfig.json | ||
| package.json | ||
| README.md | ||
| testem.js | ||
Ghost-Admin
This is the home of the Ember.js-based Admin app that ships with Ghost.
Running tests
Build and run tests once:
TZ=UTC yarn test
Note the TZ=UTC environment variable which is currently required to get tests working if your system timezone doesn't match UTC.
If you are serving the admin app (e.g., when running yarn serve, or when running yarn dev in the main Ghost project), you can also run the tests in your browser by going to http://localhost:4200/tests.
This has the additional benefit that you can use await this.pauseTest() in your tests to temporarily pause tests (best to also add this.timeout(0); to avoid timeouts). This allows you to inspect the DOM in your browser to debug tests. You can resume tests by running resumeTest() in your browser console.
Writing tests
When writing tests and not using the http://localhost:4200/tests browser tests, it can be easier to have a separate watching build that builds the project for the test environment (this drastically reduces the time you have to wait when running tests):
yarn build --environment=test -w -o="dist-test"
After that, you can easily run tests locally:
Run all tests:
TZ=UTC yarn test 1 --path="dist-test"
To have a cleaner output:
TZ=UTC yarn test 1 --reporter dot --path="dist-test"
This shows a dot (.) for every successful test, and F for every failed test. At the end, it will only show the output of the failed tests.
To run a specific test file:
TZ=UTC yarn test 1 --reporter dot --path="dist-test" -mp=tests/acceptance/settings/newsletters-test.js
Hint: you can easily copy the path of a test in VSCode by right clicking on the test file and choosing Copy Relative Path.
To have a full list of the available options, run
ember exam --help
Copyright & License
Copyright (c) 2013-2023 Ghost Foundation - Released under the MIT license. Ghost and the Ghost Logo are trademarks of Ghost Foundation Ltd. Please see our trademark policy for info on acceptable usage.