mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-11-27 10:42:45 +03:00
459a2c553e
ref https://linear.app/tryghost/issue/ONC-323 When the store gets into a bad state for new posts that causes saves to fail we can detect that by looking at the `model.isNew` property. Currently our best approach to fix this state is to restart the app. - added a `didTransition()` hook to our `lexical-edit.new` route - detects the bad state, logs the error, and triggers a browser refresh - logs with a `recreatedPostIsGood` property that will let us know if we could instead just try recreating the post and avoiding a full refresh (so far we have no reproduction case so we need to learn what we can) - added `sinon-chai` dependency for better assertions on spies/stubs - added `sentry-testkit` dependency so we can test our Sentry integration calls - we can't use sinon for these calls because of the way Sentry's es6 imports work - extracted our full Sentry config object generation to a util function so it can be re-used in unit tests - updated our integrations list to disable the default `dedupe` integration because it can cause very unexpected/difficult to debug test failures when you're asserting using `sentry-testkit` |
||
|---|---|---|
| .. | ||
| adapters | ||
| authenticators | ||
| components | ||
| controllers | ||
| decorators | ||
| errors | ||
| helpers | ||
| initializers | ||
| instance-initializers | ||
| mixins | ||
| models | ||
| modifiers | ||
| routes | ||
| serializers | ||
| services | ||
| session-stores | ||
| styles | ||
| templates | ||
| transforms | ||
| transitions | ||
| utils | ||
| validators | ||
| app.js | ||
| index.html | ||
| README.md | ||
| router.js | ||
| transitions.js | ||
Ghost Admin App
Ember.js application used as a client-side admin for the Ghost blogging platform. This readme is a work in progress guide aimed at explaining the specific nuances of the Ghost Ember app to contributors whose main focus is on this side of things.
CSS
We use pure CSS, which is pre-processed for backwards compatibility by Myth. We do not follow any strict CSS framework, however our general style is pretty similar to BEM.
Styles are primarily broken up into 4 main categories:
- Patterns - are base level visual styles for HTML elements (eg. Buttons)
- Components - are groups of patterns used to create a UI component (eg. Modals)
- Layouts - are groups of components used to create application screens (eg. Settings)
All of these separate files are subsequently imported and compiled in app.css.
Front End Standards
- 4 spaces for HTML & CSS indentation. Never tabs.
- Double quotes only, never single quotes.
- Use tags and elements appropriate for an HTML5 doctype (including self-closing tags)
- Adhere to the Recess CSS property order.
- Always a space after a property's colon (.e.g, display: block; and not display:block;).
- End all lines with a semi-colon.
- For multiple, comma-separated selectors, place each selector on its own line.
- Use js- prefixed classes for JavaScript hooks into the DOM, and never use these in CSS as per Slightly Obtrusive JavaScript
- Avoid over-nesting CSS. Never nest more than 3 levels deep.
- Use comments to explain "why" not "what" (Good: This requires a z-index in order to appear above mobile navigation. Bad: This is a thing which is always on top!)