mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-01 13:54:35 +03:00
2231dd84c2
no issue
Ember is migrating to `<AngleBracketSyntax />` for component invocation, see https://github.com/emberjs/rfcs/blob/master/text/0311-angle-bracket-invocation.md
We were in a half-way situation where some templates used angle bracket syntax in some places, this PR updates templates to use the syntax everywhere.
This simplifies the rules for what template code is referring to...
`<Component>` = a component
`{{helper}}` = a helper (or locally assigned handlebars variable)
`{{this.foo}}` = data on the template backing context (a component/controller)
`{{@foo}}` = a named argument passed into the component that the component backing class has not modified (note: this commit does not introduce any named arguments)
- ran codemod https://github.com/ember-codemods/ember-angle-brackets-codemod on the following directories:
- `app/templates`
- `lib/koenig-editor/addon/templates`
- removed positional params from components as angle bracket syntax does not support them
- `gh-feature-flag`
- `gh-tour-item`
- `gh-cm-editor`
- `gh-fullscreen-modal`
- `gh-task-button`
- updates some code that was missed in 3c851293c1
to use explicit this
169 lines
4.3 KiB
JavaScript
169 lines
4.3 KiB
JavaScript
import Component from '@ember/component';
|
|
import {computed} from '@ember/object';
|
|
import {isBlank} from '@ember/utils';
|
|
import {reads} from '@ember/object/computed';
|
|
import {run} from '@ember/runloop';
|
|
import {inject as service} from '@ember/service';
|
|
|
|
let instancesCounter = 0;
|
|
|
|
let triangleClassPositions = {
|
|
'top-left': {
|
|
attachment: 'top left',
|
|
targetAttachment: 'bottom center',
|
|
offset: '0 28px'
|
|
},
|
|
top: {
|
|
attachment: 'top center',
|
|
targetAttachment: 'bottom center'
|
|
},
|
|
'top-right': {
|
|
attachment: 'top right',
|
|
targetAttachment: 'bottom center',
|
|
offset: '0 -28px'
|
|
},
|
|
'right-top': {
|
|
attachment: 'top right',
|
|
targetAttachment: 'middle left',
|
|
offset: '28px 0'
|
|
},
|
|
right: {
|
|
attachment: 'middle right',
|
|
targetAttachment: 'middle left'
|
|
},
|
|
'right-bottom': {
|
|
attachment: 'bottom right',
|
|
targetAttachment: 'middle left',
|
|
offset: '-28px 0'
|
|
},
|
|
'bottom-right': {
|
|
attachment: 'bottom right',
|
|
targetAttachment: 'top center',
|
|
offset: '0 -28px'
|
|
},
|
|
bottom: {
|
|
attachment: 'bottom center',
|
|
targetAttachment: 'top center'
|
|
},
|
|
'bottom-left': {
|
|
attachment: 'bottom left',
|
|
targetAttachment: 'top center',
|
|
offset: '0 28px'
|
|
},
|
|
'left-bottom': {
|
|
attachment: 'bottom left',
|
|
targetAttachment: 'middle right',
|
|
offset: '-28px 0'
|
|
},
|
|
left: {
|
|
attachment: 'middle left',
|
|
targetAttachment: 'middle right'
|
|
},
|
|
'left-top': {
|
|
attachment: 'top left',
|
|
targetAttachment: 'middle right',
|
|
offset: '28px 0'
|
|
}
|
|
};
|
|
|
|
const GhTourItemComponent = Component.extend({
|
|
|
|
mediaQueries: service(),
|
|
tour: service(),
|
|
|
|
tagName: '',
|
|
|
|
throbberId: null,
|
|
target: null,
|
|
throbberAttachment: 'middle center',
|
|
popoverTriangleClass: 'top',
|
|
isOpen: false,
|
|
|
|
_elementId: null,
|
|
_throbber: null,
|
|
_throbberElementId: null,
|
|
_throbberElementSelector: null,
|
|
_popoverAttachment: null,
|
|
_popoverTargetAttachment: null,
|
|
_popoverOffset: null,
|
|
|
|
isMobile: reads('mediaQueries.isMobile'),
|
|
isVisible: computed('isMobile', '_throbber', function () {
|
|
let isMobile = this.isMobile;
|
|
let hasThrobber = !isBlank(this._throbber);
|
|
|
|
return !isMobile && hasThrobber;
|
|
}),
|
|
|
|
init() {
|
|
this._super(...arguments);
|
|
// this is a tagless component so we need to generate our own elementId
|
|
this._elementId = instancesCounter += 1;
|
|
this._throbberElementId = `throbber-${this._elementId}`;
|
|
this._throbberElementSelector = `#throbber-${this._elementId}`;
|
|
|
|
this._handleOptOut = run.bind(this, this._remove);
|
|
this._handleViewed = run.bind(this, this._removeIfViewed);
|
|
|
|
this.tour.on('optOut', this._handleOptOut);
|
|
this.tour.on('viewed', this._handleViewed);
|
|
},
|
|
|
|
didReceiveAttrs() {
|
|
let throbberId = this.throbberId;
|
|
let throbber = this.tour.activeThrobber(throbberId);
|
|
let triangleClass = this.popoverTriangleClass;
|
|
let popoverPositions = triangleClassPositions[triangleClass];
|
|
|
|
this._throbber = throbber;
|
|
this._popoverAttachment = popoverPositions.attachment;
|
|
this._popoverTargetAttachment = popoverPositions.targetAttachment;
|
|
this._popoverOffset = popoverPositions.offset;
|
|
},
|
|
|
|
willDestroyElement() {
|
|
this.tour.off('optOut', this._handleOptOut);
|
|
this.tour.off('viewed', this._handleViewed);
|
|
this._super(...arguments);
|
|
},
|
|
|
|
actions: {
|
|
open() {
|
|
this.set('isOpen', true);
|
|
},
|
|
|
|
close() {
|
|
this._close();
|
|
},
|
|
|
|
markAsViewed() {
|
|
let throbberId = this.throbberId;
|
|
this.tour.markThrobberAsViewed(throbberId);
|
|
this.set('_throbber', null);
|
|
this._close();
|
|
},
|
|
|
|
optOut() {
|
|
this.tour.optOut();
|
|
this.set('_throbber', null);
|
|
this._close();
|
|
}
|
|
},
|
|
|
|
_removeIfViewed(id) {
|
|
if (id === this.throbberId) {
|
|
this._remove();
|
|
}
|
|
},
|
|
|
|
_remove() {
|
|
this.set('_throbber', null);
|
|
},
|
|
|
|
_close() {
|
|
this.set('isOpen', false);
|
|
}
|
|
});
|
|
|
|
export default GhTourItemComponent;
|