mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-11-28 22:43:30 +03:00
48387e4ffd
refs #7494, refs #7495
This PR is an extracted clean up feature of #7495.
We are using everywhere static id checks (userId === 0 or userId === 1).
This PR moves the static values into the Base model.
This makes it 1. way more readable and 2. we can change the id's in a central place.
I changed the most important occurrences - no tests are touched (yet!).
The background is: when changing from auto increment id (number) to ObjectId's (string) we still need to support id 1 and 0, because Ghost relies on these two static id's.
I would like to support using both: 0/1 as string and 0/1 as number.
1 === owner/internal
0 === external
Another important change:
User Model does not longer define the contextUser method, because i couldn't find a reason?
I looked in Git history, see
|
||
|---|---|---|
| .. | ||
| app.js | ||
| authentication.js | ||
| clients.js | ||
| configuration.js | ||
| db.js | ||
| index.js | ||
| invites.js | ||
| mail.js | ||
| notifications.js | ||
| posts.js | ||
| roles.js | ||
| schedules.js | ||
| settings.js | ||
| slack.js | ||
| slugs.js | ||
| subscribers.js | ||
| tags.js | ||
| themes.js | ||
| upload.js | ||
| users.js | ||
| utils.js | ||