TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-18 16:01:40 +03:00
Code Issues Projects Releases Wiki Activity
49f936b098
Ghost/ghost
History
Ronald Langeveld 49f936b098
🐛 Fixed empty icon crashing signup embed preview (#17022) 
closes https://github.com/TryGhost/Team/issues/3471

- after adding and removing an icon, icon settings passed an undefined
icon to the signup form's all-in-one style. The AIO conditions didn't
take that into account and caused the entire component to crash.

<!-- Leave the line below if you'd like GitHub Copilot to generate a
summary from your commit -->
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 9e1aea3</samp>

Fix signup form embed code generation when icon is not set. Add a check
for `this.settings.icon` in `signup-form-embed.js` before replacing
image path.
2023-06-15 09:03:14 +02:00
..
adapter-cache-memory-ttl Added eslint rule for file naming convention 2023-05-09 12:34:34 -04:00
adapter-cache-redis Added eslint rule for file naming convention 2023-05-09 12:34:34 -04:00
adapter-manager Update Test & linting packages 2023-04-05 15:16:08 +02:00
admin 🐛 Fixed empty icon crashing signup embed preview (#17022) 2023-06-15 09:03:14 +02:00
admin-x-settings Updated site preview to handle theme settings 2023-06-09 20:06:06 +05:30
announcement-bar Bumped eslint-plugin-ghost (#16906) 2023-05-31 16:36:32 -04:00
announcement-bar-settings Extracted announcement visibility values to single place 2023-04-26 14:42:33 +02:00
api-framework ✨ Implemented duplicate post functionality (#16767) 2023-05-15 09:30:32 +01:00
api-version-compatibility-service Added eslint rule for file naming convention 2023-05-09 12:34:34 -04:00
audience-feedback Update @tryghost 2023-04-07 13:47:12 +02:00
bootstrap-socket Update @tryghost 2023-04-07 13:47:12 +02:00
collections Wired up collections to posts endpoint (#16945) 2023-06-07 15:06:15 +02:00
constants Update Test & linting packages 2023-04-05 15:16:08 +02:00
core v5.51.1 2023-06-13 05:52:56 +00:00
custom-theme-settings-service Added eslint rule for file naming convention 2023-05-09 12:34:34 -04:00
data-generator Added eslint rule for file naming convention 2023-05-09 12:34:34 -04:00
domain-events Update @tryghost 2023-04-07 13:47:12 +02:00
dynamic-routing-events Update Test & linting packages 2023-04-05 15:16:08 +02:00
email-analytics-provider-mailgun Added eslint rule for file naming convention 2023-05-09 12:34:34 -04:00
email-analytics-service Added eslint rule for file naming convention 2023-05-09 12:34:34 -04:00
email-content-generator Added eslint rule for file naming convention 2023-05-09 12:34:34 -04:00
email-events Update Test & linting packages 2023-04-05 15:16:08 +02:00
email-service Improved oversized batch correction logic 2023-06-09 14:40:12 +07:00
email-suppression-list Update Test & linting packages 2023-04-05 15:16:08 +02:00
event-aware-cache-wrapper Added eslint rule for file naming convention 2023-05-09 12:34:34 -04:00
express-dynamic-redirects Update dependency c8 to v7.13.0 2023-02-16 22:15:50 +00:00
external-media-inliner Update Test & linting packages 2023-04-05 15:16:08 +02:00
extract-api-key Fixed full Admin test suite running during unit tests 2022-08-15 15:34:52 +02:00
html-to-plaintext Update dependency c8 to v7.13.0 2023-02-16 22:15:50 +00:00
i18n Fixed showing errors when non 2XX response in signup form 2023-06-09 14:12:09 +02:00
importer-handler-content-files Update Test & linting packages 2023-04-05 15:16:08 +02:00
importer-revue Bumped koenig related packages 2023-05-30 08:00:42 +02:00
in-memory-repository Update dependency typescript to v5.1.3 2023-06-02 09:06:20 +02:00
job-manager Update dependency @sinonjs/fake-timers to v10.2.0 2023-06-02 11:01:51 +02:00
link-redirects Update Test & linting packages 2023-04-05 15:16:08 +02:00
link-replacer Added eslint rule for file naming convention 2023-05-09 12:34:34 -04:00
link-tracking Added eslint rule for file naming convention 2023-05-09 12:34:34 -04:00
magic-link Update dependency @types/nodemailer to v6.4.8 2023-06-02 11:01:12 +02:00
mailgun-client Update dependency mailgun.js to v9 2023-06-05 14:34:16 +02:00
member-attribution Added signup form attribution (#16899) 2023-06-01 10:18:11 +02:00
member-events Added eslint rule for file naming convention 2023-05-09 12:34:34 -04:00
members-api Added eslint rule for file naming convention 2023-05-09 12:34:34 -04:00
members-csv Update Test & linting packages 2023-04-05 15:16:08 +02:00
members-events-service Added eslint rule for file naming convention 2023-05-09 12:34:34 -04:00
members-importer Added eslint rule for file naming convention 2023-05-09 12:34:34 -04:00
members-ssr Added eslint rule for file naming convention 2023-05-09 12:34:34 -04:00
mentions-email-report Update Test & linting packages 2023-04-05 15:16:08 +02:00
milestones Update Test & linting packages 2023-04-05 15:16:08 +02:00
minifier 🐛 Fixed generating card assets with include allowlist (#16766) 2023-05-11 14:20:35 +02:00
mw-api-version-mismatch Update Test & linting packages 2023-04-05 15:16:08 +02:00
mw-cache-control Update Test & linting packages 2023-04-05 15:16:08 +02:00
mw-error-handler Update dependency semver to v7.5.1 2023-05-15 15:13:17 +02:00
mw-session-from-token Added eslint rule for file naming convention 2023-05-09 12:34:34 -04:00
mw-update-user-last-seen Update Test & linting packages 2023-04-05 15:16:08 +02:00
mw-version-match Update dependency semver to v7.5.1 2023-05-15 15:13:17 +02:00
mw-vhost Update dependency c8 to v7.13.0 2023-02-16 22:15:50 +00:00
oembed-service Update dependency @extractus/oembed-extractor to v3.1.9 2023-05-30 12:28:56 +02:00
offers Added eslint rule for file naming convention 2023-05-09 12:34:34 -04:00
package-json Update @tryghost 2023-04-07 13:47:12 +02:00
payments Added eslint rule for file naming convention 2023-05-09 12:34:34 -04:00
portal Released Portal v2.33.1 2023-06-07 08:38:25 +02:00
post-revisions Update dependency typescript to v5.1.3 2023-06-02 09:06:20 +02:00
posts-service Wired up collections to posts endpoint (#16945) 2023-06-07 15:06:15 +02:00
referrers Update Test & linting packages 2023-04-05 15:16:08 +02:00
security Update @tryghost 2023-04-07 13:47:12 +02:00
session-service Added eslint rule for file naming convention 2023-05-09 12:34:34 -04:00
settings-path-manager Added eslint rule for file naming convention 2023-05-09 12:34:34 -04:00
signup-form Released Signup Form v0.1.0 2023-06-09 14:31:32 +02:00
slack-notifications Update @tryghost 2023-04-07 13:47:12 +02:00
sodo-search Fixed search input focus on iOS (#16950) 2023-06-07 15:01:28 +08:00
staff-service Added eslint rule for file naming convention 2023-05-09 12:34:34 -04:00
stats-service Update dependency @types/sinon to v10.0.15 2023-05-15 15:12:50 +02:00
stripe Added eslint rule for file naming convention 2023-05-09 12:34:34 -04:00
tiers Update @tryghost 2023-04-07 13:47:12 +02:00
update-check-service Added eslint rule for file naming convention 2023-05-09 12:34:34 -04:00
verification-trigger Added eslint rule for file naming convention 2023-05-09 12:34:34 -04:00
version-notifications-data-service Added eslint rule for file naming convention 2023-05-09 12:34:34 -04:00
webmentions Fixed flaky test: Can generate a mentions report (#16592) 2023-04-07 19:03:22 -07:00