mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-24 11:22:19 +03:00
cbdc91ce48
refs #2635 - Adds 'Location' header to endpoints which create new resources and have corresponding `GET` endpoint as speced in JSON API - https://jsonapi.org/format/#crud-creating-responses-201. Specifically: /posts/ /pages/ /integrations/ /tags/ /members/ /labels/ /notifications/ /invites/ - Adding the header should allow for better resource discoverability and improved logging readability - Added `url` property to the frame constructor. Data in `url` should give enough information to later build up the `Location` header URL for created resource. - Added Location header to headers handler. The Location value is built up from a combination of request URL and the id that is present in the response for the resource. The header is automatically added to requests coming to `add` controller methods which return `id` property in the frame result - Excluded Webhooks API as there is no "GET" endpoint available to fetch the resource
155 lines
5.4 KiB
JavaScript
155 lines
5.4 KiB
JavaScript
const models = require('../../models');
|
|
const {i18n} = require('../../lib/common');
|
|
const errors = require('@tryghost/errors');
|
|
|
|
module.exports = {
|
|
docName: 'webhooks',
|
|
|
|
add: {
|
|
statusCode: 201,
|
|
headers: {
|
|
// NOTE: remove if there is ever a 'read' method
|
|
location: false
|
|
},
|
|
options: [],
|
|
data: [],
|
|
validation: {
|
|
data: {
|
|
event: {
|
|
required: true
|
|
},
|
|
target_url: {
|
|
required: true
|
|
}
|
|
}
|
|
},
|
|
permissions: true,
|
|
query(frame) {
|
|
return models.Webhook.getByEventAndTarget(
|
|
frame.data.webhooks[0].event,
|
|
frame.data.webhooks[0].target_url,
|
|
frame.options
|
|
).then((webhook) => {
|
|
if (webhook) {
|
|
return Promise.reject(
|
|
new errors.ValidationError({message: i18n.t('errors.api.webhooks.webhookAlreadyExists')})
|
|
);
|
|
}
|
|
|
|
return models.Webhook.add(frame.data.webhooks[0], frame.options);
|
|
});
|
|
}
|
|
},
|
|
|
|
edit: {
|
|
permissions: {
|
|
before: (frame) => {
|
|
if (frame.options.context && frame.options.context.integration && frame.options.context.integration.id) {
|
|
return models.Webhook.findOne({id: frame.options.id})
|
|
.then((webhook) => {
|
|
if (!webhook) {
|
|
throw new errors.NotFoundError({
|
|
message: i18n.t('errors.api.resource.resourceNotFound', {
|
|
resource: 'Webhook'
|
|
})
|
|
});
|
|
}
|
|
|
|
if (webhook.get('integration_id') !== frame.options.context.integration.id) {
|
|
throw new errors.NoPermissionError({
|
|
message: i18n.t('errors.api.webhooks.noPermissionToEdit.message', {
|
|
method: 'edit'
|
|
}),
|
|
context: i18n.t('errors.api.webhooks.noPermissionToEdit.context', {
|
|
method: 'edit'
|
|
})
|
|
});
|
|
}
|
|
});
|
|
}
|
|
}
|
|
},
|
|
data: [
|
|
'name',
|
|
'event',
|
|
'target_url',
|
|
'secret',
|
|
'api_version'
|
|
],
|
|
options: [
|
|
'id'
|
|
],
|
|
validation: {
|
|
options: {
|
|
id: {
|
|
required: true
|
|
}
|
|
}
|
|
},
|
|
query({data, options}) {
|
|
return models.Webhook.edit(data.webhooks[0], Object.assign(options, {require: true}))
|
|
.catch(models.Webhook.NotFoundError, () => {
|
|
throw new errors.NotFoundError({
|
|
message: i18n.t('errors.api.resource.resourceNotFound', {
|
|
resource: 'Webhook'
|
|
})
|
|
});
|
|
});
|
|
}
|
|
},
|
|
|
|
destroy: {
|
|
statusCode: 204,
|
|
headers: {},
|
|
options: [
|
|
'id'
|
|
],
|
|
validation: {
|
|
options: {
|
|
id: {
|
|
required: true
|
|
}
|
|
}
|
|
},
|
|
permissions: {
|
|
before: (frame) => {
|
|
if (frame.options.context && frame.options.context.integration && frame.options.context.integration.id) {
|
|
return models.Webhook.findOne({id: frame.options.id})
|
|
.then((webhook) => {
|
|
if (!webhook) {
|
|
throw new errors.NotFoundError({
|
|
message: i18n.t('errors.api.resource.resourceNotFound', {
|
|
resource: 'Webhook'
|
|
})
|
|
});
|
|
}
|
|
|
|
if (webhook.get('integration_id') !== frame.options.context.integration.id) {
|
|
throw new errors.NoPermissionError({
|
|
message: i18n.t('errors.api.webhooks.noPermissionToEdit.message', {
|
|
method: 'destroy'
|
|
}),
|
|
context: i18n.t('errors.api.webhooks.noPermissionToEdit.context', {
|
|
method: 'destroy'
|
|
})
|
|
});
|
|
}
|
|
});
|
|
}
|
|
}
|
|
},
|
|
query(frame) {
|
|
frame.options.require = true;
|
|
return models.Webhook.destroy(frame.options)
|
|
.then(() => null)
|
|
.catch(models.Webhook.NotFoundError, () => {
|
|
return Promise.reject(new errors.NotFoundError({
|
|
message: i18n.t('errors.api.resource.resourceNotFound', {
|
|
resource: 'Webhook'
|
|
})
|
|
}));
|
|
});
|
|
}
|
|
}
|
|
};
|