mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-11-29 07:09:48 +03:00
4744349381
refs https://github.com/TryGhost/Team/issues/694 refs https://linear.app/tryghost/issue/CORE-10/tackle-integrationsjs - The controller code is not meant to contain complex business logic. - Added a test case checking 'PUT' endpoint for integrations to ensure proper 'NotFound' handling. Found that previous implemenation was buggy - threw a 500 as 'models.Integration.NotFoundError' that was removed in previous commit didn't catch a needed error.
62 lines
1.8 KiB
JavaScript
62 lines
1.8 KiB
JavaScript
const {NotFoundError, GhostError} = require('@tryghost/errors');
|
|
const tpl = require('@tryghost/tpl');
|
|
|
|
const messages = {
|
|
notFound: '{resource} not found.'
|
|
};
|
|
|
|
class IntegrationsService {
|
|
constructor({IntegrationModel, ApiKeyModel}) {
|
|
this.IntegrationModel = IntegrationModel;
|
|
this.ApiKeyModel = ApiKeyModel;
|
|
}
|
|
|
|
async edit(data, options) {
|
|
if (options.keyid) {
|
|
const model = await this.ApiKeyModel.findOne({id: options.keyid});
|
|
|
|
if (!model) {
|
|
throw new NotFoundError({
|
|
message: tpl(messages.notFound, {
|
|
resource: 'ApiKey'
|
|
})
|
|
});
|
|
}
|
|
try {
|
|
await this.ApiKeyModel.refreshSecret(model.toJSON(), Object.assign({}, options, {id: options.keyid}));
|
|
|
|
return await this.IntegrationModel.findOne({id: options.id}, {
|
|
withRelated: ['api_keys', 'webhooks']
|
|
});
|
|
} catch (err) {
|
|
throw new GhostError({
|
|
err: err
|
|
});
|
|
}
|
|
}
|
|
|
|
try {
|
|
return await this.IntegrationModel.edit(data, Object.assign(options, {require: true}));
|
|
} catch (error) {
|
|
if (error.message === 'NotFound' || error.message === 'EmptyResponse') {
|
|
throw new NotFoundError({
|
|
message: tpl(messages.notFound, {
|
|
resource: 'Integration'
|
|
})
|
|
});
|
|
}
|
|
|
|
throw error;
|
|
}
|
|
}
|
|
}
|
|
|
|
/**
|
|
* @returns {IntegrationsService} instance of the PostsService
|
|
*/
|
|
const getIntegrationsServiceInstance = ({IntegrationModel, ApiKeyModel}) => {
|
|
return new IntegrationsService({IntegrationModel, ApiKeyModel});
|
|
};
|
|
|
|
module.exports = getIntegrationsServiceInstance;
|