TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-27 10:42:45 +03:00
Code Issues Projects Releases Wiki Activity
4f3b35e4dd
Ghost/apps/admin-x-settings
History
Ronald Langeveld 4f3b35e4dd
Fixed errors not displaying when uploading broken theme in Admin X (#18350) 
refs https://ghost.slack.com/archives/C0568LN2CGJ/p1695716107796769

- The main culprit here was that now since we moved to using some model data from Ember as opposed to just the API, the errors key had to be renamed to gscan_errors  as that's how it's named in the Ember theme model.

---

<!-- Leave the line below if you'd like GitHub Copilot to generate a
summary from your commit -->
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 4bca3ee</samp>

Updated the theme modal and the theme installed modal to use the new
`gscan_errors` property for theme validation. This improves the accuracy
and consistency of the feedback given to users when they upload or
activate themes.
2023-09-26 16:57:50 +07:00
..
.storybook AdminX handling '/' in textfields vs. searchbar shortcut (#18283) 2023-09-25 14:22:10 +02:00
src Fixed errors not displaying when uploading broken theme in Admin X (#18350) 2023-09-26 16:57:50 +07:00
test Slightly improved AdminX pagination behaviour (#18331) 2023-09-25 14:09:35 +00:00
.eslintrc.cjs Temporarily fixed eslint rules being disabled in AdminX (#17565) 2023-08-02 08:37:51 +01:00
.yarnrc Prevented git tags from being created for apps 2023-07-10 13:09:28 +02:00
index.html Moved Admin-X-Settings to apps/ folder 2023-06-23 14:37:39 +02:00
package.json Update dependency @playwright/test to v1.38.1 2023-09-25 09:12:04 +02:00
playwright.config.ts Enabled parallel testing for Playwright tests of apps 2023-07-04 16:08:06 +02:00
postcss.config.cjs Moved Admin-X-Settings to apps/ folder 2023-06-23 14:37:39 +02:00
README.md Moved Admin-X-Settings to apps/ folder 2023-06-23 14:37:39 +02:00
tailwind.config.cjs AdminX mobile updates (#18137) 2023-09-19 12:09:38 +02:00
tsconfig.json Moved Admin-X-Settings to apps/ folder 2023-06-23 14:37:39 +02:00
tsconfig.node.json Moved Admin-X-Settings to apps/ folder 2023-06-23 14:37:39 +02:00
vite.config.ts Added uniqueness validation for the recommendation URL (#18163) 2023-09-15 13:14:47 +00:00

README.md

Admin X Settings

Experimental re-write of Ghost Admin Settings in React

Development

Pre-requisites

  • Run yarn in Ghost monorepo root
  • Run yarn in this directory

Running the development version

Run yarn dev to start the development server to test/develop the settings standalone. This will generate a demo site from the index.html file which renders the app and makes it available on http://localhost:5173

Running inside Admin

Run yarn dev from the top-level repo with --adminX

Develop

This is a monorepo package.

Follow the instructions for the top-level repo.

  1. git clone this repo & cd into it as usual
  2. Run yarn to install top-level dependencies.

Test

  • yarn lint run just eslint
  • yarn test run lint and tests