TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-09-19 16:47:40 +03:00
Code Issues Projects Releases Wiki Activity
54ee8d3389
Ghost/apps/comments-ui
History
Simon Backx b6519e0f1f
Removed usage of unquoted ids in filter strings (#19070) 
fixes GRO-34
fixes GRO-33

This is a revision of a previous commit, that broke the browser tests
because changes in the data generator (requiring bookshelf had side
effects).

This adds a new way to run all tests with enforced numeric ObjectIDs.
These numeric ids cause issues if they are used withing NQL filters. So
they surface tiny bugs in our codebase.

You can run tests using this option via:
NUMERIC_IDS=1 yarn test:e2e

Removed some defensive logic that could be explained by this discovered
issue.
2023-11-21 09:45:36 +01:00
..
src Removed usage of unquoted ids in filter strings (#19070) 2023-11-21 09:45:36 +01:00
test Converted Comments-UI App to TypeScript and React hooks (#17760) 2023-08-18 13:30:59 +00:00
.env Added custom build setup 2022-07-04 15:15:01 +02:00
.eslintrc.js ✨Extended translations beta to comments (#17801) 2023-08-24 10:33:03 +02:00
.yarnrc Prevented git tags from being created for apps 2023-07-10 13:09:28 +02:00
LICENSE Migrated from Webpack to Vite and updated dependencies 2023-06-21 15:28:01 +02:00
package.json Update dependency @vitejs/plugin-react to v4.2.0 2023-11-20 09:42:07 +01:00
playwright.config.ts Temporarily increased timeout for Comments-UI web server init 2023-09-15 10:48:08 +02:00
postcss.config.cjs Migrated Comments-UI to TypeScript (#17129) 2023-06-27 14:51:37 +02:00
README.md Configured yarn dev to allow starting Comments-UI 2023-06-22 10:23:05 +02:00
tailwind.config.js Removed the duplicate sm config 2022-11-11 15:25:57 +00:00
tsconfig.json Converted Comments-UI App to TypeScript and React hooks (#17760) 2023-08-18 13:30:59 +00:00
tsconfig.node.json Migrated Comments-UI to TypeScript (#17129) 2023-06-27 14:51:37 +02:00
vite.config.ts Hidden "info" Vite output unless in CI 2023-11-15 10:11:22 +01:00

README.md

Comments UI

Comments widget that is embedded at the bottom of posts in Ghost.

Development

Pre-requisites

  • Run yarn in Ghost monorepo root

Running via Ghost yarn dev in root folder

You can automatically start the comments dev server when developing Ghost by running Ghost (in root folder) via yarn dev --all or yarn dev --comments. This will host the comments JavaScript files, and makes sure that Ghost uses these locally hosted assets instead of the ones from the CDN.

Copyright & License

Copyright (c) 2013-2023 Ghost Foundation - Released under the MIT license.