TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-24 14:43:08 +03:00
Code Issues Projects Releases Wiki Activity
5513cfbbdb
Ghost/ghost/admin
History
Kevin Ansfield 5513cfbbdb 🐛 Fixed error preventing publish for non-Admin staff users 
refs e3db911108

Contributors/Authors/Editors do not have permissions to fetch members so the request to fetch a member count when checking member host limits fails and blocked publishing because it was treated like a failed limit check.

- prevented the up-front limit check from running for non-Admin staff users. Publishing will still fail for other users if the site is over the hosting plan members limit but the error will be shown later in the flow when the actual publish request is made.
2022-09-27 13:24:37 +01:00
..
app 🐛 Fixed error preventing publish for non-Admin staff users 2022-09-27 13:24:37 +01:00
config Updated ember-auto-import@1 -> ember-auto-import@2 (#2252) 2022-08-02 13:43:28 +01:00
lib Added audio/x-m4a to allowed mime types in audio card 2022-09-14 09:04:58 +01:00
mirage Added email_track_clicks setting (#15409) 2022-09-15 15:48:22 +02:00
public/assets Added a new click icon for the member attribution flag 2022-09-22 18:00:48 +01:00
tests 🐛 Fixed confusing error state when publishing if member count is over hosting plan limit (#15473) 2022-09-26 17:37:35 +01:00
.editorconfig deps: ember-cli@2.8.0 2016-10-07 17:32:30 +01:00
.ember-cli Co-located component template files 2020-05-18 13:14:08 +01:00
.eslintignore Updated Ember dependencies to 3.24 (#2221) 2022-01-22 11:24:26 +00:00
.eslintrc.js Updated Eslint ECMAScript compatibility to 2022 2022-08-09 15:51:40 +02:00
.gitignore Added test documentation to README 2022-06-02 10:38:51 +02:00
.lint-todo Created separate table templates for posts with emailClicks enabled 2022-09-13 11:57:05 +02:00
.lint-todorc.js Reset linter warnings with longer decay times 2022-05-09 12:57:19 +01:00
.template-lintrc.js Added disabled newsletter dropdown to scheduled state of publish menu (#2357) 2022-04-27 10:49:55 +01:00
.watchmanconfig deps: ember-cli@1.13.13 2015-11-30 11:21:39 -06:00
ember-cli-build.js Configured all Admin assets to contain fingerprint hash 2022-09-12 10:54:10 +01:00
ember-cli-update.json Updated core files to match ember-cli new output 2020-08-03 09:24:58 +01:00
package.json v5.16.1 2022-09-27 05:21:10 +01:00
README.md Tidied up Admin README 2022-08-03 21:16:04 +02:00
testem.js Only show failed tests in Admin CI output 2022-08-31 15:53:27 +01:00

README.md

Ghost-Admin

This is the home of the Ember.js-based Admin app that ships with Ghost.

Running tests

Build and run tests once:

TZ=UTC yarn test

Note the TZ=UTC environment variable which is currently required to get tests working if your system timezone doesn't match UTC.

If you are serving the admin app (e.g., when running yarn serve, or when running yarn dev in the main Ghost project), you can also run the tests in your browser by going to http://localhost:4200/tests.

This has the additional benefit that you can use await this.pauseTest() in your tests to temporarily pause tests (best to also add this.timeout(0); to avoid timeouts). This allows you to inspect the DOM in your browser to debug tests. You can resume tests by running resumeTest() in your browser console.

More information

Writing tests

When writing tests and not using the http://localhost:4200/tests browser tests, it can be easier to have a separate watching build that builds the project for the test environment (this drastically reduces the time you have to wait when running tests):

yarn build --environment=test -w -o="dist-test"

After that, you can easily run tests locally:

Run all tests:

TZ=UTC yarn test 1 --path="dist-test"

To have a cleaner output:

TZ=UTC yarn test 1 --reporter dot  --path="dist-test"

This shows a dot (.) for every successful test, and F for every failed test. At the end, it will only show the output of the failed tests.

To run a specific test file:

TZ=UTC yarn test 1 --reporter dot  --path="dist-test" -mp=tests/acceptance/settings/newsletters-test.js

Hint: you can easily copy the path of a test in VSCode by right clicking on the test file and choosing Copy Relative Path.

To have a full list of the available options, run

ember exam --help

Copyright & License

Copyright (c) 2013-2022 Ghost Foundation - Released under the MIT license. Ghost and the Ghost Logo are trademarks of Ghost Foundation Ltd. Please see our trademark policy for info on acceptable usage.