mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-22 02:11:44 +03:00
9dbb2785bb
fixes https://github.com/TryGhost/Team/issues/1344 fixes https://github.com/TryGhost/Team/issues/1127 This fixes a couple of bugs with the filter menu on the members page in admin: - When opening the members page, the filters property was passed back from the filter component to the members controller. This caused a bug that the filter columns where not visible on reload. - Fixed handling invalid filter parameters - When updating the URL, the members page now properly reloads - Fixed a bug that 'falsy' values in the NQL filter were removed on reload: - Filtering on unsubscribed members was gone after a page reload - Filtering on 0 emails was gone after a page reload - This is fixed by converting numbers and booleans to strings after parsing the NQL-filter - Fixed a bug where boolean values didn't match any value in the select menu, causing the default option to be visible - Filtering members by 'unsubscribed' -> parsed as false (boolean) -> select menu opened -> false value (boolean) didn't match 'false' (string) so the first option was shown instead (subscribed). - This is also fixed by converting numbers and booleans to strings after parsing the NQL-filter The way this is currently handled is not great. The parsing happens in the filter component, but should happen on a different layer, maybe in a different helper. This is tracked here: https://github.com/TryGhost/Team/issues/1849 |
||
|---|---|---|
| .. | ||
| filter-value.hbs | ||
| filter-value.js | ||
| filter.hbs | ||
| filter.js | ||