mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-04 12:44:57 +03:00
6161f94910
refs: https://github.com/TryGhost/Toolbox/issues/595 We're rolling out new rules around the node assert library, the first of which is enforcing the use of assert/strict. This means we don't need to use the strict version of methods, as the standard version will work that way by default. This caught some gotchas in our existing usage of assert where the lack of strict mode had unexpected results: - Url matching needs to be done on `url.href` seeaa58b354a4
- Null and undefined are not the same thing, there were a few cases of this being confused - Particularly questionable changes in [PostExporter tests](c1a468744b
) tracked [here](https://github.com/TryGhost/Team/issues/3505). - A typo seeeaac9c293a
Moving forward, using assert strict should help us to catch unexpected behaviour, particularly around nulls and undefineds during implementation.
144 lines
5.1 KiB
JavaScript
144 lines
5.1 KiB
JavaScript
const path = require('path');
|
|
const assert = require('assert/strict');
|
|
const {parse} = require('../index');
|
|
const csvPath = path.join(__dirname, '/fixtures/');
|
|
|
|
describe('parse', function () {
|
|
const DEFAULT_HEADER_MAPPING = {
|
|
email: 'email',
|
|
name: 'name'
|
|
};
|
|
|
|
it('empty file', async function () {
|
|
const filePath = csvPath + 'empty.csv';
|
|
const result = await parse(filePath, DEFAULT_HEADER_MAPPING);
|
|
|
|
assert.ok(result);
|
|
assert.equal(result.length, 0);
|
|
});
|
|
|
|
it('one column', async function () {
|
|
const filePath = csvPath + 'single-column-with-header.csv';
|
|
const result = await parse(filePath, DEFAULT_HEADER_MAPPING);
|
|
|
|
assert.ok(result);
|
|
assert.equal(result.length, 2);
|
|
assert.equal(result[0].email, 'jbloggs@example.com');
|
|
assert.equal(result[1].email, 'test@example.com');
|
|
});
|
|
|
|
it('one column without header mapping returns empty result', async function () {
|
|
const filePath = csvPath + 'single-column-with-header.csv';
|
|
const result = await parse(filePath);
|
|
|
|
assert.ok(result);
|
|
assert.equal(result.length, 0);
|
|
});
|
|
|
|
it('two columns, 1 filter', async function () {
|
|
const filePath = csvPath + 'two-columns-with-header.csv';
|
|
const result = await parse(filePath, DEFAULT_HEADER_MAPPING);
|
|
|
|
assert.ok(result);
|
|
assert.equal(result.length, 2);
|
|
assert.equal(result[0].email, 'jbloggs@example.com');
|
|
assert.equal(result[1].email, 'test@example.com');
|
|
});
|
|
|
|
it('two columns, 2 filters', async function () {
|
|
const filePath = csvPath + 'two-columns-obscure-header.csv';
|
|
const mapping = {
|
|
id: 'id',
|
|
'Email Address': 'email'
|
|
};
|
|
const result = await parse(filePath, mapping);
|
|
|
|
assert.ok(result);
|
|
assert.equal(result.length, 2);
|
|
assert.equal(result[0].email, 'jbloggs@example.com');
|
|
assert.equal(result[0].id, '1');
|
|
assert.equal(result[1].email, 'test@example.com');
|
|
assert.equal(result[1].id, '2');
|
|
});
|
|
|
|
it('two columns with mapping', async function () {
|
|
const filePath = csvPath + 'two-columns-mapping-header.csv';
|
|
const mapping = {
|
|
id: 'id',
|
|
correo_electronico: 'email',
|
|
nombre: 'name'
|
|
};
|
|
const result = await parse(filePath, mapping);
|
|
|
|
assert.ok(result);
|
|
assert.equal(result.length, 2);
|
|
assert.equal(result[0].email, 'jbloggs@example.com');
|
|
assert.equal(result[0].name, 'joe');
|
|
assert.equal(result[0].id, '1');
|
|
|
|
assert.equal(result[1].email, 'test@example.com');
|
|
assert.equal(result[1].name, 'test');
|
|
assert.equal(result[1].id, '2');
|
|
});
|
|
|
|
it('two columns with partial mapping', async function () {
|
|
const filePath = csvPath + 'two-columns-mapping-header.csv';
|
|
const mapping = {
|
|
id: 'id',
|
|
correo_electronico: 'email'
|
|
};
|
|
const result = await parse(filePath, mapping);
|
|
|
|
assert.ok(result);
|
|
assert.equal(result.length, 2);
|
|
assert.equal(result[0].email, 'jbloggs@example.com');
|
|
assert.equal(result[0].id, '1');
|
|
|
|
assert.equal(result[1].email, 'test@example.com');
|
|
assert.equal(result[1].id, '2');
|
|
});
|
|
|
|
it('transforms empty values to nulls', async function () {
|
|
const filePath = csvPath + 'multiple-records-with-empty-values.csv';
|
|
const result = await parse(filePath, DEFAULT_HEADER_MAPPING);
|
|
|
|
assert.ok(result);
|
|
assert.equal(result.length, 2);
|
|
assert.equal(result[0].email, 'jbloggs@example.com');
|
|
assert.equal(result[0].name, 'Bob');
|
|
|
|
assert.equal(result[1].email, 'test@example.com');
|
|
assert.equal(result[1].name, null);
|
|
});
|
|
|
|
it(' transforms "subscribed_to_emails" column to "subscribed" property when the mapping is passed in', async function () {
|
|
const filePath = csvPath + 'subscribed-to-emails-header.csv';
|
|
const mapping = {
|
|
email: 'email',
|
|
subscribed_to_emails: 'subscribed'
|
|
};
|
|
const result = await parse(filePath, mapping);
|
|
|
|
assert.ok(result);
|
|
assert.equal(result.length, 2);
|
|
assert.equal(result[0].email, 'jbloggs@example.com');
|
|
assert.ok(result[0].subscribed);
|
|
|
|
assert.equal(result[1].email, 'test@example.com');
|
|
assert.equal(result[1].subscribed, false);
|
|
});
|
|
|
|
it('DOES NOT transforms "subscribed_to_emails" column to "subscribed" property when the WITHOUT mapping', async function () {
|
|
const filePath = csvPath + 'subscribed-to-emails-header.csv';
|
|
const result = await parse(filePath, DEFAULT_HEADER_MAPPING);
|
|
|
|
assert.ok(result);
|
|
assert.equal(result.length, 2);
|
|
assert.equal(result[0].email, 'jbloggs@example.com');
|
|
assert.equal(result[0].subscribed_to_emails, undefined, 'property not present in the mapping should not be defined');
|
|
|
|
assert.equal(result[1].email, 'test@example.com');
|
|
assert.equal(result[1].subscribed_to_emails, undefined, 'property not present in the mapping should not be defined');
|
|
});
|
|
});
|