mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-11 09:53:32 +03:00
6161f94910
refs: https://github.com/TryGhost/Toolbox/issues/595 We're rolling out new rules around the node assert library, the first of which is enforcing the use of assert/strict. This means we don't need to use the strict version of methods, as the standard version will work that way by default. This caught some gotchas in our existing usage of assert where the lack of strict mode had unexpected results: - Url matching needs to be done on `url.href` seeaa58b354a4- Null and undefined are not the same thing, there were a few cases of this being confused - Particularly questionable changes in [PostExporter tests](c1a468744b) tracked [here](https://github.com/TryGhost/Team/issues/3505). - A typo seeeaac9c293aMoving forward, using assert strict should help us to catch unexpected behaviour, particularly around nulls and undefineds during implementation.
57 lines
1.8 KiB
JavaScript
57 lines
1.8 KiB
JavaScript
const assert = require('assert/strict');
|
|
const http = require('http');
|
|
const path = require('path');
|
|
|
|
const models = require('../../../core/server/models');
|
|
|
|
models.init();
|
|
|
|
const jobService = require('../../../core/server/services/jobs/job-service');
|
|
|
|
const JOB_NAME = 'update-check';
|
|
const JOB_PATH = path.resolve(__dirname, '../../../core/server/run-update-check.js');
|
|
|
|
describe('Run Update Check', function () {
|
|
let mockUpdateServer;
|
|
|
|
afterEach(function () {
|
|
if (mockUpdateServer) {
|
|
mockUpdateServer.close();
|
|
}
|
|
});
|
|
|
|
it('successfully executes the update checker', async function () {
|
|
let mockUpdateServerRequestCount = 0;
|
|
|
|
// Initialise mock update server - We use a mock server here instead of
|
|
// nock because the update-check job will be executed in a separate
|
|
// process which will prevent nock from intercepting HTTP requests
|
|
mockUpdateServer = http.createServer((req, res) => {
|
|
mockUpdateServerRequestCount += 1;
|
|
|
|
res.writeHead(200, {'Content-Type': 'application/json'});
|
|
|
|
res.end(JSON.stringify({hello: 'world'}));
|
|
});
|
|
|
|
mockUpdateServer.listen(0); // Listen on random port
|
|
|
|
const mockUpdateServerPort = mockUpdateServer.address().port;
|
|
|
|
// Trigger the update-check job and wait for it to finish
|
|
await jobService.addJob({
|
|
name: JOB_NAME,
|
|
job: JOB_PATH,
|
|
data: {
|
|
forceUpdate: true,
|
|
updateCheckUrl: `http://127.0.0.1:${mockUpdateServerPort}`
|
|
}
|
|
});
|
|
|
|
await jobService.awaitCompletion(JOB_NAME);
|
|
|
|
// Assert that the mock update server received a request (which means the update-check job ran successfully)
|
|
assert.equal(mockUpdateServerRequestCount, 1, 'Expected mock server to receive 1 request');
|
|
});
|
|
});
|