mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-11-30 01:42:29 +03:00
2231dd84c2
no issue
Ember is migrating to `<AngleBracketSyntax />` for component invocation, see https://github.com/emberjs/rfcs/blob/master/text/0311-angle-bracket-invocation.md
We were in a half-way situation where some templates used angle bracket syntax in some places, this PR updates templates to use the syntax everywhere.
This simplifies the rules for what template code is referring to...
`<Component>` = a component
`{{helper}}` = a helper (or locally assigned handlebars variable)
`{{this.foo}}` = data on the template backing context (a component/controller)
`{{@foo}}` = a named argument passed into the component that the component backing class has not modified (note: this commit does not introduce any named arguments)
- ran codemod https://github.com/ember-codemods/ember-angle-brackets-codemod on the following directories:
- `app/templates`
- `lib/koenig-editor/addon/templates`
- removed positional params from components as angle bracket syntax does not support them
- `gh-feature-flag`
- `gh-tour-item`
- `gh-cm-editor`
- `gh-fullscreen-modal`
- `gh-task-button`
- updates some code that was missed in 3c851293c1 to use explicit this
45 lines
1.1 KiB
JavaScript
45 lines
1.1 KiB
JavaScript
import Component from '@ember/component';
|
|
import {computed, defineProperty} from '@ember/object';
|
|
import {readOnly} from '@ember/object/computed';
|
|
import {inject as service} from '@ember/service';
|
|
|
|
const FeatureFlagComponent = Component.extend({
|
|
feature: service(),
|
|
|
|
tagName: 'label',
|
|
classNames: 'checkbox',
|
|
attributeBindings: ['for', 'disabled'],
|
|
disabled: computed('_disabled', function () {
|
|
if (this._disabled) {
|
|
return true;
|
|
}
|
|
return false;
|
|
}),
|
|
value: computed('_flagValue', {
|
|
get() {
|
|
return this._flagValue;
|
|
},
|
|
set(key, value) {
|
|
return this.set(`feature.${this.flag}`, value);
|
|
}
|
|
}),
|
|
|
|
for: computed('flag', function () {
|
|
return `labs-${this.flag}`;
|
|
}),
|
|
|
|
name: computed('flag', function () {
|
|
return `labs[${this.flag}]`;
|
|
}),
|
|
|
|
init() {
|
|
this._super(...arguments);
|
|
|
|
defineProperty(this, '_flagValue', readOnly(`feature.${this.flag}`), function () {
|
|
return this.get(`feature.${this.flag}`);
|
|
});
|
|
}
|
|
});
|
|
|
|
export default FeatureFlagComponent;
|