Ghost/ghost/admin/tests/acceptance/editor-test.js
Kevin Ansfield 6a9239974f Fixed missing Unsplash icons when API doesn't return an unsplash setting (#865)
closes https://github.com/TryGhost/Ghost/issues/9031

- add a default value `unsplash` value to the `setting` model so that Unsplash is activated when the server doesn't return an `unsplash` setting
- update the `unsplash-settings` transform to always deserialize or serialize to `{isActive: true}` when the value is blank or not parsable
- add acceptance regression test covering API not returning an `unplash` setting
- add unit tests for the `unsplash-settings` transform
2017-09-21 11:13:31 +02:00

779 lines
30 KiB
JavaScript

/* jshint expr:true */
import Mirage from 'ember-cli-mirage';
import destroyApp from '../helpers/destroy-app';
import moment from 'moment';
import sinon from 'sinon';
import startApp from '../helpers/start-app';
import {afterEach, beforeEach, describe, it} from 'mocha';
import {authenticateSession, invalidateSession} from 'ghost-admin/tests/helpers/ember-simple-auth';
import {expect} from 'chai';
describe('Acceptance: Editor', function() {
let application;
beforeEach(function() {
application = startApp();
});
afterEach(function() {
destroyApp(application);
});
it('redirects to signin when not authenticated', async function () {
server.create('user'); // necesary for post-author association
server.create('post');
invalidateSession(application);
await visit('/editor/1');
expect(currentURL(), 'currentURL').to.equal('/signin');
});
it('does not redirect to team page when authenticated as author', async function () {
let role = server.create('role', {name: 'Author'});
server.create('user', {roles: [role], slug: 'test-user'});
server.create('post');
authenticateSession(application);
await visit('/editor/1');
expect(currentURL(), 'currentURL').to.equal('/editor/1');
});
it('does not redirect to team page when authenticated as editor', async function () {
let role = server.create('role', {name: 'Editor'});
server.create('user', {roles: [role], slug: 'test-user'});
server.create('post');
authenticateSession(application);
await visit('/editor/1');
expect(currentURL(), 'currentURL').to.equal('/editor/1');
});
it('displays 404 when post does not exist', async function () {
let role = server.create('role', {name: 'Editor'});
server.create('user', {roles: [role], slug: 'test-user'});
authenticateSession(application);
await visit('/editor/1');
expect(currentPath()).to.equal('error404');
expect(currentURL()).to.equal('/editor/1');
});
describe('when logged in', function () {
beforeEach(function () {
let role = server.create('role', {name: 'Administrator'});
server.create('user', {roles: [role]});
server.loadFixtures('settings');
return authenticateSession(application);
});
it('renders the editor correctly, PSM Publish Date and Save Button', async function () {
let [post1] = server.createList('post', 2);
let futureTime = moment().tz('Etc/UTC').add(10, 'minutes');
// post id 1 is a draft, checking for draft behaviour now
await visit('/editor/1');
expect(currentURL(), 'currentURL')
.to.equal('/editor/1');
// open post settings menu
await click('[data-test-psm-trigger]');
// should error, if the publish time is in the wrong format
await fillIn('[data-test-date-time-picker-time-input]', 'foo');
await triggerEvent('[data-test-date-time-picker-time-input]', 'blur');
expect(find('[data-test-date-time-picker-error]').text().trim(), 'inline error response for invalid time')
.to.equal('Must be in format: "15:00"');
// should error, if the publish time is in the future
// NOTE: date must be selected first, changing the time first will save
// with the new time
await datepickerSelect('[data-test-date-time-picker-datepicker]', moment.tz('Etc/UTC'));
await fillIn('[data-test-date-time-picker-time-input]', futureTime.format('HH:mm'));
await triggerEvent('[data-test-date-time-picker-time-input]', 'blur');
expect(find('[data-test-date-time-picker-error]').text().trim(), 'inline error response for future time')
.to.equal('Must be in the past');
// closing the PSM will reset the invalid date/time
await click('[data-test-close-settings-menu]');
await click('[data-test-psm-trigger]');
expect(
find('[data-test-date-time-picker-error]').text().trim(),
'date picker error after closing PSM'
).to.equal('');
expect(
find('[data-test-date-time-picker-date-input]').val(),
'PSM date value after closing with invalid date'
).to.equal(moment(post1.publishedAt).tz('Etc/UTC').format('MM/DD/YYYY'));
expect(
find('[data-test-date-time-picker-time-input]').val(),
'PSM time value after closing with invalid date'
).to.equal(moment(post1.publishedAt).tz('Etc/UTC').format('HH:mm'));
// saves the post with the new date
let validTime = moment('2017-04-09 12:00').tz('Etc/UTC');
await fillIn('[data-test-date-time-picker-time-input]', validTime.format('HH:mm'));
await triggerEvent('[data-test-date-time-picker-time-input]', 'blur');
await datepickerSelect('[data-test-date-time-picker-datepicker]', validTime);
// hide psm
await click('[data-test-psm-trigger]');
// checking the flow of the saving button for a draft
expect(
find('[data-test-publishmenu-trigger]').text().trim(),
'draft publish button text'
).to.equal('Publish');
expect(
find('[data-test-editor-post-status]').text().trim(),
'draft status text'
).to.equal('Draft');
// click on publish now
await click('[data-test-publishmenu-trigger]');
expect(
find('[data-test-publishmenu-draft]'),
'draft publish menu is shown'
).to.exist;
await click('[data-test-publishmenu-scheduled-option]');
expect(
find('[data-test-publishmenu-save]').text().trim(),
'draft post schedule button text'
).to.equal('Schedule');
await click('[data-test-publishmenu-published-option]');
expect(
find('[data-test-publishmenu-save]').text().trim(),
'draft post publish button text'
).to.equal('Publish');
// Publish the post
await click('[data-test-publishmenu-save]');
expect(
find('[data-test-publishmenu-save]').text().trim(),
'publish menu save button updated after draft is published'
).to.equal('Published');
expect(
find('[data-test-publishmenu-published]'),
'publish menu is shown after draft published'
).to.exist;
expect(
find('[data-test-editor-post-status]').text().trim(),
'post status updated after draft published'
).to.equal('Published');
await click('[data-test-publishmenu-cancel]');
await click('[data-test-publishmenu-trigger]');
await click('[data-test-publishmenu-unpublished-option]');
expect(
find('[data-test-publishmenu-save]').text().trim(),
'published post unpublish button text'
).to.equal('Unpublish');
// post id 2 is a published post, checking for published post behaviour now
await visit('/editor/2');
expect(currentURL(), 'currentURL').to.equal('/editor/2');
expect(find('[data-test-date-time-picker-date-input]').val()).to.equal('12/19/2015');
expect(find('[data-test-date-time-picker-time-input]').val()).to.equal('16:25');
// saves the post with a new date
await datepickerSelect('[data-test-date-time-picker-datepicker]', moment('2016-05-10 10:00'));
await fillIn('[data-test-date-time-picker-time-input]', '10:00');
await triggerEvent('[data-test-date-time-picker-time-input]', 'blur');
// saving
await click('[data-test-publishmenu-trigger]');
expect(
find('[data-test-publishmenu-save]').text().trim(),
'published button text'
).to.equal('Update');
await click('[data-test-publishmenu-save]');
expect(
find('[data-test-publishmenu-save]').text().trim(),
'publish menu save button updated after published post is updated'
).to.equal('Updated');
// go to settings to change the timezone
await visit('/settings/general');
await click('[data-test-toggle-timezone]');
expect(currentURL(), 'currentURL for settings')
.to.equal('/settings/general');
expect(find('#activeTimezone option:selected').text().trim(), 'default timezone')
.to.equal('(GMT) UTC');
// select a new timezone
find('#activeTimezone option[value="Pacific/Kwajalein"]').prop('selected', true);
await triggerEvent('#activeTimezone', 'change');
// save the settings
await click('.gh-btn.gh-btn-blue');
expect(find('#activeTimezone option:selected').text().trim(), 'new timezone after saving')
.to.equal('(GMT +12:00) International Date Line West');
// and now go back to the editor
await visit('/editor/2');
expect(currentURL(), 'currentURL in editor')
.to.equal('/editor/2');
expect(
find('[data-test-date-time-picker-date-input]').val(),
'date after timezone change'
).to.equal('05/10/2016');
expect(
find('[data-test-date-time-picker-time-input]').val(),
'time after timezone change'
).to.equal('22:00');
// unpublish
await click('[data-test-publishmenu-trigger]');
await click('[data-test-publishmenu-unpublished-option]');
expect(
find('[data-test-publishmenu-save]').text().trim(),
'published post unpublish button text'
).to.equal('Unpublish');
await click('[data-test-publishmenu-save]');
expect(
find('[data-test-publishmenu-save]').text().trim(),
'publish menu save button updated after published post is unpublished'
).to.equal('Unpublished');
expect(
find('[data-test-publishmenu-draft]'),
'draft menu is shown after unpublished'
).to.exist;
expect(
find('[data-test-editor-post-status]').text().trim(),
'post status updated after unpublished'
).to.equal('Draft');
// schedule post
await click('[data-test-publishmenu-cancel]');
await click('[data-test-publishmenu-trigger]');
let newFutureTime = moment.tz('Pacific/Kwajalein').add(10, 'minutes');
await click('[data-test-publishmenu-scheduled-option]');
expect(
find('[data-test-publishmenu-save]').text().trim(),
'draft post, schedule button text'
).to.equal('Schedule');
await datepickerSelect('[data-test-publishmenu-draft] [data-test-date-time-picker-datepicker]', newFutureTime);
await click('[data-test-publishmenu-save]');
expect(
find('[data-test-publishmenu-save]').text().trim(),
'publish menu save button updated after draft is scheduled'
).to.equal('Scheduled');
await click('[data-test-publishmenu-cancel]');
expect(
find('[data-test-publishmenu-scheduled]'),
'publish menu is not shown after closed'
).to.not.exist;
// expect countdown to show warning, that post will be published in x minutes
expect(find('[data-test-schedule-countdown]').text().trim(), 'notification countdown')
.to.contain('Post will be published in');
expect(
find('[data-test-publishmenu-trigger]').text().trim(),
'scheduled publish button text'
).to.equal('Scheduled');
expect(
find('[data-test-editor-post-status]').text().trim(),
'scheduled post status'
).to.equal('Scheduled');
// Re-schedule
await click('[data-test-publishmenu-trigger]');
await click('[data-test-publishmenu-scheduled-option]');
expect(
find('[data-test-publishmenu-save]').text().trim(),
'scheduled post button reschedule text'
).to.equal('Reschedule');
await click('[data-test-publishmenu-save]');
expect(
find('[data-test-publishmenu-save]').text().trim(),
'publish menu save button text for a rescheduled post'
).to.equal('Rescheduled');
await click('[data-test-publishmenu-cancel]');
expect(
find('[data-test-publishmenu-scheduled]'),
'publish menu is not shown after closed'
).to.not.exist;
expect(
find('[data-test-editor-post-status]').text().trim(),
'scheduled status text'
).to.equal('Scheduled');
// unschedule
await click('[data-test-publishmenu-trigger]');
await click('[data-test-publishmenu-draft-option]');
expect(
find('[data-test-publishmenu-save]').text().trim(),
'publish menu save button updated after scheduled post is unscheduled'
).to.equal('Unschedule');
await click('[data-test-publishmenu-save]');
expect(
find('[data-test-publishmenu-save]').text().trim(),
'publish menu save button updated after scheduled post is unscheduled'
).to.equal('Unscheduled');
await click('[data-test-publishmenu-cancel]');
expect(
find('[data-test-publishmenu-trigger]').text().trim(),
'publish button text after unschedule'
).to.equal('Publish');
expect(
find('[data-test-editor-post-status]').text().trim(),
'status text after unschedule'
).to.equal('Draft');
expect(
find('[data-test-schedule-countdown]'),
'scheduled countdown after unschedule'
).to.not.exist;
});
it('handles validation errors when scheduling', async function () {
server.put('/posts/:id/', function () {
return new Mirage.Response(422, {}, {
errors: [{
errorType: 'ValidationError',
message: 'Error test'
}]
});
});
let post = server.create('post', 1);
let plusTenMin = moment().utc().add(10, 'minutes');
await visit(`/editor/${post.id}`);
await click('[data-test-publishmenu-trigger]');
await click('[data-test-publishmenu-scheduled-option]');
await datepickerSelect('[data-test-publishmenu-draft] [data-test-date-time-picker-datepicker]', plusTenMin);
await fillIn('[data-test-publishmenu-draft] [data-test-date-time-picker-time-input]', plusTenMin.format('HH:mm'));
await triggerEvent('[data-test-publishmenu-draft] [data-test-date-time-picker-time-input]', 'blur');
await click('[data-test-publishmenu-save]');
expect(
find('.gh-alert').length,
'number of alerts after failed schedule'
).to.equal(1);
expect(
find('.gh-alert').text(),
'alert text after failed schedule'
).to.match(/Saving failed: Error test/);
});
it('handles title validation errors correctly', async function () {
server.createList('post', 1);
// post id 1 is a draft, checking for draft behaviour now
await visit('/editor/1');
expect(currentURL(), 'currentURL')
.to.equal('/editor/1');
await fillIn('[data-test-editor-title-input]', Array(260).join('a'));
await click('[data-test-publishmenu-trigger]');
await click('[data-test-publishmenu-save]');
expect(
find('.gh-alert').length,
'number of alerts after invalid title'
).to.equal(1);
expect(
find('.gh-alert').text(),
'alert text after invalid title'
).to.match(/Title cannot be longer than 255 characters/);
});
// NOTE: these tests are specific to the mobiledoc editor
// it('inserts a placeholder if the title is blank', async function () {
// server.createList('post', 1);
//
// // post id 1 is a draft, checking for draft behaviour now
// await visit('/editor/1');
//
// expect(currentURL(), 'currentURL')
// .to.equal('/editor/1');
//
// await titleRendered();
//
// let title = find('#koenig-title-input div');
// expect(title.data('placeholder')).to.equal('Your Post Title');
// expect(title.hasClass('no-content')).to.be.false;
//
// await replaceTitleHTML('');
// expect(title.hasClass('no-content')).to.be.true;
//
// await replaceTitleHTML('test');
// expect(title.hasClass('no-content')).to.be.false;
// });
//
// it('removes HTML from the title.', async function () {
// server.createList('post', 1);
//
// // post id 1 is a draft, checking for draft behaviour now
// await visit('/editor/1');
//
// expect(currentURL(), 'currentURL')
// .to.equal('/editor/1');
//
// await titleRendered();
//
// let title = find('#koenig-title-input div');
// await replaceTitleHTML('<div>TITLE&nbsp;&#09;&nbsp;&thinsp;&ensp;&emsp;TEST</div>&nbsp;');
// expect(title.html()).to.equal('TITLE TEST ');
// });
it('renders first countdown notification before scheduled time', async function () {
let clock = sinon.useFakeTimers(moment().valueOf());
let compareDate = moment().tz('Etc/UTC').add(4, 'minutes');
let compareDateString = compareDate.format('MM/DD/YYYY');
let compareTimeString = compareDate.format('HH:mm');
server.create('post', {publishedAt: moment.utc().add(4, 'minutes'), status: 'scheduled'});
server.create('setting', {activeTimezone: 'Europe/Dublin'});
clock.restore();
await visit('/editor/1');
expect(currentURL(), 'currentURL')
.to.equal('/editor/1');
expect(find('[data-test-date-time-picker-date-input]').val(), 'scheduled date')
.to.equal(compareDateString);
expect(find('[data-test-date-time-picker-time-input]').val(), 'scheduled time')
.to.equal(compareTimeString);
// Dropdown menu should be 'Update Post' and 'Unschedule'
expect(find('[data-test-publishmenu-trigger]').text().trim(), 'text in save button for scheduled post')
.to.equal('Scheduled');
// expect countdown to show warning, that post will be published in x minutes
expect(find('[data-test-schedule-countdown]').text().trim(), 'notification countdown')
.to.contain('Post will be published in');
});
it('shows author list and allows switching of author in PSM', async function () {
server.create('post', {authorId: 1});
let role = server.create('role', {name: 'Author'});
let author = server.create('user', {name: 'Waldo', roles: [role]});
await visit('/editor/1');
expect(currentURL(), 'currentURL')
.to.equal('/editor/1');
await click('button.post-settings');
expect(find('select[name="post-setting-author"]').val()).to.equal('1');
expect(find('select[name="post-setting-author"] option[value="2"]')).to.be.ok;
await fillIn('select[name="post-setting-author"]', '2');
expect(find('select[name="post-setting-author"]').val()).to.equal('2');
expect(server.db.posts[0].authorId).to.equal(author.id);
});
it('autosaves when title loses focus', async function () {
let role = server.create('role', {name: 'Administrator'});
server.create('user', {name: 'Admin', roles: [role]});
await visit('/editor');
// NOTE: there were checks here for the title element having focus
// but they were very temperamental whilst running tests in the
// browser so they've been left out for now
expect(
currentURL(),
'url on initial visit'
).to.equal('/editor');
await triggerEvent('[data-test-editor-title-input]', 'blur');
expect(
find('[data-test-editor-title-input]').val(),
'title value after autosave'
).to.equal('(Untitled)');
expect(
currentURL(),
'url after autosave'
).to.equal('/editor/1');
});
it('saves post settings fields', async function () {
let post = server.create('post');
await visit(`/editor/${post.id}`);
// TODO: implement tests for other fields
await click('[data-test-psm-trigger]');
// excerpt has validation
await fillIn('[data-test-field="custom-excerpt"]', Array(302).join('a'));
await triggerEvent('[data-test-field="custom-excerpt"]', 'blur');
expect(
find('[data-test-error="custom-excerpt"]').text().trim(),
'excerpt too long error'
).to.match(/cannot be longer than 300/);
expect(
server.db.posts[0].custom_excerpt,
'saved excerpt after validation error'
).to.be.blank;
// changing custom excerpt auto-saves
await fillIn('[data-test-field="custom-excerpt"]', 'Testing excerpt');
await triggerEvent('[data-test-field="custom-excerpt"]', 'blur');
expect(
server.db.posts[0].custom_excerpt,
'saved excerpt'
).to.equal('Testing excerpt');
// -------
// open code injection subview
await click('[data-test-button="codeinjection"]');
// header injection has validation
let headerCM = find('[data-test-field="codeinjection-head"] .CodeMirror')[0].CodeMirror;
await headerCM.setValue(Array(65540).join('a'));
await triggerEvent(headerCM.getInputField(), 'blur');
expect(
find('[data-test-error="codeinjection-head"]').text().trim(),
'header injection too long error'
).to.match(/cannot be longer than 65535/);
expect(
server.db.posts[0].codeinjection_head,
'saved header injection after validation error'
).to.be.blank;
// changing header injection auto-saves
await headerCM.setValue('<script src="http://example.com/inject-head.js"></script>');
await triggerEvent(headerCM.getInputField(), 'blur');
expect(
server.db.posts[0].codeinjection_head,
'saved header injection'
).to.equal('<script src="http://example.com/inject-head.js"></script>');
// footer injection has validation
let footerCM = find('[data-test-field="codeinjection-foot"] .CodeMirror')[0].CodeMirror;
await footerCM.setValue(Array(65540).join('a'));
await triggerEvent(footerCM.getInputField(), 'blur');
expect(
find('[data-test-error="codeinjection-foot"]').text().trim(),
'footer injection too long error'
).to.match(/cannot be longer than 65535/);
expect(
server.db.posts[0].codeinjection_foot,
'saved footer injection after validation error'
).to.be.blank;
// changing footer injection auto-saves
await footerCM.setValue('<script src="http://example.com/inject-foot.js"></script>');
await triggerEvent(footerCM.getInputField(), 'blur');
expect(
server.db.posts[0].codeinjection_foot,
'saved footer injection'
).to.equal('<script src="http://example.com/inject-foot.js"></script>');
// closing subview switches back to main PSM view
await click('[data-test-button="close-psm-subview"]');
expect(
find('[data-test-field="codeinjection-head"]').length,
'header injection not present after closing subview'
).to.equal(0);
// -------
// open twitter data subview
await click('[data-test-button="twitter-data"]');
// twitter title has validation
await fillIn('[data-test-field="twitter-title"]', Array(302).join('a'));
await triggerEvent('[data-test-field="twitter-title"]', 'blur');
expect(
find('[data-test-error="twitter-title"]').text().trim(),
'twitter title too long error'
).to.match(/cannot be longer than 300/);
expect(
server.db.posts[0].twitter_title,
'saved twitter title after validation error'
).to.be.blank;
// changing twitter title auto-saves
// twitter title has validation
await fillIn('[data-test-field="twitter-title"]', 'Test Twitter Title');
await triggerEvent('[data-test-field="twitter-title"]', 'blur');
expect(
server.db.posts[0].twitter_title,
'saved twitter title'
).to.equal('Test Twitter Title');
// twitter description has validation
await fillIn('[data-test-field="twitter-description"]', Array(505).join('a'));
await triggerEvent('[data-test-field="twitter-description"]', 'blur');
expect(
find('[data-test-error="twitter-description"]').text().trim(),
'twitter description too long error'
).to.match(/cannot be longer than 500/);
expect(
server.db.posts[0].twitter_description,
'saved twitter description after validation error'
).to.be.blank;
// changing twitter description auto-saves
// twitter description has validation
await fillIn('[data-test-field="twitter-description"]', 'Test Twitter Description');
await triggerEvent('[data-test-field="twitter-description"]', 'blur');
expect(
server.db.posts[0].twitter_description,
'saved twitter description'
).to.equal('Test Twitter Description');
// closing subview switches back to main PSM view
await click('[data-test-button="close-psm-subview"]');
expect(
find('[data-test-field="twitter-title"]').length,
'twitter title not present after closing subview'
).to.equal(0);
// -------
// open facebook data subview
await click('[data-test-button="facebook-data"]');
// facebook title has validation
await fillIn('[data-test-field="og-title"]', Array(302).join('a'));
await triggerEvent('[data-test-field="og-title"]', 'blur');
expect(
find('[data-test-error="og-title"]').text().trim(),
'facebook title too long error'
).to.match(/cannot be longer than 300/);
expect(
server.db.posts[0].og_title,
'saved facebook title after validation error'
).to.be.blank;
// changing facebook title auto-saves
// facebook title has validation
await fillIn('[data-test-field="og-title"]', 'Test Facebook Title');
await triggerEvent('[data-test-field="og-title"]', 'blur');
expect(
server.db.posts[0].og_title,
'saved facebook title'
).to.equal('Test Facebook Title');
// facebook description has validation
await fillIn('[data-test-field="og-description"]', Array(505).join('a'));
await triggerEvent('[data-test-field="og-description"]', 'blur');
expect(
find('[data-test-error="og-description"]').text().trim(),
'facebook description too long error'
).to.match(/cannot be longer than 500/);
expect(
server.db.posts[0].og_description,
'saved facebook description after validation error'
).to.be.blank;
// changing facebook description auto-saves
// facebook description has validation
await fillIn('[data-test-field="og-description"]', 'Test Facebook Description');
await triggerEvent('[data-test-field="og-description"]', 'blur');
expect(
server.db.posts[0].og_description,
'saved facebook description'
).to.equal('Test Facebook Description');
// closing subview switches back to main PSM view
await click('[data-test-button="close-psm-subview"]');
expect(
find('[data-test-field="og-title"]').length,
'facebook title not present after closing subview'
).to.equal(0);
});
it('has unsplash icon when server doesn\'t return unsplash settings key', async function () {
server.createList('post', 1);
await visit('/editor/1');
expect(
find('.editor-toolbar .fa-camera'),
'unsplash toolbar button'
).to.exist;
});
});
});