Turn your audience into a business. Publishing, memberships, subscriptions and newsletters.

bloggingcmsemberghosthacktoberfestheadless-cmsjamstackjavascriptjournalismnodejspublishingweb-application

Simon Backx 6ab29c14e4 Fixed OfferCreatedEvent being dispatched before the transaction has been committed (#391) ... refs https://github.com/TryGhost/Ghost/pull/14488 **Bug:** When creating a new offer, sometimes no discount object is created in Stripe (only in MySQL). This issue causes tests to fail in https://github.com/TryGhost/Ghost/pull/14488 **Cause:** When creating an offer with the OffersAPI, we create a new transaction to save the offer and check for uniqueness. Inside that transaction, we dispatch an OfferCreatedEvent event before the transaction is committed to the database. When listening for this event in the `members-payments` package, we create the discount object in Stripe and save the stripe_coupon_id to the newly created offer. But because (in most cases) the offer doesn't yet exist in the database, that listener fails without warning and exits early. **Solution:** Creating a discount in Stripe should only happen after we succesfully committed the offer to the database. If we don't wait for the commit, the offer often (by chance) won't exist in the database, so the coupon won't be created inside Stripe. The solution is to wait for the transaction to succeed/be committed before dispatching the event.		2022-04-19 12:47:03 +02:00
ghost	Fixed OfferCreatedEvent being dispatched before the transaction has been committed (#391)	2022-04-19 12:47:03 +02:00