mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-25 11:55:03 +03:00
3a0e0831ec
Based on a discussion in slack we want to make all metadata properties optional, with the exception of the title, which will default to the host of the source URL if it's missing. This is so that we can accept as many webmentions as possible and convert them into Mentions. If we were to have strictly validation, we'd end up having to drop webmentions that didn't match our criteria, and lose important data. Giving the title a default allows us to provide a consistent UI experience too.
110 lines
3.8 KiB
JavaScript
110 lines
3.8 KiB
JavaScript
const assert = require('assert');
|
|
const ObjectID = require('bson-objectid');
|
|
const Mention = require('../lib/Mention');
|
|
|
|
const validInput = {
|
|
source: 'https://source.com',
|
|
target: 'https://target.com',
|
|
sourceTitle: 'Title!',
|
|
sourceExcerpt: 'Excerpt!'
|
|
};
|
|
|
|
describe('Mention', function () {
|
|
describe('toJSON', function () {
|
|
it('Returns a object with the expected properties', async function () {
|
|
const mention = await Mention.create(validInput);
|
|
const actual = Object.keys(mention.toJSON());
|
|
const expected = [
|
|
'id',
|
|
'source',
|
|
'target',
|
|
'timestamp',
|
|
'payload',
|
|
'resourceId',
|
|
'sourceTitle',
|
|
'sourceSiteTitle',
|
|
'sourceAuthor',
|
|
'sourceExcerpt',
|
|
'sourceFavicon',
|
|
'sourceFeaturedImage'
|
|
];
|
|
assert.deepEqual(actual, expected);
|
|
});
|
|
});
|
|
|
|
describe('create', function () {
|
|
it('Will error with invalid inputs', async function () {
|
|
const invalidInputs = [
|
|
{id: 'Not valid ID'},
|
|
{id: 123},
|
|
{source: 'Not a valid source'},
|
|
{target: 'Not a valid target'},
|
|
{timestamp: 'Not a valid timestamp'},
|
|
{resourceId: 'Invalid resourceId'},
|
|
{sourceTitle: 123},
|
|
{sourceExcerpt: 123},
|
|
{sourceFavicon: 'Invalid source favicon'},
|
|
{sourceFeaturedImage: 'Invalid source featured image'}
|
|
];
|
|
|
|
for (const invalidInput of invalidInputs) {
|
|
let errored = false;
|
|
try {
|
|
await Mention.create({
|
|
...validInput,
|
|
...invalidInput
|
|
});
|
|
} catch (err) {
|
|
errored = true;
|
|
} finally {
|
|
if (!errored) {
|
|
assert.fail(`Should have errored with invalid input ${JSON.stringify(invalidInput)}`);
|
|
}
|
|
}
|
|
}
|
|
});
|
|
|
|
it('Will not error with valid inputs', async function () {
|
|
const validInputs = [
|
|
{id: new ObjectID()},
|
|
{source: new URL('https://source.com/')},
|
|
{target: new URL('https://target.com/')},
|
|
{timestamp: new Date()},
|
|
{timestamp: '2023-01-01T00:00:00Z'},
|
|
{payload: {extra: 'shit'}},
|
|
{resourceId: new ObjectID()},
|
|
{sourceFavicon: 'https://source.com/favicon.ico'},
|
|
{sourceFavicon: new URL('https://source.com/favicon.ico')},
|
|
{sourceFeaturedImage: 'https://source.com/assets/image.jpg'},
|
|
{sourceFeaturedImage: new URL('https://source.com/assets/image.jpg')}
|
|
];
|
|
|
|
for (const localValidInput of validInputs) {
|
|
await Mention.create({
|
|
...validInput,
|
|
...localValidInput
|
|
});
|
|
}
|
|
});
|
|
|
|
it('Will trim titles which are too long', async function () {
|
|
const mention = await Mention.create({
|
|
...validInput,
|
|
sourceTitle: Array.from({length: 3000}).join('A')
|
|
});
|
|
|
|
assert(mention.sourceTitle.length === 2000);
|
|
});
|
|
|
|
it('Will default the title to the host of the source URL if missing', async function () {
|
|
const mention = await Mention.create({
|
|
...validInput,
|
|
sourceTitle: null
|
|
});
|
|
|
|
assert(mention.sourceTitle);
|
|
assert(mention.sourceTitle === 'source.com');
|
|
});
|
|
});
|
|
});
|