Ghost/core/test/unit/services/slack_spec.js
Katharina Irrgang b392d1925a
Dynamic Routing Beta (#9596)
refs #9601

### Dynamic Routing

This is the beta version of dynamic routing. 

- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation 
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
  - yaml file + validation
  - routing + routers
  - url service
  - sitemaps
  - url access
- deeper implementation of yaml validations
  - e.g. hard require slashes
- ensure routing hierarchy/order
  - e.g. you enable the subscriber app
  - you have a custom static page, which lives under the same slug /subscribe
  - static pages are stronger than apps
  - e.g. the first collection owns the post it has filtered
  - a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
  - e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
  - and you change the permalink in the admin to dated permalink
  - the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
  - unmount without server restart, yey
- ensure we are backwards compatible
  - e.g. render home.hbs for collection index if collection route is /
  - ensure you can access your configured permalink from the settings table with {globals.permalink}

### Render 503 if url service did not finish

- return 503 if the url service has not finished generating the resource urls

### Rewrite sitemaps

- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
  - the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)

### Re-work usage of Url utility

- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
  - only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 19:02:20 +02:00

238 lines
8.1 KiB
JavaScript

var should = require('should'),
sinon = require('sinon'),
_ = require('lodash'),
nock = require('nock'),
rewire = require('rewire'),
url = require('url'),
testUtils = require('../../utils'),
configUtils = require('../../utils/configUtils'),
// Stuff we test
slack = rewire('../../../server/services/slack'),
common = require('../../../server/lib/common'),
urlService = require('../../../server/services/url'),
schema = require('../../../server/data/schema').checks,
settingsCache = require('../../../server/services/settings/cache'),
sandbox = sinon.sandbox.create(),
// Test data
slackObjNoUrl = [{url: ''}],
slackObjWithUrl = [{url: 'https://hooks.slack.com/services/a-b-c-d'}];
describe('Slack', function () {
var eventStub;
beforeEach(function () {
eventStub = sandbox.stub(common.events, 'on');
});
afterEach(function () {
sandbox.restore();
configUtils.restore();
});
it('listen() should initialise event correctly', function () {
slack.listen();
eventStub.calledTwice.should.be.true();
eventStub.firstCall.calledWith('post.published', slack.__get__('listener')).should.be.true();
eventStub.secondCall.calledWith('slack.test', slack.__get__('testPing')).should.be.true();
});
it('listener() calls ping() with toJSONified model', function () {
var testPost = _.clone(testUtils.DataGenerator.Content.posts[2]),
testModel = {
toJSON: function () {
return testPost;
}
},
pingStub = sandbox.stub(),
resetSlack = slack.__set__('ping', pingStub),
listener = slack.__get__('listener');
listener(testModel);
pingStub.calledOnce.should.be.true();
pingStub.calledWith(testPost).should.be.true();
// Reset slack ping method
resetSlack();
});
it('listener() does not call ping() when importing', function () {
var testPost = _.clone(testUtils.DataGenerator.Content.posts[2]),
testModel = {
toJSON: function () {
return testPost;
}
},
pingStub = sandbox.stub(),
resetSlack = slack.__set__('ping', pingStub),
listener = slack.__get__('listener');
listener(testModel, {importing: true});
pingStub.calledOnce.should.be.false();
// Reset slack ping method
resetSlack();
});
it('testPing() calls ping() with default message', function () {
var pingStub = sandbox.stub(),
resetSlack = slack.__set__('ping', pingStub),
testPing = slack.__get__('testPing');
testPing();
pingStub.calledOnce.should.be.true();
pingStub.calledWith(sinon.match.has('message')).should.be.true();
// Reset slack ping method
resetSlack();
});
describe('ping()', function () {
var isPostStub,
settingsCacheStub,
slackReset,
makeRequestStub,
ping = slack.__get__('ping');
beforeEach(function () {
isPostStub = sandbox.stub(schema, 'isPost');
sandbox.stub(urlService, 'getUrlByResourceId');
settingsCacheStub = sandbox.stub(settingsCache, 'get');
sandbox.spy(common.logging, 'error');
makeRequestStub = sandbox.stub();
slackReset = slack.__set__('request', makeRequestStub);
makeRequestStub.resolves();
configUtils.set('url', 'http://myblog.com');
});
afterEach(function () {
slackReset();
});
it('makes a request for a post if url is provided', function () {
var requestUrl, requestData;
const post = testUtils.DataGenerator.forKnex.createPost({slug: 'test'});
urlService.getUrlByResourceId.withArgs(post.id, {absolute: true}).returns('http://myblog.com/' + post.slug + '/');
isPostStub.returns(true);
settingsCacheStub.withArgs('slack').returns(slackObjWithUrl);
// execute code
ping(post);
// assertions
makeRequestStub.calledOnce.should.be.true();
isPostStub.calledOnce.should.be.true();
urlService.getUrlByResourceId.calledOnce.should.be.true();
settingsCacheStub.calledWith('slack').should.be.true();
requestUrl = makeRequestStub.firstCall.args[0];
requestData = JSON.parse(makeRequestStub.firstCall.args[1].body);
requestUrl.should.equal(slackObjWithUrl[0].url);
requestData.text.should.eql('http://myblog.com/test/');
requestData.icon_url.should.equal('http://myblog.com/favicon.ico');
requestData.username.should.equal('Ghost');
requestData.unfurl_links.should.equal(true);
});
it('makes a request for a message if url is provided', function () {
var requestUrl, requestData;
isPostStub.returns(false);
settingsCacheStub.withArgs('slack').returns(slackObjWithUrl);
configUtils.set('url', 'https://myblog.com');
// execute code
ping({message: 'Hi!'});
// assertions
makeRequestStub.calledOnce.should.be.true();
isPostStub.calledOnce.should.be.true();
urlService.getUrlByResourceId.called.should.be.false();
settingsCacheStub.calledWith('slack').should.be.true();
requestUrl = makeRequestStub.firstCall.args[0];
requestData = JSON.parse(makeRequestStub.firstCall.args[1].body);
requestUrl.should.equal(slackObjWithUrl[0].url);
requestData.text.should.eql('Hi!');
requestData.icon_url.should.equal('https://myblog.com/favicon.ico');
requestData.username.should.equal('Ghost');
requestData.unfurl_links.should.equal(true);
});
it('makes a request and errors', function (done) {
makeRequestStub.rejects();
settingsCacheStub.withArgs('slack').returns(slackObjWithUrl);
// execute code
ping({});
(function retry() {
if (common.logging.error.calledOnce) {
makeRequestStub.calledOnce.should.be.true();
return done();
}
setTimeout(retry, 50);
}());
});
it('does not make a request if post is a page', function () {
const post = testUtils.DataGenerator.forKnex.createPost({page: true});
isPostStub.returns(true);
settingsCacheStub.withArgs('slack').returns(slackObjWithUrl);
// execute code
ping(post);
// assertions
makeRequestStub.calledOnce.should.be.false();
isPostStub.calledOnce.should.be.true();
urlService.getUrlByResourceId.calledOnce.should.be.true();
settingsCacheStub.calledWith('slack').should.be.true();
});
it('does not send webhook for \'welcome\' post', function () {
const post = testUtils.DataGenerator.forKnex.createPost({slug: 'welcome'});
isPostStub.returns(true);
settingsCacheStub.withArgs('slack').returns(slackObjWithUrl);
// execute code
ping(post);
// assertions
makeRequestStub.calledOnce.should.be.false();
isPostStub.calledOnce.should.be.true();
urlService.getUrlByResourceId.calledOnce.should.be.true();
settingsCacheStub.calledWith('slack').should.be.true();
});
it('handles broken slack settings', function () {
const post = testUtils.DataGenerator.forKnex.createPost({slug: 'any'});
settingsCacheStub.withArgs('slack').returns();
// execute code
ping(post);
// assertions
makeRequestStub.calledOnce.should.be.false();
isPostStub.calledOnce.should.be.true();
urlService.getUrlByResourceId.called.should.be.false();
settingsCacheStub.calledWith('slack').should.be.true();
});
});
});