Ghost/ghost/admin/app
jbenezech b9dd9f066d
🐛 Fixed settings overriden when updated from multiple tabs (#15536)
closes: https://github.com/TryGhost/Ghost/issues/15470

- When multiple browser tabs are open, each manipulate a different copy of ember data model, changes to the model in one tab are not reflected in the model of the other tab.
- When updating some settings, all current settings were sent to the API.
- As a result, when updating two different categories of settings (navigation/code inspection) in different tabs, the second update was overriding the first one.
- From a user perspective, this is not a natural behaviour. Only settings visible on-screen when clicking save should be modified.

Co-authored-by: Kevin Ansfield <kevin@lookingsideways.co.uk>
2022-10-12 14:03:54 +01:00
..
adapters 🐛 Fixed settings overriden when updated from multiple tabs (#15536) 2022-10-12 14:03:54 +01:00
authenticators Made session.user a synchronous property rather than a promise 2021-07-08 14:54:31 +01:00
components Added post sentiment (#15592) 2022-10-11 17:52:14 +02:00
controllers 🐛 Fixed settings overriden when updated from multiple tabs (#15536) 2022-10-12 14:03:54 +01:00
errors Improved validation process for members CSV import 2020-07-07 00:28:30 +12:00
helpers Removed need for .get() with config service 2022-10-07 16:14:57 +01:00
initializers Resolved ember-simple-auth deprecations 2022-01-22 00:30:56 +00:00
mixins Updated ValidationEngine to support bare native class models (#15567) 2022-10-07 20:13:42 +01:00
models Added post sentiment (#15592) 2022-10-11 17:52:14 +02:00
modifiers Migrated staff user screen to Ember Octane patterns (#15532) 2022-10-05 12:05:31 +01:00
routes Refactored posts and pages controllers to Octane patterns 2022-10-07 18:39:34 +01:00
serializers 🐛 Fixed settings overriden when updated from multiple tabs (#15536) 2022-10-12 14:03:54 +01:00
services Added fix links in newsletter feature flag 2022-10-11 17:08:41 +02:00
session-stores Migrated session-store to native class syntax 2022-02-02 18:41:16 +00:00
styles Fixed cursor for attribution table header 2022-10-12 10:51:13 +05:30
templates Added fix links in newsletter feature flag 2022-10-11 17:08:41 +02:00
transforms Dropped ember-cli-moment-shim dependency 2022-09-24 13:28:23 +02:00
transitions Fixed autofocus not working on modal inputs 2018-06-04 17:48:57 +01:00
utils Removed need for .get() with config service 2022-10-07 16:14:57 +01:00
validators Updated ValidationEngine to support bare native class models (#15567) 2022-10-07 20:13:42 +01:00
app.js Dropped ember-cli-moment-shim dependency 2022-09-24 13:28:23 +02:00
index.html Updated loading animation 2022-09-16 13:44:58 +02:00
README.md Renamed "client" references to "admin" 2022-05-17 09:09:14 +01:00
router.js Added Ghost Explore in Ghost as iframe app behind feature flag (#15495) 2022-10-07 14:32:54 +01:00
transitions.js Removed tour feature 2021-03-02 14:29:26 +00:00

Ghost Admin App

Ember.js application used as a client-side admin for the Ghost blogging platform. This readme is a work in progress guide aimed at explaining the specific nuances of the Ghost Ember app to contributors whose main focus is on this side of things.

CSS

We use pure CSS, which is pre-processed for backwards compatibility by Myth. We do not follow any strict CSS framework, however our general style is pretty similar to BEM.

Styles are primarily broken up into 4 main categories:

  • Patterns - are base level visual styles for HTML elements (eg. Buttons)
  • Components - are groups of patterns used to create a UI component (eg. Modals)
  • Layouts - are groups of components used to create application screens (eg. Settings)

All of these separate files are subsequently imported and compiled in app.css.

Front End Standards

  • 4 spaces for HTML & CSS indentation. Never tabs.
  • Double quotes only, never single quotes.
  • Use tags and elements appropriate for an HTML5 doctype (including self-closing tags)
  • Adhere to the Recess CSS property order.
  • Always a space after a property's colon (.e.g, display: block; and not display:block;).
  • End all lines with a semi-colon.
  • For multiple, comma-separated selectors, place each selector on its own line.
  • Use js- prefixed classes for JavaScript hooks into the DOM, and never use these in CSS as per Slightly Obtrusive JavaSript
  • Avoid over-nesting CSS. Never nest more than 3 levels deep.
  • Use comments to explain "why" not "what" (Good: This requires a z-index in order to appear above mobile navigation. Bad: This is a thing which is always on top!)