TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-30 21:40:39 +03:00
Code Issues Projects Releases Wiki Activity
71d830e1c9
Ghost/ghost/admin/app
History
Chris Raible 71d830e1c9
Removed cache buster from client extensions script (#20668) 
ref
https://linear.app/tryghost/issue/PA-71/remove-cache-bust-from-projs-in-admin
ref
15ed2eb245

- This cache buster was added in March to mitigate a client side error in pro.js,
to effectively force browsers to redownload the fixed version of the file.
- It's not needed anymore, as the error has been fixed for a few months
now, so we can safely remove it.
2024-07-25 15:40:12 -07:00
..
adapters Fixed infinite save loop due to missing post_revisions include on saves (#18597) 2023-10-12 19:16:45 +00:00
authenticators Made session.user a synchronous property rather than a promise 2021-07-08 14:54:31 +01:00
components 🐛 Fixed broken link to subscription settings (#20651) 2024-07-24 09:28:32 +00:00
controllers Removed cache buster from client extensions script (#20668) 2024-07-25 15:40:12 -07:00
decorators Fixed hosting management screen not loading after sign-in process (#15763) 2022-11-03 11:14:36 +00:00
errors Improved validation process for members CSV import 2020-07-07 00:28:30 +12:00
helpers 🎨 Added 'Changed email address' event to Member Activity (#20493) 2024-07-01 15:33:33 +00:00
initializers Resolved ember-simple-auth deprecations 2022-01-22 00:30:56 +00:00
instance-initializers Fixed hosting management screen not loading after sign-in process (#15763) 2022-11-03 11:14:36 +00:00
mixins Added collections CRUD UI 2023-05-23 17:26:47 +07:00
models Renamed subtitle to excerpt (#20334) 2024-06-05 17:59:30 +01:00
modifiers Fixed onboarding checklist video logo autoplay (#19967) 2024-04-02 13:55:22 +01:00
routes Fixed regex to ignore AbortError in Sentry (#20639) 2024-07-22 07:55:37 +00:00
serializers Added custom excerpt to post revisions (#20323) 2024-06-05 14:47:33 +01:00
services Cleaned up "Recommendations" GA feature flag (#20580) 2024-07-10 12:24:27 +00:00
session-stores Migrated session-store to native class syntax 2022-02-02 18:41:16 +00:00
styles Improved text-wrapping for Resource headers (#20590) 2024-07-11 09:50:06 +00:00
templates Removed cache buster from client extensions script (#20668) 2024-07-25 15:40:12 -07:00
transforms Dropped ember-cli-moment-shim dependency 2022-09-24 13:28:23 +02:00
transitions Fixed autofocus not working on modal inputs 2018-06-04 17:48:57 +01:00
utils Fixed regex to ignore AbortError in Sentry (#20639) 2024-07-22 07:55:37 +00:00
validators Renamed subtitle to excerpt (#20334) 2024-06-05 17:59:30 +01:00
app.js Dropped ember-cli-moment-shim dependency 2022-09-24 13:28:23 +02:00
index.html Fixed loading animation for Safari 2022-10-17 10:11:07 +02:00
README.md Fixed typos (#18648) 2023-10-31 15:21:44 +00:00
router.js Cleaned up websockets experiment (#20547) 2024-07-04 16:08:06 +00:00
transitions.js Removed tour feature 2021-03-02 14:29:26 +00:00

README.md

Ghost Admin App

Ember.js application used as a client-side admin for the Ghost blogging platform. This readme is a work in progress guide aimed at explaining the specific nuances of the Ghost Ember app to contributors whose main focus is on this side of things.

CSS

We use pure CSS, which is pre-processed for backwards compatibility by Myth. We do not follow any strict CSS framework, however our general style is pretty similar to BEM.

Styles are primarily broken up into 4 main categories:

  • Patterns - are base level visual styles for HTML elements (eg. Buttons)
  • Components - are groups of patterns used to create a UI component (eg. Modals)
  • Layouts - are groups of components used to create application screens (eg. Settings)

All of these separate files are subsequently imported and compiled in app.css.

Front End Standards

  • 4 spaces for HTML & CSS indentation. Never tabs.
  • Double quotes only, never single quotes.
  • Use tags and elements appropriate for an HTML5 doctype (including self-closing tags)
  • Adhere to the Recess CSS property order.
  • Always a space after a property's colon (.e.g, display: block; and not display:block;).
  • End all lines with a semi-colon.
  • For multiple, comma-separated selectors, place each selector on its own line.
  • Use js- prefixed classes for JavaScript hooks into the DOM, and never use these in CSS as per Slightly Obtrusive JavaScript
  • Avoid over-nesting CSS. Never nest more than 3 levels deep.
  • Use comments to explain "why" not "what" (Good: This requires a z-index in order to appear above mobile navigation. Bad: This is a thing which is always on top!)