mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-22 18:31:57 +03:00
7419ff2c4f
refs https://github.com/TryGhost/Toolbox/issues/292 - There was a typo in the variable name - req.originalURL is NOT does not exist on express' reqest object - Added tests to avoid similar mistake again
49 lines
1.9 KiB
JavaScript
49 lines
1.9 KiB
JavaScript
const assert = require('assert');
|
|
const sinon = require('sinon');
|
|
const errors = require('@tryghost/errors');
|
|
|
|
const versionMismatchMW = require('../index');
|
|
|
|
describe('mw-api-version-mismatch', function () {
|
|
it('Does call handle mismatch when a generic RequestNotAcceptableError is used', function (done) {
|
|
const APIVersionCompatibilityService = {
|
|
handleMismatch: sinon.stub().resolves()
|
|
};
|
|
const req = {
|
|
originalUrl: '/api/admin/posts/1',
|
|
headers: {
|
|
'accept-version': 'v3.28',
|
|
'user-agent': 'Zapier/2.1 GhostAdminSDK/3.28'
|
|
}
|
|
};
|
|
const res = {
|
|
locals: {
|
|
safeVersion: '4.46'
|
|
}
|
|
};
|
|
|
|
versionMismatchMW(APIVersionCompatibilityService)(new errors.RequestNotAcceptableError({
|
|
code: 'UPDATE_CLIENT'
|
|
}), req, res, () => {
|
|
assert.equal(APIVersionCompatibilityService.handleMismatch.called, true);
|
|
assert.equal(APIVersionCompatibilityService.handleMismatch.args[0][0].acceptVersion, 'v3.28');
|
|
assert.equal(APIVersionCompatibilityService.handleMismatch.args[0][0].contentVersion, 'v4.46');
|
|
assert.equal(APIVersionCompatibilityService.handleMismatch.args[0][0].requestURL, '/api/admin/posts/1');
|
|
assert.equal(APIVersionCompatibilityService.handleMismatch.args[0][0].userAgent, 'Zapier/2.1 GhostAdminSDK/3.28');
|
|
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('Does NOT call handle mismatch when a generic RequestNotAcceptableError is used', function (done) {
|
|
const APIVersionCompatibilityService = {
|
|
handleMismatch: sinon.stub().resolves()
|
|
};
|
|
|
|
versionMismatchMW(APIVersionCompatibilityService)(new errors.RequestNotAcceptableError(), {}, {}, () => {
|
|
assert.equal(APIVersionCompatibilityService.handleMismatch.called, false);
|
|
done();
|
|
});
|
|
});
|
|
});
|