mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-11 09:53:32 +03:00
00cf043e15
no issue - reported in the forum: https://forum.ghost.org/t/publishing-with-a-single-post-request-to-posts/1648 - the defaults are defined in two places 1. on the schema level (defaults for the database) 2. on the ORM (model layer) - the defaults on the db layer are set correctly when inserting a new resource - but if we don't apply all defaults on the model layer, it will happen that model events are emitted without the correct defaults - see comment in code base - it's caused by the fact that knex only returns the inserted resource id (probably caused by the fact knex has to support x databases) - components/modules are listening on model events and expect: 1. a complete set of attributes 2. a complete set of defaults 3. sanitized values e.g. bool, date - this commit fixes: 1. added missing defaults for user & post model 2. sanitize booleans (0|1 => false|true) 3. added tests to ensure this works as expected 4. clarfies the usage of `defaults` Regarding https://forum.ghost.org/t/publishing-with-a-single-post-request-to-posts/1648: - the post event was emitted with the following values {page: undefined, featured: undefined} - the urlservice receives this event and won't match the resource against collection filters correctly - NOTE: the post data in the db were correct |
||
|---|---|---|
| .. | ||
| base | ||
| plugins | ||
| relations | ||
| accesstoken.js | ||
| app-field.js | ||
| app-setting.js | ||
| app.js | ||
| client-trusted-domain.js | ||
| client.js | ||
| index.js | ||
| invite.js | ||
| permission.js | ||
| post.js | ||
| refreshtoken.js | ||
| role.js | ||
| settings.js | ||
| subscriber.js | ||
| tag.js | ||
| user.js | ||
| webhook.js | ||