mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-11 09:53:32 +03:00
00cf043e15
no issue - reported in the forum: https://forum.ghost.org/t/publishing-with-a-single-post-request-to-posts/1648 - the defaults are defined in two places 1. on the schema level (defaults for the database) 2. on the ORM (model layer) - the defaults on the db layer are set correctly when inserting a new resource - but if we don't apply all defaults on the model layer, it will happen that model events are emitted without the correct defaults - see comment in code base - it's caused by the fact that knex only returns the inserted resource id (probably caused by the fact knex has to support x databases) - components/modules are listening on model events and expect: 1. a complete set of attributes 2. a complete set of defaults 3. sanitized values e.g. bool, date - this commit fixes: 1. added missing defaults for user & post model 2. sanitize booleans (0|1 => false|true) 3. added tests to ensure this works as expected 4. clarfies the usage of `defaults` Regarding https://forum.ghost.org/t/publishing-with-a-single-post-request-to-posts/1648: - the post event was emitted with the following values {page: undefined, featured: undefined} - the urlservice receives this event and won't match the resource against collection filters correctly - NOTE: the post data in the db were correct
800 lines
32 KiB
JavaScript
800 lines
32 KiB
JavaScript
// # Post Model
|
|
var _ = require('lodash'),
|
|
uuid = require('uuid'),
|
|
moment = require('moment'),
|
|
Promise = require('bluebird'),
|
|
ObjectId = require('bson-objectid'),
|
|
sequence = require('../lib/promise/sequence'),
|
|
common = require('../lib/common'),
|
|
htmlToText = require('html-to-text'),
|
|
ghostBookshelf = require('./base'),
|
|
config = require('../config'),
|
|
labs = require('../services/labs'),
|
|
converters = require('../lib/mobiledoc/converters'),
|
|
urlService = require('../services/url'),
|
|
relations = require('./relations'),
|
|
Post,
|
|
Posts;
|
|
|
|
Post = ghostBookshelf.Model.extend({
|
|
|
|
tableName: 'posts',
|
|
|
|
/**
|
|
* @NOTE
|
|
*
|
|
* We define the defaults on the schema (db) and model level.
|
|
*
|
|
* Why?
|
|
* - when you insert a resource, Knex does only return the id of the created resource
|
|
* - see https://knexjs.org/#Builder-insert
|
|
* - that means `defaultTo` is a pure database configuration (!)
|
|
* - Bookshelf just returns the model values which you have asked Bookshelf to insert
|
|
* - it can't return the `defaultTo` value from the schema/db level
|
|
* - but the db defaults defined in the schema are saved in the database correctly
|
|
* - `models.Post.add` always does to operations:
|
|
* 1. add
|
|
* 2. fetch (this ensures we fetch the whole resource from the database)
|
|
* - that means we have to apply the defaults on the model layer to ensure a complete field set
|
|
* 1. any connected logic in our model hooks e.g. beforeSave
|
|
* 2. model events e.g. "post.published" are using the inserted resource, not the fetched resource
|
|
*/
|
|
defaults: function defaults() {
|
|
return {
|
|
uuid: uuid.v4(),
|
|
status: 'draft',
|
|
featured: false,
|
|
page: false,
|
|
visibility: 'public'
|
|
};
|
|
},
|
|
|
|
relationships: ['tags', 'authors'],
|
|
|
|
// NOTE: look up object, not super nice, but was easy to implement
|
|
relationshipBelongsTo: {
|
|
tags: 'tags',
|
|
authors: 'users'
|
|
},
|
|
|
|
/**
|
|
* The base model keeps only the columns, which are defined in the schema.
|
|
* We have to add the relations on top, otherwise bookshelf-relations
|
|
* has no access to the nested relations, which should be updated.
|
|
*/
|
|
permittedAttributes: function permittedAttributes() {
|
|
let filteredKeys = ghostBookshelf.Model.prototype.permittedAttributes.apply(this, arguments);
|
|
|
|
this.relationships.forEach((key) => {
|
|
filteredKeys.push(key);
|
|
});
|
|
|
|
return filteredKeys;
|
|
},
|
|
|
|
emitChange: function emitChange(event, options) {
|
|
let eventToTrigger;
|
|
|
|
var resourceType = this.get('page') ? 'page' : 'post';
|
|
|
|
if (options.useUpdatedAttribute) {
|
|
resourceType = this.updated('page') ? 'page' : 'post';
|
|
} else if (options.usePreviousAttribute) {
|
|
resourceType = this.previous('page') ? 'page' : 'post';
|
|
}
|
|
|
|
eventToTrigger = resourceType + '.' + event;
|
|
|
|
ghostBookshelf.Model.prototype.emitChange.bind(this)(this, eventToTrigger, options);
|
|
},
|
|
|
|
/**
|
|
* We update the tags after the Post was inserted.
|
|
* We update the tags before the Post was updated, see `onSaving` event.
|
|
* `onCreated` is called before `onSaved`.
|
|
*
|
|
* `onSaved` is the last event in the line - triggered for updating or inserting data.
|
|
* bookshelf-relations listens on `created` + `updated`.
|
|
* We ensure that we are catching the event after bookshelf relations.
|
|
*/
|
|
onSaved: function onSaved(model, response, options) {
|
|
if (options.method !== 'insert') {
|
|
return;
|
|
}
|
|
|
|
var status = model.get('status');
|
|
|
|
model.emitChange('added', options);
|
|
|
|
if (['published', 'scheduled'].indexOf(status) !== -1) {
|
|
model.emitChange(status, options);
|
|
}
|
|
},
|
|
|
|
onUpdated: function onUpdated(model, attrs, options) {
|
|
model.statusChanging = model.get('status') !== model.updated('status');
|
|
model.isPublished = model.get('status') === 'published';
|
|
model.isScheduled = model.get('status') === 'scheduled';
|
|
model.wasPublished = model.updated('status') === 'published';
|
|
model.wasScheduled = model.updated('status') === 'scheduled';
|
|
model.resourceTypeChanging = model.get('page') !== model.updated('page');
|
|
model.publishedAtHasChanged = model.hasDateChanged('published_at');
|
|
model.needsReschedule = model.publishedAtHasChanged && model.isScheduled;
|
|
|
|
// Handle added and deleted for post -> page or page -> post
|
|
if (model.resourceTypeChanging) {
|
|
if (model.wasPublished) {
|
|
model.emitChange('unpublished', Object.assign({useUpdatedAttribute: true}, options));
|
|
}
|
|
|
|
if (model.wasScheduled) {
|
|
model.emitChange('unscheduled', Object.assign({useUpdatedAttribute: true}, options));
|
|
}
|
|
|
|
model.emitChange('deleted', Object.assign({useUpdatedAttribute: true}, options));
|
|
model.emitChange('added', options);
|
|
|
|
if (model.isPublished) {
|
|
model.emitChange('published', options);
|
|
}
|
|
|
|
if (model.isScheduled) {
|
|
model.emitChange('scheduled', options);
|
|
}
|
|
} else {
|
|
if (model.statusChanging) {
|
|
// CASE: was published before and is now e.q. draft or scheduled
|
|
if (model.wasPublished) {
|
|
model.emitChange('unpublished', options);
|
|
}
|
|
|
|
// CASE: was draft or scheduled before and is now e.q. published
|
|
if (model.isPublished) {
|
|
model.emitChange('published', options);
|
|
}
|
|
|
|
// CASE: was draft or published before and is now e.q. scheduled
|
|
if (model.isScheduled) {
|
|
model.emitChange('scheduled', options);
|
|
}
|
|
|
|
// CASE: from scheduled to something
|
|
if (model.wasScheduled && !model.isScheduled && !model.isPublished) {
|
|
model.emitChange('unscheduled', options);
|
|
}
|
|
} else {
|
|
if (model.isPublished) {
|
|
model.emitChange('published.edited', options);
|
|
}
|
|
|
|
if (model.needsReschedule) {
|
|
model.emitChange('rescheduled', options);
|
|
}
|
|
}
|
|
|
|
// Fire edited if this wasn't a change between resourceType
|
|
model.emitChange('edited', options);
|
|
}
|
|
},
|
|
|
|
onDestroyed: function onDestroyed(model, options) {
|
|
if (model.previous('status') === 'published') {
|
|
model.emitChange('unpublished', Object.assign({usePreviousAttribute: true}, options));
|
|
}
|
|
|
|
model.emitChange('deleted', Object.assign({usePreviousAttribute: true}, options));
|
|
},
|
|
|
|
onSaving: function onSaving(model, attr, options) {
|
|
options = options || {};
|
|
|
|
var self = this,
|
|
title,
|
|
i,
|
|
// Variables to make the slug checking more readable
|
|
newTitle = this.get('title'),
|
|
newStatus = this.get('status'),
|
|
olderStatus = this.previous('status'),
|
|
prevTitle = this.previous('title'),
|
|
prevSlug = this.previous('slug'),
|
|
publishedAt = this.get('published_at'),
|
|
publishedAtHasChanged = this.hasDateChanged('published_at', {beforeWrite: true}),
|
|
mobiledoc = JSON.parse(this.get('mobiledoc') || null),
|
|
generatedFields = ['html', 'plaintext'],
|
|
tagsToSave,
|
|
ops = [];
|
|
|
|
// CASE: disallow published -> scheduled
|
|
// @TODO: remove when we have versioning based on updated_at
|
|
if (newStatus !== olderStatus && newStatus === 'scheduled' && olderStatus === 'published') {
|
|
return Promise.reject(new common.errors.ValidationError({
|
|
message: common.i18n.t('errors.models.post.isAlreadyPublished', {key: 'status'})
|
|
}));
|
|
}
|
|
|
|
// CASE: both page and post can get scheduled
|
|
if (newStatus === 'scheduled') {
|
|
if (!publishedAt) {
|
|
return Promise.reject(new common.errors.ValidationError({
|
|
message: common.i18n.t('errors.models.post.valueCannotBeBlank', {key: 'published_at'})
|
|
}));
|
|
} else if (!moment(publishedAt).isValid()) {
|
|
return Promise.reject(new common.errors.ValidationError({
|
|
message: common.i18n.t('errors.models.post.valueCannotBeBlank', {key: 'published_at'})
|
|
}));
|
|
// CASE: to schedule/reschedule a post, a minimum diff of x minutes is needed (default configured is 2minutes)
|
|
} else if (
|
|
publishedAtHasChanged &&
|
|
moment(publishedAt).isBefore(moment().add(config.get('times').cannotScheduleAPostBeforeInMinutes, 'minutes')) &&
|
|
!options.importing
|
|
) {
|
|
return Promise.reject(new common.errors.ValidationError({
|
|
message: common.i18n.t('errors.models.post.expectedPublishedAtInFuture', {
|
|
cannotScheduleAPostBeforeInMinutes: config.get('times').cannotScheduleAPostBeforeInMinutes
|
|
})
|
|
}));
|
|
}
|
|
}
|
|
|
|
// CASE: detect lowercase/uppercase tag slugs
|
|
if (!_.isUndefined(this.get('tags')) && !_.isNull(this.get('tags'))) {
|
|
tagsToSave = [];
|
|
|
|
// and deduplicate upper/lowercase tags
|
|
_.each(this.get('tags'), function each(item) {
|
|
for (i = 0; i < tagsToSave.length; i = i + 1) {
|
|
if (tagsToSave[i].name && item.name && tagsToSave[i].name.toLocaleLowerCase() === item.name.toLocaleLowerCase()) {
|
|
return;
|
|
}
|
|
}
|
|
|
|
tagsToSave.push(item);
|
|
});
|
|
|
|
this.set('tags', tagsToSave);
|
|
}
|
|
|
|
ghostBookshelf.Model.prototype.onSaving.call(this, model, attr, options);
|
|
|
|
// do not allow generated fields to be overridden via the API
|
|
generatedFields.forEach((field) => {
|
|
if (this.hasChanged(field)) {
|
|
this.set(field, this.previous(field));
|
|
}
|
|
});
|
|
|
|
// render mobiledoc to HTML. Switch render version if Koenig is enabled
|
|
// or has been edited with Koenig and is no longer compatible with the
|
|
// Ghost 1.0 markdown-only renderer
|
|
// TODO: re-render all content and remove the version toggle for Ghost 2.0
|
|
if (mobiledoc) {
|
|
let version = 1;
|
|
let koenigEnabled = labs.isSet('koenigEditor') === true;
|
|
|
|
let mobiledocIsCompatibleWithV1 = function mobiledocIsCompatibleWithV1(doc) {
|
|
if (doc
|
|
&& doc.markups.length === 0
|
|
&& doc.cards.length === 1
|
|
&& doc.cards[0][0].match(/(?:card-)?markdown/)
|
|
&& doc.sections.length === 1
|
|
&& doc.sections[0].length === 2
|
|
&& doc.sections[0][0] === 10
|
|
&& doc.sections[0][1] === 0
|
|
) {
|
|
return true;
|
|
}
|
|
|
|
return false;
|
|
};
|
|
|
|
if (koenigEnabled || !mobiledocIsCompatibleWithV1(mobiledoc)) {
|
|
version = 2;
|
|
}
|
|
|
|
let html = converters.mobiledocConverter.render(mobiledoc, version);
|
|
this.set('html', html);
|
|
}
|
|
|
|
if (this.hasChanged('html') || !this.get('plaintext')) {
|
|
this.set('plaintext', htmlToText.fromString(this.get('html'), {
|
|
wordwrap: 80,
|
|
ignoreImage: true,
|
|
hideLinkHrefIfSameAsText: true,
|
|
preserveNewlines: true,
|
|
returnDomByDefault: true,
|
|
uppercaseHeadings: false
|
|
}));
|
|
}
|
|
|
|
// disabling sanitization until we can implement a better version
|
|
if (!options.importing) {
|
|
title = this.get('title') || common.i18n.t('errors.models.post.untitled');
|
|
this.set('title', _.toString(title).trim());
|
|
}
|
|
|
|
// ### Business logic for published_at and published_by
|
|
// If the current status is 'published' and published_at is not set, set it to now
|
|
if (newStatus === 'published' && !publishedAt) {
|
|
this.set('published_at', new Date());
|
|
}
|
|
|
|
// If the current status is 'published' and the status has just changed ensure published_by is set correctly
|
|
if (newStatus === 'published' && this.hasChanged('status')) {
|
|
// unless published_by is set and we're importing, set published_by to contextUser
|
|
if (!(this.get('published_by') && options.importing)) {
|
|
this.set('published_by', this.contextUser(options));
|
|
}
|
|
} else {
|
|
// In any other case (except import), `published_by` should not be changed
|
|
if (this.hasChanged('published_by') && !options.importing) {
|
|
this.set('published_by', this.previous('published_by'));
|
|
}
|
|
}
|
|
|
|
// If a title is set, not the same as the old title, a draft post, and has never been published
|
|
if (prevTitle !== undefined && newTitle !== prevTitle && newStatus === 'draft' && !publishedAt) {
|
|
ops.push(function updateSlug() {
|
|
// Pass the new slug through the generator to strip illegal characters, detect duplicates
|
|
return ghostBookshelf.Model.generateSlug(Post, self.get('title'),
|
|
{status: 'all', transacting: options.transacting, importing: options.importing})
|
|
.then(function then(slug) {
|
|
// After the new slug is found, do another generate for the old title to compare it to the old slug
|
|
return ghostBookshelf.Model.generateSlug(Post, prevTitle,
|
|
{status: 'all', transacting: options.transacting, importing: options.importing}
|
|
).then(function then(prevTitleSlug) {
|
|
// If the old slug is the same as the slug that was generated from the old title
|
|
// then set a new slug. If it is not the same, means was set by the user
|
|
if (prevTitleSlug === prevSlug) {
|
|
self.set({slug: slug});
|
|
}
|
|
});
|
|
});
|
|
});
|
|
} else {
|
|
ops.push(function updateSlug() {
|
|
// If any of the attributes above were false, set initial slug and check to see if slug was changed by the user
|
|
if (self.hasChanged('slug') || !self.get('slug')) {
|
|
// Pass the new slug through the generator to strip illegal characters, detect duplicates
|
|
return ghostBookshelf.Model.generateSlug(Post, self.get('slug') || self.get('title'),
|
|
{status: 'all', transacting: options.transacting, importing: options.importing})
|
|
.then(function then(slug) {
|
|
self.set({slug: slug});
|
|
});
|
|
}
|
|
|
|
return Promise.resolve();
|
|
});
|
|
}
|
|
|
|
return sequence(ops);
|
|
},
|
|
|
|
emptyStringProperties: function emptyStringProperties() {
|
|
// CASE: the client might send empty image properties with "" instead of setting them to null.
|
|
// This can cause GQL to fail. We therefore enforce 'null' for empty image properties.
|
|
// See https://github.com/TryGhost/GQL/issues/24
|
|
return ['feature_image', 'og_image', 'twitter_image'];
|
|
},
|
|
|
|
created_by: function createdBy() {
|
|
return this.belongsTo('User', 'created_by');
|
|
},
|
|
|
|
updated_by: function updatedBy() {
|
|
return this.belongsTo('User', 'updated_by');
|
|
},
|
|
|
|
published_by: function publishedBy() {
|
|
return this.belongsTo('User', 'published_by');
|
|
},
|
|
|
|
authors: function authors() {
|
|
return this.belongsToMany('User', 'posts_authors', 'post_id', 'author_id')
|
|
.withPivot('sort_order')
|
|
.query('orderBy', 'sort_order', 'ASC');
|
|
},
|
|
|
|
tags: function tags() {
|
|
return this.belongsToMany('Tag', 'posts_tags', 'post_id', 'tag_id')
|
|
.withPivot('sort_order')
|
|
.query('orderBy', 'sort_order', 'ASC');
|
|
},
|
|
|
|
fields: function fields() {
|
|
return this.morphMany('AppField', 'relatable');
|
|
},
|
|
/**
|
|
* @NOTE:
|
|
* If you are requesting models with `columns`, you try to only receive some fields of the model/s.
|
|
* But the model layer is complex and needs specific fields in specific situations.
|
|
*
|
|
* ### url generation
|
|
* - @TODO: with dynamic routing, we no longer need default columns to fetch
|
|
* - because with static routing Ghost generated the url on runtime and needed the following attributes:
|
|
* - `slug`: /:slug/
|
|
* - `published_at`: /:year/:slug
|
|
* - `author_id`: /:author/:slug, /:primary_author/:slug
|
|
* - now, the UrlService pre-generates urls based on the resources
|
|
* - you can ask `urlService.getUrlByResourceId(post.id)`
|
|
*
|
|
* ### events
|
|
* - you call `findAll` with `columns: id`
|
|
* - then you trigger `post.save()` on the response
|
|
* - bookshelf events (`onSaving`) and model events (`emitChange`) are triggered
|
|
* - but you only fetched the id column, this will trouble (!), because the event hooks require more
|
|
* data than just the id
|
|
* - @TODO: we need to disallow this (!)
|
|
* - you should use `models.Post.edit(..)`
|
|
* - this disallows using the `columns` option
|
|
* - same for destroy - you should use `models.Post.destroy(...)`
|
|
*
|
|
* @IMPORTANT: This fn should **never** be used when updating models (models.Post.edit)!
|
|
* Because the events for updating a resource require most of the fields.
|
|
* This is protected by the fn `permittedOptions`.
|
|
*/
|
|
defaultColumnsToFetch: function defaultColumnsToFetch() {
|
|
return ['id', 'published_at', 'slug', 'author_id'];
|
|
},
|
|
/**
|
|
* If the `formats` option is not used, we return `html` be default.
|
|
* Otherwise we return what is requested e.g. `?formats=mobiledoc,plaintext`
|
|
*/
|
|
formatsToJSON: function formatsToJSON(attrs, options) {
|
|
var defaultFormats = ['html'],
|
|
formatsToKeep = options.formats || defaultFormats;
|
|
|
|
// Iterate over all known formats, and if they are not in the keep list, remove them
|
|
_.each(Post.allowedFormats, function (format) {
|
|
if (formatsToKeep.indexOf(format) === -1) {
|
|
delete attrs[format];
|
|
}
|
|
});
|
|
|
|
return attrs;
|
|
},
|
|
|
|
toJSON: function toJSON(unfilteredOptions) {
|
|
var options = Post.filterOptions(unfilteredOptions, 'toJSON'),
|
|
attrs = ghostBookshelf.Model.prototype.toJSON.call(this, options),
|
|
oldPostId = attrs.amp,
|
|
commentId;
|
|
|
|
attrs = this.formatsToJSON(attrs, options);
|
|
|
|
// If the current column settings allow it...
|
|
if (!options.columns || (options.columns && options.columns.indexOf('primary_tag') > -1)) {
|
|
// ... attach a computed property of primary_tag which is the first tag if it is public, else null
|
|
if (attrs.tags && attrs.tags.length > 0 && attrs.tags[0].visibility === 'public') {
|
|
attrs.primary_tag = attrs.tags[0];
|
|
} else {
|
|
attrs.primary_tag = null;
|
|
}
|
|
}
|
|
|
|
if (!options.columns || (options.columns && options.columns.indexOf('url') > -1)) {
|
|
attrs.url = urlService.getUrlByResourceId(attrs.id);
|
|
}
|
|
|
|
if (oldPostId) {
|
|
// CASE: You create a new post on 1.X, you enable disqus. You export your content, you import your content on a different instance.
|
|
// This time, the importer remembers your old post id in the amp field as ObjectId.
|
|
if (ObjectId.isValid(oldPostId)) {
|
|
commentId = oldPostId;
|
|
} else {
|
|
oldPostId = Number(oldPostId);
|
|
|
|
// CASE: You import an old post id from your LTS blog. Stored in the amp field.
|
|
if (!isNaN(oldPostId)) {
|
|
commentId = oldPostId.toString();
|
|
} else {
|
|
commentId = attrs.id;
|
|
}
|
|
}
|
|
} else {
|
|
commentId = attrs.id;
|
|
}
|
|
|
|
// NOTE: we remember the old post id because of disqus
|
|
attrs.comment_id = commentId;
|
|
|
|
return attrs;
|
|
},
|
|
enforcedFilters: function enforcedFilters(options) {
|
|
return options.context && options.context.public ? 'status:published' : null;
|
|
},
|
|
defaultFilters: function defaultFilters(options) {
|
|
if (options.context && options.context.internal) {
|
|
return null;
|
|
}
|
|
|
|
return options.context && options.context.public ? 'page:false' : 'page:false+status:published';
|
|
}
|
|
}, {
|
|
allowedFormats: ['mobiledoc', 'html', 'plaintext', 'amp'],
|
|
|
|
orderDefaultOptions: function orderDefaultOptions() {
|
|
return {
|
|
status: 'ASC',
|
|
published_at: 'DESC',
|
|
updated_at: 'DESC',
|
|
id: 'DESC'
|
|
};
|
|
},
|
|
|
|
orderDefaultRaw: function () {
|
|
return '' +
|
|
'CASE WHEN posts.status = \'scheduled\' THEN 1 ' +
|
|
'WHEN posts.status = \'draft\' THEN 2 ' +
|
|
'ELSE 3 END ASC,' +
|
|
'posts.published_at DESC,' +
|
|
'posts.updated_at DESC,' +
|
|
'posts.id DESC';
|
|
},
|
|
|
|
/**
|
|
* @deprecated in favour of filter
|
|
*/
|
|
processOptions: function processOptions(options) {
|
|
if (!options.staticPages && !options.status) {
|
|
return options;
|
|
}
|
|
|
|
// This is the only place that 'options.where' is set now
|
|
options.where = {statements: []};
|
|
|
|
// Step 4: Setup filters (where clauses)
|
|
if (options.staticPages && options.staticPages !== 'all') {
|
|
// convert string true/false to boolean
|
|
if (!_.isBoolean(options.staticPages)) {
|
|
options.staticPages = _.includes(['true', '1'], options.staticPages);
|
|
}
|
|
options.where.statements.push({prop: 'page', op: '=', value: options.staticPages});
|
|
delete options.staticPages;
|
|
} else if (options.staticPages === 'all') {
|
|
options.where.statements.push({prop: 'page', op: 'IN', value: [true, false]});
|
|
delete options.staticPages;
|
|
}
|
|
|
|
// Unless `all` is passed as an option, filter on
|
|
// the status provided.
|
|
if (options.status && options.status !== 'all') {
|
|
// make sure that status is valid
|
|
options.status = _.includes(['published', 'draft', 'scheduled'], options.status) ? options.status : 'published';
|
|
options.where.statements.push({prop: 'status', op: '=', value: options.status});
|
|
delete options.status;
|
|
} else if (options.status === 'all') {
|
|
options.where.statements.push({prop: 'status', op: 'IN', value: ['published', 'draft', 'scheduled']});
|
|
delete options.status;
|
|
}
|
|
|
|
return options;
|
|
},
|
|
|
|
/**
|
|
* Returns an array of keys permitted in a method's `options` hash, depending on the current method.
|
|
* @param {String} methodName The name of the method to check valid options for.
|
|
* @return {Array} Keys allowed in the `options` hash of the model's method.
|
|
*/
|
|
permittedOptions: function permittedOptions(methodName) {
|
|
var options = ghostBookshelf.Model.permittedOptions(),
|
|
|
|
// whitelists for the `options` hash argument on methods, by method name.
|
|
// these are the only options that can be passed to Bookshelf / Knex.
|
|
validOptions = {
|
|
findOne: ['columns', 'importing', 'withRelated', 'require'],
|
|
findPage: ['page', 'limit', 'columns', 'filter', 'order', 'status', 'staticPages'],
|
|
findAll: ['columns', 'filter'],
|
|
destroy: ['destroyAll']
|
|
};
|
|
|
|
// The post model additionally supports having a formats option
|
|
options.push('formats');
|
|
|
|
if (validOptions[methodName]) {
|
|
options = options.concat(validOptions[methodName]);
|
|
}
|
|
|
|
return options;
|
|
},
|
|
|
|
/**
|
|
* We have to ensure consistency. If you listen on model events (e.g. `post.published`), you can expect that you always
|
|
* receive all fields including relations. Otherwise you can't rely on a consistent flow. And we want to avoid
|
|
* that event listeners have to re-fetch a resource. This function is used in the context of inserting
|
|
* and updating resources. We won't return the relations by default for now.
|
|
*/
|
|
defaultRelations: function defaultRelations(methodName, options) {
|
|
if (['edit', 'add'].indexOf(methodName) !== -1) {
|
|
options.withRelated = _.union(this.prototype.relationships, options.withRelated || []);
|
|
}
|
|
|
|
return options;
|
|
},
|
|
|
|
/**
|
|
* Manually add 'tags' attribute since it's not in the schema and call parent.
|
|
*
|
|
* @param {Object} data Has keys representing the model's attributes/fields in the database.
|
|
* @return {Object} The filtered results of the passed in data, containing only what's allowed in the schema.
|
|
*/
|
|
filterData: function filterData(data) {
|
|
var filteredData = ghostBookshelf.Model.filterData.apply(this, arguments),
|
|
extraData = _.pick(data, this.prototype.relationships);
|
|
|
|
_.merge(filteredData, extraData);
|
|
return filteredData;
|
|
},
|
|
|
|
// ## Model Data Functions
|
|
|
|
/**
|
|
* ### Find One
|
|
* @extends ghostBookshelf.Model.findOne to handle post status
|
|
* **See:** [ghostBookshelf.Model.findOne](base.js.html#Find%20One)
|
|
*/
|
|
findOne: function findOne(data, options) {
|
|
data = _.defaults(data || {}, {
|
|
status: 'published'
|
|
});
|
|
|
|
if (data.status === 'all') {
|
|
delete data.status;
|
|
}
|
|
|
|
return ghostBookshelf.Model.findOne.call(this, data, options);
|
|
},
|
|
|
|
/**
|
|
* ### Edit
|
|
* Fetches and saves to Post. See model.Base.edit
|
|
*
|
|
* @extends ghostBookshelf.Model.edit to handle returning the full object and manage _updatedAttributes
|
|
* **See:** [ghostBookshelf.Model.edit](base.js.html#edit)
|
|
*/
|
|
edit: function edit(data, unfilteredOptions) {
|
|
let options = this.filterOptions(unfilteredOptions, 'edit', {extraAllowedProperties: ['id']});
|
|
|
|
const editPost = () => {
|
|
options.forUpdate = true;
|
|
|
|
return ghostBookshelf.Model.edit.call(this, data, options)
|
|
.then((post) => {
|
|
return this.findOne({
|
|
status: 'all',
|
|
id: options.id
|
|
}, _.merge({transacting: options.transacting}, unfilteredOptions))
|
|
.then((found) => {
|
|
if (found) {
|
|
// Pass along the updated attributes for checking status changes
|
|
found._updatedAttributes = post._updatedAttributes;
|
|
return found;
|
|
}
|
|
});
|
|
});
|
|
};
|
|
|
|
if (!options.transacting) {
|
|
return ghostBookshelf.transaction((transacting) => {
|
|
options.transacting = transacting;
|
|
return editPost();
|
|
});
|
|
}
|
|
|
|
return editPost();
|
|
},
|
|
|
|
/**
|
|
* ### Add
|
|
* @extends ghostBookshelf.Model.add to handle returning the full object
|
|
* **See:** [ghostBookshelf.Model.add](base.js.html#add)
|
|
*/
|
|
add: function add(data, unfilteredOptions) {
|
|
let options = this.filterOptions(unfilteredOptions, 'add', {extraAllowedProperties: ['id']});
|
|
|
|
const addPost = (() => {
|
|
return ghostBookshelf.Model.add.call(this, data, options)
|
|
.then((post) => {
|
|
return this.findOne({
|
|
status: 'all',
|
|
id: post.id
|
|
}, _.merge({transacting: options.transacting}, unfilteredOptions));
|
|
});
|
|
});
|
|
|
|
if (!options.transacting) {
|
|
return ghostBookshelf.transaction((transacting) => {
|
|
options.transacting = transacting;
|
|
|
|
return addPost();
|
|
});
|
|
}
|
|
|
|
return addPost();
|
|
},
|
|
|
|
destroy: function destroy(unfilteredOptions) {
|
|
let options = this.filterOptions(unfilteredOptions, 'destroy', {extraAllowedProperties: ['id']});
|
|
|
|
const destroyPost = () => {
|
|
return ghostBookshelf.Model.destroy.call(this, options);
|
|
};
|
|
|
|
if (!options.transacting) {
|
|
return ghostBookshelf.transaction((transacting) => {
|
|
options.transacting = transacting;
|
|
return destroyPost();
|
|
});
|
|
}
|
|
|
|
return destroyPost();
|
|
},
|
|
|
|
// NOTE: the `authors` extension is the parent of the post model. It also has a permissible function.
|
|
permissible: function permissible(postModel, action, context, unsafeAttrs, loadedPermissions, hasUserPermission, hasAppPermission, result) {
|
|
let isContributor, isEdit, isAdd, isDestroy;
|
|
|
|
result = result || {};
|
|
|
|
function isChanging(attr) {
|
|
return unsafeAttrs[attr] && unsafeAttrs[attr] !== postModel.get(attr);
|
|
}
|
|
|
|
function isPublished() {
|
|
return unsafeAttrs.status && unsafeAttrs.status !== 'draft';
|
|
}
|
|
|
|
function isDraft() {
|
|
return postModel.get('status') === 'draft';
|
|
}
|
|
|
|
isContributor = loadedPermissions.user && _.some(loadedPermissions.user.roles, {name: 'Contributor'});
|
|
isEdit = (action === 'edit');
|
|
isAdd = (action === 'add');
|
|
isDestroy = (action === 'destroy');
|
|
|
|
if (isContributor && isEdit) {
|
|
// Only allow contributor edit if status is changing, and the post is a draft post
|
|
hasUserPermission = !isChanging('status') && isDraft();
|
|
} else if (isContributor && isAdd) {
|
|
// If adding, make sure it's a draft post and has the correct ownership
|
|
hasUserPermission = !isPublished();
|
|
} else if (isContributor && isDestroy) {
|
|
// If destroying, only allow contributor to destroy their own draft posts
|
|
hasUserPermission = isDraft();
|
|
}
|
|
|
|
if (isContributor) {
|
|
// Note: at the moment primary_tag is a computed field,
|
|
// meaning we don't add it to this list. However, if the primary_tag/primary_author
|
|
// ever becomes a db field rather than a computed field, add it to this list
|
|
// TODO: once contributors are able to edit existing tags, this can be removed
|
|
// @TODO: we need a concept for making a diff between incoming tags and existing tags
|
|
if (result.excludedAttrs) {
|
|
result.excludedAttrs.push('tags');
|
|
} else {
|
|
result.excludedAttrs = ['tags'];
|
|
}
|
|
}
|
|
|
|
if (hasUserPermission && hasAppPermission) {
|
|
return Promise.resolve(result);
|
|
}
|
|
|
|
return Promise.reject(new common.errors.NoPermissionError({
|
|
message: common.i18n.t('errors.models.post.notEnoughPermission')
|
|
}));
|
|
}
|
|
});
|
|
|
|
Posts = ghostBookshelf.Collection.extend({
|
|
model: Post
|
|
});
|
|
|
|
// Extension for handling the logic for author + multiple authors
|
|
Post = relations.authors.extendModel(Post, Posts, ghostBookshelf);
|
|
|
|
module.exports = {
|
|
Post: ghostBookshelf.model('Post', Post),
|
|
Posts: ghostBookshelf.collection('Posts', Posts)
|
|
};
|