TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-30 01:42:29 +03:00
Code Issues Projects Releases Wiki Activity
77b18916f4
Ghost/ghost/admin/app
History
Chris Raible 77b18916f4
🐛 Fixed a bug causing new drafts to only save if the title is populated (#20769) 
ref
https://linear.app/tryghost/issue/ONC-253/drafts-only-save-if-the-title-is-populated

- A
[commit](c8ba9e8027)
in `v5.89.1` introduced a bug that caused new drafts to only save if the
post title was populated, causing potential data loss if a user is
working on a new draft without setting the title.
- This commit reverts the one that introduced this bug to prevent data
loss.

This reverts commit c8ba9e8027.
2024-08-16 12:09:11 -07:00
..
adapters Fixed infinite save loop due to missing post_revisions include on saves (#18597) 2023-10-12 19:16:45 +00:00
authenticators Made session.user a synchronous property rather than a promise 2021-07-08 14:54:31 +01:00
components 🐛 Fixed a bug causing new drafts to only save if the title is populated (#20769) 2024-08-16 12:09:11 -07:00
controllers 🐛 Fixed a bug causing new drafts to only save if the title is populated (#20769) 2024-08-16 12:09:11 -07:00
decorators Fixed hosting management screen not loading after sign-in process (#15763) 2022-11-03 11:14:36 +00:00
errors Improved validation process for members CSV import 2020-07-07 00:28:30 +12:00
helpers 🎨 Added 'Changed email address' event to Member Activity (#20493) 2024-07-01 15:33:33 +00:00
initializers Resolved ember-simple-auth deprecations 2022-01-22 00:30:56 +00:00
instance-initializers Fixed hosting management screen not loading after sign-in process (#15763) 2022-11-03 11:14:36 +00:00
mixins Added collections CRUD UI 2023-05-23 17:26:47 +07:00
models 🐛 Fixed a bug causing new drafts to only save if the title is populated (#20769) 2024-08-16 12:09:11 -07:00
modifiers Fixed onboarding checklist video logo autoplay (#19967) 2024-04-02 13:55:22 +01:00
routes Fixed matching ignored errors 2024-08-07 12:39:57 +02:00
serializers Added custom excerpt to post revisions (#20323) 2024-06-05 14:47:33 +01:00
services Improved publishing flow end screen (#20701) 2024-08-15 18:22:32 +08:00
session-stores Migrated session-store to native class syntax 2022-02-02 18:41:16 +00:00
styles Refined details for new publish flow (#20761) 2024-08-15 14:54:50 +02:00
templates 🐛 Fixed a bug causing new drafts to only save if the title is populated (#20769) 2024-08-16 12:09:11 -07:00
transforms Dropped ember-cli-moment-shim dependency 2022-09-24 13:28:23 +02:00
transitions Fixed autofocus not working on modal inputs 2018-06-04 17:48:57 +01:00
utils ✨ Improved performance loading posts & pages in admin (#20646) 2024-07-29 16:19:28 +00:00
validators Excerpt form error fix (#20730) 2024-08-12 09:35:21 +00:00
app.js Dropped ember-cli-moment-shim dependency 2022-09-24 13:28:23 +02:00
index.html Fixed loading animation for Safari 2022-10-17 10:11:07 +02:00
README.md Fixed typos (#18648) 2023-10-31 15:21:44 +00:00
router.js Cleaned up websockets experiment (#20547) 2024-07-04 16:08:06 +00:00
transitions.js Removed tour feature 2021-03-02 14:29:26 +00:00

README.md

Ghost Admin App

Ember.js application used as a client-side admin for the Ghost blogging platform. This readme is a work in progress guide aimed at explaining the specific nuances of the Ghost Ember app to contributors whose main focus is on this side of things.

CSS

We use pure CSS, which is pre-processed for backwards compatibility by Myth. We do not follow any strict CSS framework, however our general style is pretty similar to BEM.

Styles are primarily broken up into 4 main categories:

  • Patterns - are base level visual styles for HTML elements (eg. Buttons)
  • Components - are groups of patterns used to create a UI component (eg. Modals)
  • Layouts - are groups of components used to create application screens (eg. Settings)

All of these separate files are subsequently imported and compiled in app.css.

Front End Standards

  • 4 spaces for HTML & CSS indentation. Never tabs.
  • Double quotes only, never single quotes.
  • Use tags and elements appropriate for an HTML5 doctype (including self-closing tags)
  • Adhere to the Recess CSS property order.
  • Always a space after a property's colon (.e.g, display: block; and not display:block;).
  • End all lines with a semi-colon.
  • For multiple, comma-separated selectors, place each selector on its own line.
  • Use js- prefixed classes for JavaScript hooks into the DOM, and never use these in CSS as per Slightly Obtrusive JavaScript
  • Avoid over-nesting CSS. Never nest more than 3 levels deep.
  • Use comments to explain "why" not "what" (Good: This requires a z-index in order to appear above mobile navigation. Bad: This is a thing which is always on top!)