Ghost/ghost/admin/app
Harsh Maur 78513b7998 🐛 Fixed flash of unstyled content appearing when toggling night mode (#1818)
closes https://github.com/TryGhost/Ghost/issues/12396

We use two stylesheets ghost-light.css and ghost-dark.css for light mode and night mode respectively. The problem occurs when we disable the light stylesheet when we enable dark stylesheet, as there is a moment when there is no style applied. This causes flash of unstyled content (or a big logo when users flip the night mode switch)

Since the ghost-dark style is loaded after the ghost-light stylesheet, we only need to enable or disable the dark stylesheet. When the dark stylesheet is enabled, the light stylesheet will be overridden automatically by the browser. I could not find any performance implications on overriding styles. The only performance implication is around loading a new stylesheet which we already do.
2021-01-12 09:45:33 +00:00
..
adapters Added activity feed to member details screen (#1796) 2020-12-10 11:38:38 +00:00
authenticators Added "What's new" indicator and modal to highlight recent updates (#1292) 2019-08-23 10:01:27 +01:00
components Fixed several responsiveness issues in members list 2021-01-08 14:01:48 +01:00
controllers Fixed open rate appearing twice in posts ordering dropdown 2020-12-10 15:14:13 +00:00
errors Improved validation process for members CSV import 2020-07-07 00:28:30 +12:00
helpers Changed tooltip on hovering schedule state in post list from uppercase to capitalised 2020-12-11 09:49:07 +01:00
initializers Bumped dependencies (Fixed production build) (#1091) 2019-01-08 12:36:16 +00:00
mixins Implemented first iteration of content snippets 2020-10-15 18:03:35 +01:00
models Added activity feed to member details screen (#1796) 2020-12-10 11:38:38 +00:00
modifiers Update dependency ember-power-select to v4 (#1528) 2020-05-17 22:35:53 +01:00
routes Added activity feed to member details screen (#1796) 2020-12-10 11:38:38 +00:00
serializers 🐛 Fixed potential "Request entity too large" error when saving members 2020-12-16 13:41:45 +00:00
services 🐛 Fixed flash of unstyled content appearing when toggling night mode (#1818) 2021-01-12 09:45:33 +00:00
session-stores Use Admin API v2 with session auth (#1046) 2018-10-05 19:46:33 +01:00
styles Fixed several responsiveness issues in members list 2021-01-08 14:01:48 +01:00
templates Fixed issues for member details mobile view (#1807) 2020-12-16 10:04:33 +01:00
transforms Upgraded eslint-plugin-ghost and fixed new linter errors 2020-01-16 17:01:12 +00:00
transitions Fixed autofocus not working on modal inputs 2018-06-04 17:48:57 +01:00
utils Fixed multiple no-shadow linting errors 2020-06-17 09:35:46 +01:00
validators Added max length validation to snippet's name field 2020-10-16 19:22:09 +01:00
app.js Updated scheduling copy 2020-10-02 10:45:49 +02:00
index.html Added margin to bottom of Admin when installed as PWA on newer iOS devices (#1667) 2020-09-22 07:43:17 +01:00
README.md Convert Sass to Myth 2015-05-22 19:05:09 +01:00
router.js Moved members settings to new page (#1736) 2020-10-22 16:09:00 +05:30
transitions.js Unsplash integration 2017-08-15 16:01:12 +01:00

Ghost Admin Client

Ember.js application used as a client-side admin for the Ghost blogging platform. This readme is a work in progress guide aimed at explaining the specific nuances of the Ghost Ember app to contributors whose main focus is on this side of things.

CSS

We use pure CSS, which is pre-processed for backwards compatibility by Myth. We do not follow any strict CSS framework, however our general style is pretty similar to BEM.

Styles are primarily broken up into 4 main categories:

  • Patterns - are base level visual styles for HTML elements (eg. Buttons)
  • Components - are groups of patterns used to create a UI component (eg. Modals)
  • Layouts - are groups of components used to create application screens (eg. Settings)

All of these separate files are subsequently imported and compiled in app.css.

Front End Standards

  • 4 spaces for HTML & CSS indentation. Never tabs.
  • Double quotes only, never single quotes.
  • Use tags and elements appropriate for an HTML5 doctype (including self-closing tags)
  • Adhere to the Recess CSS property order.
  • Always a space after a property's colon (.e.g, display: block; and not display:block;).
  • End all lines with a semi-colon.
  • For multiple, comma-separated selectors, place each selector on its own line.
  • Use js- prefixed classes for JavaScript hooks into the DOM, and never use these in CSS as per Slightly Obtrusive JavaSript
  • Avoid over-nesting CSS. Never nest more than 3 levels deep.
  • Use comments to explain "why" not "what" (Good: This requires a z-index in order to appear above mobile navigation. Bad: This is a thing which is always on top!)