TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-28 22:43:30 +03:00
Code Issues Projects Releases Wiki Activity
7a40ab52fb
Ghost/ghost/recommendations
History
Sag 7a40ab52fb
🐛 Fixed adding recommendation when oembed fails (#19861) 
refs https://linear.app/tryghost/issue/ENG-750

- when adding a recommendation, we fetch the recommended site's metadata
- before this change, if the metadata fetch failed for some reason, we'd show an error and block the recommendation from being added
- after this change, we use fallback values if the metadata fails to fetch, instead of blocking the recommendation from being added. We use the site domain as the title and leave the rest empty (no favicon, no description)
- this change also means we are not checking whether a site exists or not for the publisher anymore. It’s then up to the publisher to make sure they don’t enter broken URLs
2024-03-14 11:36:28 +01:00
..
src 🐛 Fixed adding recommendation when oembed fails (#19861) 2024-03-14 11:36:28 +01:00
test 🐛 Fixed adding recommendation when oembed fails (#19861) 2024-03-14 11:36:28 +01:00
.eslintrc.js Added recommendations CRUD api (#17845) 2023-08-29 15:06:57 +00:00
package.json Updated @tryghost/errors dependency 2024-03-11 17:33:51 +01:00
README.md Added recommendations CRUD api (#17845) 2023-08-29 15:06:57 +00:00
tsconfig.json Added recommendations CRUD api (#17845) 2023-08-29 15:06:57 +00:00

README.md

Recommendations

Usage

Develop

This is a monorepo package.

Follow the instructions for the top-level repo.

  1. git clone this repo & cd into it as usual
  2. Run yarn to install top-level dependencies.

Test

  • yarn lint run just eslint
  • yarn test run lint and tests