mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-12 06:25:51 +03:00
7b0d5d465b
closes #9675 - with dynamic routing we have introduced a breaking change, which we have overseen - Ghost does not return absolute urls, that's why the clients need to concat the blog url and the resource url - with 1.24.0 Ghost returned resource urls including the subdirectory - this caused trouble for e.g. zapier or the preview feature in the admin client - revert breaking change and ensure we only expose resource urls without subdirectory
90 lines
2.8 KiB
JavaScript
90 lines
2.8 KiB
JavaScript
var path = require('path'),
|
|
express = require('express'),
|
|
ampRouter = express.Router(),
|
|
|
|
// Dirty requires
|
|
common = require('../../../lib/common'),
|
|
urlService = require('../../../services/url'),
|
|
helpers = require('../../../services/routing/helpers'),
|
|
templateName = 'amp';
|
|
|
|
function _renderer(req, res, next) {
|
|
// Note: this is super similar to the config middleware used in channels
|
|
// @TODO refactor into to something explicit & DRY this up
|
|
res._route = {
|
|
type: 'custom',
|
|
templateName: templateName,
|
|
defaultTemplate: path.resolve(__dirname, 'views', templateName + '.hbs')
|
|
};
|
|
|
|
// Renderer begin
|
|
// Format data
|
|
var data = req.body || {};
|
|
|
|
// CASE: we only support amp pages for posts that are not static pages
|
|
if (!data.post || data.post.page) {
|
|
return next(new common.errors.NotFoundError({message: common.i18n.t('errors.errors.pageNotFound')}));
|
|
}
|
|
|
|
// Render Call
|
|
return helpers.renderer(req, res, data);
|
|
}
|
|
|
|
// This here is a controller.
|
|
// In fact, this whole file is nothing more than a controller + renderer & doesn't need to be a router
|
|
function getPostData(req, res, next) {
|
|
req.body = req.body || {};
|
|
|
|
const urlWithoutSubdirectoryWithoutAmp = res.locals.relativeUrl.match(/(.*?\/)amp/)[1];
|
|
|
|
/**
|
|
* @NOTE
|
|
*
|
|
* We have to figure out the target permalink, otherwise it would be possible to serve a post
|
|
* which lives in two collections.
|
|
*
|
|
* @TODO:
|
|
*
|
|
* This is not optimal and caused by the fact how apps currently work. But apps weren't designed
|
|
* for dynamic routing.
|
|
*
|
|
* I think if the responsible, target router would first take care fetching/determining the post, the
|
|
* request could then be forwarded to this app. Then we don't have to:
|
|
*
|
|
* 1. care about fetching the post
|
|
* 2. care about if the post can be served
|
|
* 3. then this app would act like an extension
|
|
*
|
|
* The challenge is to design different types of apps e.g. extensions of routers, standalone pages etc.
|
|
*/
|
|
const permalinks = urlService.getPermalinkByUrl(urlWithoutSubdirectoryWithoutAmp, {withUrlOptions: true});
|
|
|
|
if (!permalinks) {
|
|
return next(new common.errors.NotFoundError({
|
|
message: common.i18n.t('errors.errors.pageNotFound')
|
|
}));
|
|
}
|
|
|
|
helpers.postLookup(urlWithoutSubdirectoryWithoutAmp, {permalinks: permalinks})
|
|
.then(function handleResult(result) {
|
|
if (result && result.post) {
|
|
req.body.post = result.post;
|
|
}
|
|
|
|
next();
|
|
})
|
|
.catch(next);
|
|
}
|
|
|
|
// AMP frontend route
|
|
ampRouter
|
|
.route('/')
|
|
.get(
|
|
getPostData,
|
|
_renderer
|
|
);
|
|
|
|
module.exports = ampRouter;
|
|
module.exports.renderer = _renderer;
|
|
module.exports.getPostData = getPostData;
|