Ghost/ghost/admin/app
Simon Backx 7b3712a15b
Added visible theme errors in admin (#16081)
refs https://github.com/TryGhost/Team/issues/2393

- During boot and loading the active theme, we now cache the result of
the gscan validation. Cache configuration can happen in
`adapters.cache.gscan`
- We now also return non-fatal errors when activating or adding a theme.
- When the `themeErrorsNotification` feature flag is on, we fetch the
active theme (which includes the validation information) when loading
admin
- If the currently active theme has errors, we show an error
notification that can open the error modal
- Added a new endpoint: `/ghost/api/admin/themes/active/` that returns
the result of the last gscan validation of the active theme. If no cache
is available, it will run a new gscan validation.
- Added new permissions for the active action/endpoint (author, editor,
administrator)
2023-01-06 13:44:27 +01:00
..
adapters Added visible theme errors in admin (#16081) 2023-01-06 13:44:27 +01:00
authenticators Made session.user a synchronous property rather than a promise 2021-07-08 14:54:31 +01:00
components Added visible theme errors in admin (#16081) 2023-01-06 13:44:27 +01:00
controllers 🐛 Fixed missing validation of offer amounts in the admin panel (#16022) 2023-01-03 09:23:11 +00:00
decorators Fixed hosting management screen not loading after sign-in process (#15763) 2022-11-03 11:14:36 +00:00
errors Improved validation process for members CSV import 2020-07-07 00:28:30 +12:00
helpers Renamed all references to "Flagged as spam email" (#15938) 2022-12-05 12:07:26 +04:00
initializers Resolved ember-simple-auth deprecations 2022-01-22 00:30:56 +00:00
instance-initializers Fixed hosting management screen not loading after sign-in process (#15763) 2022-11-03 11:14:36 +00:00
mixins Migrated <GhValidationStatusContainer> to {{validation-status}} modifier 2022-12-09 12:38:35 +00:00
models Added visible theme errors in admin (#16081) 2023-01-06 13:44:27 +01:00
modifiers Refactored <GhBenefitItem> 2022-12-14 11:57:54 +00:00
routes 🐛 Fixed unexpected "unsaved changes" modal when deleting a member 2022-12-05 11:48:37 +00:00
serializers 🐛 Fixed settings overriden when updated from multiple tabs (#15536) 2022-10-12 14:03:54 +01:00
services Added visible theme errors in admin (#16081) 2023-01-06 13:44:27 +01:00
session-stores Migrated session-store to native class syntax 2022-02-02 18:41:16 +00:00
styles Theme error list design refinements 2023-01-05 13:19:34 +01:00
templates Added static version of theme errors notification 2023-01-05 11:38:17 +01:00
transforms Dropped ember-cli-moment-shim dependency 2022-09-24 13:28:23 +02:00
transitions Fixed autofocus not working on modal inputs 2018-06-04 17:48:57 +01:00
utils Added post scheduling Playwright test and loosened time restrictions (#15960) 2022-12-07 17:29:36 +01:00
validators 🐛 Fixed missing validation of offer amounts in the admin panel (#16022) 2023-01-03 09:23:11 +00:00
app.js Dropped ember-cli-moment-shim dependency 2022-09-24 13:28:23 +02:00
index.html Fixed loading animation for Safari 2022-10-17 10:11:07 +02:00
README.md Renamed "client" references to "admin" 2022-05-17 09:09:14 +01:00
router.js Added basic email debug design (#15914) 2022-12-01 17:58:37 +05:30
transitions.js Removed tour feature 2021-03-02 14:29:26 +00:00

Ghost Admin App

Ember.js application used as a client-side admin for the Ghost blogging platform. This readme is a work in progress guide aimed at explaining the specific nuances of the Ghost Ember app to contributors whose main focus is on this side of things.

CSS

We use pure CSS, which is pre-processed for backwards compatibility by Myth. We do not follow any strict CSS framework, however our general style is pretty similar to BEM.

Styles are primarily broken up into 4 main categories:

  • Patterns - are base level visual styles for HTML elements (eg. Buttons)
  • Components - are groups of patterns used to create a UI component (eg. Modals)
  • Layouts - are groups of components used to create application screens (eg. Settings)

All of these separate files are subsequently imported and compiled in app.css.

Front End Standards

  • 4 spaces for HTML & CSS indentation. Never tabs.
  • Double quotes only, never single quotes.
  • Use tags and elements appropriate for an HTML5 doctype (including self-closing tags)
  • Adhere to the Recess CSS property order.
  • Always a space after a property's colon (.e.g, display: block; and not display:block;).
  • End all lines with a semi-colon.
  • For multiple, comma-separated selectors, place each selector on its own line.
  • Use js- prefixed classes for JavaScript hooks into the DOM, and never use these in CSS as per Slightly Obtrusive JavaSript
  • Avoid over-nesting CSS. Never nest more than 3 levels deep.
  • Use comments to explain "why" not "what" (Good: This requires a z-index in order to appear above mobile navigation. Bad: This is a thing which is always on top!)