Ghost/ghost/admin/app
Simon Backx 7c3d75ade7
🐛 Fixed pasting newlines in post titles (#15794)
fixes https://github.com/TryGhost/Team/issues/2193

- When pasting a title with a newline, we now trim the string and clear newslines before pasting.
- When sending the slug to the backend to generate a unique slug, we now sluggify it in the frontend before adding it to the URL to prevent issues with unsupported characters (causing possible routing problems in Pro).
2022-11-10 14:43:15 +01:00
..
adapters 🐛 Fixed settings overriden when updated from multiple tabs (#15536) 2022-10-12 14:03:54 +01:00
authenticators Made session.user a synchronous property rather than a promise 2021-07-08 14:54:31 +01:00
components 🐛 Fixed pasting newlines in post titles (#15794) 2022-11-10 14:43:15 +01:00
controllers Cleaned up member filters (#15784) 2022-11-10 11:05:12 +01:00
decorators Fixed hosting management screen not loading after sign-in process (#15763) 2022-11-03 11:14:36 +00:00
errors Improved validation process for members CSV import 2020-07-07 00:28:30 +12:00
helpers Add tests to tabs and events pagination (#15757) 2022-11-07 16:32:06 +04:00
initializers Resolved ember-simple-auth deprecations 2022-01-22 00:30:56 +00:00
instance-initializers Fixed hosting management screen not loading after sign-in process (#15763) 2022-11-03 11:14:36 +00:00
mixins Updated ValidationEngine to support bare native class models (#15567) 2022-10-07 20:13:42 +01:00
models Fixed hosting management screen not loading after sign-in process (#15763) 2022-11-03 11:14:36 +00:00
modifiers Migrated staff user screen to Ember Octane patterns (#15532) 2022-10-05 12:05:31 +01:00
routes Updated <GHBillingIframe> to not leak event listeners 2022-11-07 11:59:14 +00:00
serializers 🐛 Fixed settings overriden when updated from multiple tabs (#15536) 2022-10-12 14:03:54 +01:00
services 🐛 Fixed pasting newlines in post titles (#15794) 2022-11-10 14:43:15 +01:00
session-stores Migrated session-store to native class syntax 2022-02-02 18:41:16 +00:00
styles Cleaned up member filters (#15784) 2022-11-10 11:05:12 +01:00
templates Cleaned up member filters (#15784) 2022-11-10 11:05:12 +01:00
transforms Dropped ember-cli-moment-shim dependency 2022-09-24 13:28:23 +02:00
transitions Fixed autofocus not working on modal inputs 2018-06-04 17:48:57 +01:00
utils Fixed hosting management screen not loading after sign-in process (#15763) 2022-11-03 11:14:36 +00:00
validators Updated ValidationEngine to support bare native class models (#15567) 2022-10-07 20:13:42 +01:00
app.js Dropped ember-cli-moment-shim dependency 2022-09-24 13:28:23 +02:00
index.html Fixed loading animation for Safari 2022-10-17 10:11:07 +02:00
README.md Renamed "client" references to "admin" 2022-05-17 09:09:14 +01:00
router.js 🐛 Fixed missing active theme breaks design screen (#15602) 2022-10-30 14:14:11 +00:00
transitions.js Removed tour feature 2021-03-02 14:29:26 +00:00

Ghost Admin App

Ember.js application used as a client-side admin for the Ghost blogging platform. This readme is a work in progress guide aimed at explaining the specific nuances of the Ghost Ember app to contributors whose main focus is on this side of things.

CSS

We use pure CSS, which is pre-processed for backwards compatibility by Myth. We do not follow any strict CSS framework, however our general style is pretty similar to BEM.

Styles are primarily broken up into 4 main categories:

  • Patterns - are base level visual styles for HTML elements (eg. Buttons)
  • Components - are groups of patterns used to create a UI component (eg. Modals)
  • Layouts - are groups of components used to create application screens (eg. Settings)

All of these separate files are subsequently imported and compiled in app.css.

Front End Standards

  • 4 spaces for HTML & CSS indentation. Never tabs.
  • Double quotes only, never single quotes.
  • Use tags and elements appropriate for an HTML5 doctype (including self-closing tags)
  • Adhere to the Recess CSS property order.
  • Always a space after a property's colon (.e.g, display: block; and not display:block;).
  • End all lines with a semi-colon.
  • For multiple, comma-separated selectors, place each selector on its own line.
  • Use js- prefixed classes for JavaScript hooks into the DOM, and never use these in CSS as per Slightly Obtrusive JavaSript
  • Avoid over-nesting CSS. Never nest more than 3 levels deep.
  • Use comments to explain "why" not "what" (Good: This requires a z-index in order to appear above mobile navigation. Bad: This is a thing which is always on top!)