mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-25 11:55:03 +03:00
d6b7ebb517
ref https://github.com/TryGhost/Ghost/issues/11038
1. Enforced lint rule
**[ghost/mocha/no-identical-title](https://github.com/lo1tuma/eslint-plugin-mocha/blob/main/docs/rules/no-identical-title.md)**
- Fixed relevant tests
2. Enforced lint rule
**[ghost/mocha/max-top-level-suites](https://github.com/lo1tuma/eslint-plugin-mocha/blob/main/docs/rules/max-top-level-suites.md)**
- No required fixes, as tests are compliant already
#### Additional details
Specifically for `ghost/mocha/no-identical-title` most fixes were simple
test description updates. Added comments to aid the PR review for the
ones that had relevant changes, and might require more attention. They
are as follows:
*
[e2e-api/admin/invites.test.js](https://github.com/TryGhost/Ghost/pull/19720#discussion_r1496397548):
Removed duplicated test (exact same code on both);
*
[e2e-api/admin/members.test.js](https://github.com/TryGhost/Ghost/pull/19720#discussion_r1496399107):
From the[ PR this was
introduced](73466c1c40 (diff-4dbc7e96e356428561085147e00e9acb5c71b58d4c1bd3d9fc9ac30e77c45be0L236-L237))
seems like author based his test on an existing one but possibly forgot
to rename it;
*
[unit/api/canary/utils/serializers/input/pages.test.js](https://github.com/TryGhost/Ghost/pull/19720#discussion_r1496400143):
The [page filter](https://github.com/TryGhost/Ghost/pull/14829/files)
was removed, so changed the description accordingly;
*
[unit/api/canary/utils/serializers/input/posts.test.js](https://github.com/TryGhost/Ghost/pull/19720#discussion_r1496400329):
The [page filter](https://github.com/TryGhost/Ghost/pull/14829/files)
was removed, so changed the description accordingly;
*
[unit/frontend/services/rendering/templates.test.js](https://github.com/TryGhost/Ghost/pull/19720#discussion_r1496402430):
Removed duplicated test
*
[unit/server/models/post.test.js](https://github.com/TryGhost/Ghost/pull/19720#discussion_r1496403529):
the change in [this
PR](https://github.com/TryGhost/Ghost/pull/14586/files#diff-c351cb589adefbb886570cfadb33b33eb8fdc12bde1024d1188cd18c165fc5e8L1010)
made three tests here mostly the same. Deduplicated them and kept only
one.
38 lines
1.0 KiB
JavaScript
38 lines
1.0 KiB
JavaScript
module.exports = {
|
|
env: {
|
|
es6: true,
|
|
node: true,
|
|
mocha: true
|
|
},
|
|
plugins: [
|
|
'ghost'
|
|
],
|
|
extends: [
|
|
'eslint:recommended',
|
|
'plugin:ghost/test'
|
|
],
|
|
rules: {
|
|
// TODO: remove this rule once it's turned into "error" in the base plugin
|
|
'no-shadow': 'error',
|
|
|
|
// these rules were were not previously enforced in our custom rules,
|
|
// they're turned off here because they _are_ enforced in our plugin.
|
|
// TODO: remove these custom rules and fix the problems in test files where appropriate
|
|
camelcase: 'off',
|
|
'no-prototype-builtins': 'off',
|
|
'no-unused-vars': [
|
|
'error',
|
|
{
|
|
varsIgnorePattern: '^should$'
|
|
}
|
|
],
|
|
'no-useless-escape': 'off',
|
|
|
|
'ghost/mocha/no-skipped-tests': 'error',
|
|
|
|
// TODO: remove these custom rules and fix problems in test files
|
|
'ghost/mocha/no-setup-in-describe': 'off',
|
|
'ghost/mocha/no-sibling-hooks': 'off'
|
|
}
|
|
};
|