mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-27 12:53:13 +03:00
f08a55c21f
refs: https://github.com/TryGhost/Team/issues/856 refs: https://github.com/TryGhost/Team/issues/756 - The .test.js extension is better than _spec.js as it's more obvious that it's an extension - It also meaans we can use the --extension parameter in mocha, which should result in a better default behaviour for `yarn test` - It also highlights that some of our tests were named incorrectly and were not (and still will not be) run (see https://github.com/TryGhost/Team/issues/856) - Note: even with this change, `yarn test` is throwing errors, I believe because of this issue https://github.com/TryGhost/Team/issues/756
164 lines
6.3 KiB
JavaScript
164 lines
6.3 KiB
JavaScript
const should = require('should');
|
|
const sinon = require('sinon');
|
|
const urlUtils = require('../../../../core/shared/url-utils');
|
|
|
|
// Stuff we are testing
|
|
const storageUtils = require('../../../../core/server/adapters/storage/utils');
|
|
|
|
describe('storage utils', function () {
|
|
let urlForStub;
|
|
let urlGetSubdirStub;
|
|
|
|
beforeEach(function () {
|
|
urlForStub = sinon.stub();
|
|
});
|
|
|
|
afterEach(function () {
|
|
sinon.restore();
|
|
});
|
|
|
|
describe('fn: getLocalFileStoragePath', function () {
|
|
it('should return local file storage path for absolute URL', function () {
|
|
const url = 'http://myblog.com/content/images/2017/07/ghost-logo.png';
|
|
let result;
|
|
|
|
urlForStub = sinon.stub(urlUtils, 'urlFor');
|
|
urlForStub.withArgs('home').returns('http://myblog.com/');
|
|
urlGetSubdirStub = sinon.stub(urlUtils, 'getSubdir');
|
|
urlGetSubdirStub.returns('');
|
|
|
|
result = storageUtils.getLocalFileStoragePath(url);
|
|
should.exist(result);
|
|
result.should.be.equal('/2017/07/ghost-logo.png');
|
|
});
|
|
|
|
it('should return local file storage path for absolute URL with subdirectory', function () {
|
|
const url = 'http://myblog.com/blog/content/images/2017/07/ghost-logo.png';
|
|
let result;
|
|
|
|
urlForStub = sinon.stub(urlUtils, 'urlFor');
|
|
urlForStub.withArgs('home').returns('http://myblog.com/');
|
|
urlGetSubdirStub = sinon.stub(urlUtils, 'getSubdir');
|
|
urlGetSubdirStub.returns('/blog');
|
|
|
|
result = storageUtils.getLocalFileStoragePath(url);
|
|
should.exist(result);
|
|
result.should.be.equal('/2017/07/ghost-logo.png');
|
|
});
|
|
|
|
it('should return local file storage path for relative URL', function () {
|
|
const filePath = '/content/images/2017/07/ghost-logo.png';
|
|
let result;
|
|
|
|
urlForStub = sinon.stub(urlUtils, 'urlFor');
|
|
urlForStub.withArgs('home').returns('http://myblog.com/');
|
|
urlGetSubdirStub = sinon.stub(urlUtils, 'getSubdir');
|
|
urlGetSubdirStub.returns('');
|
|
|
|
result = storageUtils.getLocalFileStoragePath(filePath);
|
|
should.exist(result);
|
|
result.should.be.equal('/2017/07/ghost-logo.png');
|
|
});
|
|
|
|
it('should return local file storage path for relative URL with subdirectory', function () {
|
|
const filePath = '/blog/content/images/2017/07/ghost-logo.png';
|
|
let result;
|
|
|
|
urlForStub = sinon.stub(urlUtils, 'urlFor');
|
|
urlForStub.withArgs('home').returns('http://myblog.com/');
|
|
urlGetSubdirStub = sinon.stub(urlUtils, 'getSubdir');
|
|
urlGetSubdirStub.returns('/blog');
|
|
|
|
result = storageUtils.getLocalFileStoragePath(filePath);
|
|
should.exist(result);
|
|
result.should.be.equal('/2017/07/ghost-logo.png');
|
|
});
|
|
|
|
it('should not sanitize URL if not local file storage', function () {
|
|
const url = 'http://example-blog.com/ghost-logo.png';
|
|
let result;
|
|
|
|
urlForStub = sinon.stub(urlUtils, 'urlFor');
|
|
urlForStub.withArgs('home').returns('http://myblog.com/');
|
|
urlGetSubdirStub = sinon.stub(urlUtils, 'getSubdir');
|
|
urlGetSubdirStub.returns('');
|
|
|
|
result = storageUtils.getLocalFileStoragePath(url);
|
|
should.exist(result);
|
|
result.should.be.equal('http://example-blog.com/ghost-logo.png');
|
|
});
|
|
});
|
|
|
|
describe('fn: isLocalImage', function () {
|
|
it('should return true when absolute URL and local file', function () {
|
|
const url = 'http://myblog.com/content/images/2017/07/ghost-logo.png';
|
|
let result;
|
|
|
|
urlForStub = sinon.stub(urlUtils, 'urlFor');
|
|
urlForStub.withArgs('home').returns('http://myblog.com/');
|
|
urlGetSubdirStub = sinon.stub(urlUtils, 'getSubdir');
|
|
urlGetSubdirStub.returns('');
|
|
|
|
result = storageUtils.isLocalImage(url);
|
|
should.exist(result);
|
|
result.should.be.equal(true);
|
|
});
|
|
|
|
it('should return true when absolute URL with subdirectory and local file', function () {
|
|
const url = 'http://myblog.com/blog/content/images/2017/07/ghost-logo.png';
|
|
let result;
|
|
|
|
urlForStub = sinon.stub(urlUtils, 'urlFor');
|
|
urlForStub.withArgs('home').returns('http://myblog.com/');
|
|
urlGetSubdirStub = sinon.stub(urlUtils, 'getSubdir');
|
|
urlGetSubdirStub.returns('/blog');
|
|
|
|
result = storageUtils.isLocalImage(url);
|
|
should.exist(result);
|
|
result.should.be.equal(true);
|
|
});
|
|
|
|
it('should return true when relative URL and local file', function () {
|
|
const url = '/content/images/2017/07/ghost-logo.png';
|
|
let result;
|
|
|
|
urlForStub = sinon.stub(urlUtils, 'urlFor');
|
|
urlForStub.withArgs('home').returns('http://myblog.com/');
|
|
urlGetSubdirStub = sinon.stub(urlUtils, 'getSubdir');
|
|
urlGetSubdirStub.returns('');
|
|
|
|
result = storageUtils.isLocalImage(url);
|
|
should.exist(result);
|
|
result.should.be.equal(true);
|
|
});
|
|
|
|
it('should return true when relative URL and local file', function () {
|
|
const url = '/blog/content/images/2017/07/ghost-logo.png';
|
|
let result;
|
|
|
|
urlForStub = sinon.stub(urlUtils, 'urlFor');
|
|
urlForStub.withArgs('home').returns('http://myblog.com/');
|
|
urlGetSubdirStub = sinon.stub(urlUtils, 'getSubdir');
|
|
urlGetSubdirStub.returns('/blog');
|
|
|
|
result = storageUtils.isLocalImage(url);
|
|
should.exist(result);
|
|
result.should.be.equal(true);
|
|
});
|
|
|
|
it('should return false when no local file', function () {
|
|
const url = 'http://somewebsite.com/ghost-logo.png';
|
|
let result;
|
|
|
|
urlForStub = sinon.stub(urlUtils, 'urlFor');
|
|
urlForStub.withArgs('home').returns('http://myblog.com/');
|
|
urlGetSubdirStub = sinon.stub(urlUtils, 'getSubdir');
|
|
urlGetSubdirStub.returns('');
|
|
|
|
result = storageUtils.isLocalImage(url);
|
|
should.exist(result);
|
|
result.should.be.equal(false);
|
|
});
|
|
});
|
|
});
|