TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-25 11:55:03 +03:00
Code Issues Projects Releases Wiki Activity
831a76505c
Ghost/ghost/email-service
History
Simon Backx 3db434736b
🐛 Fixed replacements with fallback in plaintext newsletters (#16372) 
fixes https://github.com/TryGhost/Team/issues/2683

When sending a newsletter with a replacement that has a fallback, the
replacement only happens in the HTML version of the newsletter. The
plaintext version isn't replaced.

This commit fixes the issue and adds some tests to make sure it doesn't
happen again.

The cause of the issue was that we used the original matched Regex text
to replace. But that was calculated on the HTML version, so double
quotes were encoded. This change updates the generated 'token' regex to
also match on both a double quote as the escaped double quote.
2023-03-07 15:34:43 +01:00
..
lib 🐛 Fixed replacements with fallback in plaintext newsletters (#16372) 2023-03-07 15:34:43 +01:00
test 🐛 Fixed replacements with fallback in plaintext newsletters (#16372) 2023-03-07 15:34:43 +01:00
.eslintrc.js Added email service package (#15849) 2022-11-21 10:29:53 +01:00
index.js Added mailgun provider for sending emails (#15896) 2022-11-30 16:21:58 +05:30
package.json 🐛 Fixed replacements with fallback in plaintext newsletters (#16372) 2023-03-07 15:34:43 +01:00
README.md Added email service package (#15849) 2022-11-21 10:29:53 +01:00

README.md

Email Service

Manages how posts are sent via email

Usage

Develop

This is a monorepo package.

Follow the instructions for the top-level repo.

  1. git clone this repo & cd into it as usual
  2. Run yarn to install top-level dependencies.

Test

  • yarn lint run just eslint
  • yarn test run lint and tests