mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-11-29 15:12:58 +03:00
83c9270682
Initial Subscribers screen
- set up mocked api endpoints
- basic subscribers screen with data loading, infinite scroll
"Add Subscriber" screen
- uses modal to display a new subscriber form
- validates subscriber e-mail address
- moves pagination from route into controller to use filtered/sorted CPs on top of a live-query so that new subscribers are added to the list and the total can be properly managed
TODO:
- there is currently a pretty serious performance issue where the whole table is re-rendered when the live-query is updated. `ember-light-table` doesn't allow for live-binding and has no options to easily manipulate it's rows using an external interface - it's possible to move the page loading into the component so we only render new rows but that leaves it difficult to react to new subscribers being added through the UI. I believe the number of components used within the table is also adding to the performance problems.
- most likely solution is to drop `ember-light-table` in favour of rendering the table directly - glimmer should do a good job of fast updates even though the underlying array will be completely swapped out
"Import subscribers" screen
- uses modal to display an import subscribers CSV file upload form
- displays upload progress
- displays import stats and reloads subscribers table once import has completed
- adds `gh-file-uploader` component (NB. pared down copy of `gh-image-uploader`, ripe for some refactoring)
- fixes subscribers acceptance test failing because fixtures did not have the labs flag enabled
Unfortunately this doesn't have 100% test coverage as we're limited in how we can simulate file uploads 😞
Fix performance issues with subscribers table
- moves the table definition from the component up to the controller
- switches back to manually manipulating table rows instead of using a live-query
This is a quick-fix in that it allows us to continue using the `ember-light-table` component but it does mean that we lose some flexibility that the live-query gave us. For now it's not much of an issue and it allows us to defer deeper performance/flexibility work until we have a concrete need and requirements.
Hook up Export CSV button
- use a hidden iFrame to trigger the browser to hit the CSV export endpoint and download the file
Re-order subscribers table by clicking column headers
- displays currently sorted column and sort direction
- clicking a column header re-fetches the data from the server with the appropriate query params
Fix scroll triggers for infinite pagination + icon change
- adds a debounce as well as the throttle so that we always get a final scroll trigger once scrolling has stopped
- changes the subscribers icon from the temporary team icon to the mail icon
71 lines
2.0 KiB
JavaScript
71 lines
2.0 KiB
JavaScript
import Ember from 'ember';
|
|
import ghostPaths from 'ghost/utils/ghost-paths';
|
|
import documentTitle from 'ghost/utils/document-title';
|
|
import config from './config/environment';
|
|
|
|
const {
|
|
inject: {service},
|
|
on
|
|
} = Ember;
|
|
|
|
const Router = Ember.Router.extend({
|
|
location: config.locationType, // use HTML5 History API instead of hash-tag based URLs
|
|
rootURL: ghostPaths().adminRoot, // admin interface lives under sub-directory /ghost
|
|
|
|
notifications: service(),
|
|
|
|
displayDelayedNotifications: on('didTransition', function () {
|
|
this.get('notifications').displayDelayed();
|
|
})
|
|
});
|
|
|
|
documentTitle();
|
|
|
|
Router.map(function () {
|
|
this.route('setup', function () {
|
|
this.route('one');
|
|
this.route('two');
|
|
this.route('three');
|
|
});
|
|
|
|
this.route('signin');
|
|
this.route('signout');
|
|
this.route('signup', {path: '/signup/:token'});
|
|
this.route('reset', {path: '/reset/:token'});
|
|
this.route('about', {path: '/about'});
|
|
|
|
this.route('posts', {path: '/'}, function () {
|
|
this.route('post', {path: ':post_id'});
|
|
});
|
|
|
|
this.route('editor', function () {
|
|
this.route('new', {path: ''});
|
|
this.route('edit', {path: ':post_id'});
|
|
});
|
|
|
|
this.route('team', {path: '/team'}, function () {
|
|
this.route('user', {path: ':user_slug'});
|
|
});
|
|
|
|
this.route('settings.general', {path: '/settings/general'});
|
|
this.route('settings.tags', {path: '/settings/tags'}, function () {
|
|
this.route('tag', {path: ':tag_slug'});
|
|
this.route('new');
|
|
});
|
|
this.route('settings.labs', {path: '/settings/labs'});
|
|
this.route('settings.code-injection', {path: '/settings/code-injection'});
|
|
this.route('settings.navigation', {path: '/settings/navigation'});
|
|
this.route('settings.apps', {path: '/settings/apps'}, function () {
|
|
this.route('slack', {path: 'slack'});
|
|
});
|
|
|
|
this.route('subscribers', function() {
|
|
this.route('new');
|
|
this.route('import');
|
|
});
|
|
|
|
this.route('error404', {path: '/*path'});
|
|
});
|
|
|
|
export default Router;
|