mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-11-27 18:52:14 +03:00
6161f94910
refs: https://github.com/TryGhost/Toolbox/issues/595 We're rolling out new rules around the node assert library, the first of which is enforcing the use of assert/strict. This means we don't need to use the strict version of methods, as the standard version will work that way by default. This caught some gotchas in our existing usage of assert where the lack of strict mode had unexpected results: - Url matching needs to be done on `url.href` seeaa58b354a4- Null and undefined are not the same thing, there were a few cases of this being confused - Particularly questionable changes in [PostExporter tests](c1a468744b) tracked [here](https://github.com/TryGhost/Team/issues/3505). - A typo seeeaac9c293aMoving forward, using assert strict should help us to catch unexpected behaviour, particularly around nulls and undefineds during implementation.
71 lines
3.3 KiB
JavaScript
71 lines
3.3 KiB
JavaScript
const assert = require('assert/strict');
|
|
const linkReplacer = require('../lib/link-replacer');
|
|
const cheerio = require('cheerio');
|
|
const sinon = require('sinon');
|
|
|
|
describe('LinkReplacementService', function () {
|
|
afterEach(function () {
|
|
sinon.restore();
|
|
});
|
|
|
|
it('exported', function () {
|
|
assert.equal(require('../index'), linkReplacer);
|
|
});
|
|
|
|
describe('replace', function () {
|
|
it('Can replace to URL', async function () {
|
|
const html = '<a href="http://localhost:2368/dir/path">link</a>';
|
|
const expected = '<a href="https://google.com/test-dir?test-query">link</a>';
|
|
|
|
const replaced = await linkReplacer.replace(html, () => new URL('https://google.com/test-dir?test-query'));
|
|
assert.equal(replaced, expected);
|
|
});
|
|
|
|
it('Doesn\'t break weird &map', async function () {
|
|
// Refs https://github.com/TryGhost/Team/issues/2666: somehow this gets replaced with https://example.com/test.jpg?test=true↦id=de76 if decoding entities is enabled
|
|
const html = '<img src="https://example.com/test.jpg?test=true&map_id=test">';
|
|
const expected = '<img src="https://example.com/test.jpg?test=true&map_id=test">';
|
|
|
|
const replaced = await linkReplacer.replace(html, () => new URL('https://google.com/test-dir?test-query'));
|
|
assert.equal(replaced, expected);
|
|
});
|
|
|
|
it('Does not escape HTML characters', async function () {
|
|
const html = 'This is a test & this \'should\' not "be" escaped';
|
|
const replaced = await linkReplacer.replace(html, () => new URL('https://google.com/test-dir?test-query'));
|
|
assert.equal(replaced, html);
|
|
});
|
|
|
|
it('Does escape HTML characters within a link\'s href', async function () {
|
|
const html = '<a href="https://www.google.com/maps/d/u/0/viewer?mid=1kQUV2O5QQOigaxJUorLUC9LBP4Ibppg&ll=37.87151888616819%2C-122.27759691003418&z=13">link</a>';
|
|
const expected = '<a href="https://www.google.com/maps/d/u/0/viewer?mid=1kQUV2O5QQOigaxJUorLUC9LBP4Ibppg&ll=37.87151888616819%2C-122.27759691003418&z=13">link</a>';
|
|
const replaced = await linkReplacer.replace(html, url => new URL(url));
|
|
assert.equal(replaced, expected);
|
|
});
|
|
|
|
it('Can replace to string', async function () {
|
|
const html = '<a href="http://localhost:2368/dir/path">link</a>';
|
|
const expected = '<a href="#valid-string">link</a>';
|
|
|
|
const replaced = await linkReplacer.replace(html, () => '#valid-string');
|
|
assert.equal(replaced, expected);
|
|
});
|
|
|
|
it('Ignores invalid links', async function () {
|
|
const html = '<a href="invalid">link</a>';
|
|
const expected = '<a href="invalid">link</a>';
|
|
|
|
const replaced = await linkReplacer.replace(html, () => 'valid');
|
|
assert.equal(replaced, expected);
|
|
});
|
|
|
|
it('Ignores cheerio errors', async function () {
|
|
sinon.stub(cheerio, 'load').throws(new Error('test'));
|
|
const html = '<a href="http://localhost:2368/dir/path">link</a>';
|
|
|
|
const replaced = await linkReplacer.replace(html, () => 'valid');
|
|
assert.equal(replaced, html);
|
|
});
|
|
});
|
|
});
|