mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-20 09:22:49 +03:00
16728a3ef1
- Traditionally all of Ghost's public-facing text was written in British English - We're changing that to US English because that's more common - US English should also be used in code e.g. properties are called color not colour - most of these changes are in comments, but I've changed them so that we have US English in front of us always - fixed a few other typos I noticed whilst there |
||
---|---|---|
.. | ||
broken-theme | ||
casper | ||
casper-1.4 | ||
price-data-test-theme | ||
test-theme | ||
test-theme-channels | ||
casper.zip | ||
invalid.zip | ||
README.md | ||
valid.zip | ||
warnings.zip |
Modifying theme fixtures
When a new rule is introduced in gscan one of these fixture files might break and you'll have to update a "zip" which isn't as easy as opening a text editor... It could become that one day but for now here are some commands to help out with the edit process
- Unzip the theme files, e.g.:
cd $CURRENT_DIR && unzip valid.zip -d valid
- Make a change in the file which caused a warning/error/whatever
- Zip the files back:
zip -r valid.zip ./valid
- Commit changed zip file:
git add valid.zip ;... you know the drill :)
Ideas for future improvements in theme tests:
- Decouple tests from file system as much as possible
- Track contents of what is in "zips" in source control. Right now, having a diff on a binary file is not useful at all