TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-28 13:22:39 +03:00
Code Issues Projects Releases Wiki Activity
8a4e81fadd
Ghost/apps/admin-x-settings
History
Daniel Lockyer 8a4e81fadd
Fixed splitting string into characters (#18480) 
- quite funny because it's such a sneaky thing to discover
- this code actually results in looping over
`'xxxxx<,t,e,s,t,f,o,o,t,>'` and not an array of characters
- adding brackets fixes that

---

<!-- Leave the line below if you'd like GitHub Copilot to generate a
summary from your commit -->
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 584ab6c</samp>

Fix a bug in the code injection test case for the admin settings app.
Ensure that the test code is properly padded and split by using
parentheses in the string concatenations.

---------

Co-authored-by: Jono Mingard <reason.koan@gmail.com>
2023-10-09 09:07:34 +01:00
..
.storybook Fixed storybook failing to load due @tryghost/nql usage (#18453) 2023-10-03 16:49:05 +01:00
src Refactored theme demo functionality (#18525) 2023-10-09 09:05:43 +01:00
test Fixed splitting string into characters (#18480) 2023-10-09 09:07:34 +01:00
.eslintrc.cjs Temporarily fixed eslint rules being disabled in AdminX (#17565) 2023-08-02 08:37:51 +01:00
.yarnrc Prevented git tags from being created for apps 2023-07-10 13:09:28 +02:00
index.html Moved Admin-X-Settings to apps/ folder 2023-06-23 14:37:39 +02:00
node-shim.cjs Port custom theme setting visibility to admin-x (#18367) 2023-10-02 15:54:14 +01:00
package.json Update dependency @tanstack/react-query to v4.36.1 2023-10-09 02:02:14 +00:00
playwright.config.ts Renamed e2e tests to acceptance tests in Admin X (#18439) 2023-10-03 16:20:40 +07:00
postcss.config.cjs Moved Admin-X-Settings to apps/ folder 2023-06-23 14:37:39 +02:00
README.md Moved Admin-X-Settings to apps/ folder 2023-06-23 14:37:39 +02:00
tailwind.config.cjs AdminX mobile updates (#18137) 2023-09-19 12:09:38 +02:00
tsconfig.json Moved Admin-X-Settings to apps/ folder 2023-06-23 14:37:39 +02:00
tsconfig.node.json Moved Admin-X-Settings to apps/ folder 2023-06-23 14:37:39 +02:00
vite.config.ts Port custom theme setting visibility to admin-x (#18367) 2023-10-02 15:54:14 +01:00

README.md

Admin X Settings

Experimental re-write of Ghost Admin Settings in React

Development

Pre-requisites

  • Run yarn in Ghost monorepo root
  • Run yarn in this directory

Running the development version

Run yarn dev to start the development server to test/develop the settings standalone. This will generate a demo site from the index.html file which renders the app and makes it available on http://localhost:5173

Running inside Admin

Run yarn dev from the top-level repo with --adminX

Develop

This is a monorepo package.

Follow the instructions for the top-level repo.

  1. git clone this repo & cd into it as usual
  2. Run yarn to install top-level dependencies.

Test

  • yarn lint run just eslint
  • yarn test run lint and tests