mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-11-27 10:42:45 +03:00
daa36a91b1
refsedcd6caf2brefs56f2832754- although we added an include for `post_revisions` when fetching a post for editing we didn't have the same `include` param added to saves meaning our revisions list was wiped from the store on each update - on leaving the editor we check the last post revision to see if anything has changed and we need to save again, but with it being wiped and not being re-populated on save it meant the check always failed leading to an infinite loop of saves - updated the posts and pages adapters to use the full includes param on create/update requests so we don't lose what we're trying to compare against
54 lines
2.0 KiB
JavaScript
54 lines
2.0 KiB
JavaScript
import ApplicationAdapter from 'ghost-admin/adapters/application';
|
|
import {ALL_POST_INCLUDES} from './post';
|
|
|
|
export default class Page extends ApplicationAdapter {
|
|
// posts and pages now include everything except post_revisions by default
|
|
buildIncludeURL(store, modelName, id, snapshot, requestType, query) {
|
|
const url = this.buildURL(modelName, id, snapshot, requestType, query);
|
|
const parsedUrl = new URL(url);
|
|
|
|
if (snapshot?.adapterOptions?.saveRevision) {
|
|
const saveRevision = snapshot.adapterOptions.saveRevision;
|
|
parsedUrl.searchParams.append('save_revision', saveRevision);
|
|
}
|
|
|
|
if (snapshot?.adapterOptions?.convertToLexical) {
|
|
const convertToLexical = snapshot.adapterOptions.convertToLexical;
|
|
parsedUrl.searchParams.append('convert_to_lexical', convertToLexical);
|
|
}
|
|
|
|
// on create/update we need to explicitly request post_revisions to be included
|
|
// so we can compare and create a new one later if needed but that means we
|
|
// have to specify every post include option
|
|
if (requestType === 'createRecord' || requestType === 'updateRecord') {
|
|
parsedUrl.searchParams.append('include', ALL_POST_INCLUDES);
|
|
}
|
|
|
|
return parsedUrl.toString();
|
|
}
|
|
|
|
buildURL() {
|
|
const url = super.buildURL(...arguments);
|
|
|
|
try {
|
|
const parsedUrl = new URL(url);
|
|
if (!parsedUrl.searchParams.get('formats')) {
|
|
parsedUrl.searchParams.set('formats', 'mobiledoc,lexical');
|
|
return parsedUrl.href;
|
|
}
|
|
} catch (e) {
|
|
// noop, just use the original url
|
|
console.error('Couldn\'t parse URL', e); // eslint-disable-line
|
|
}
|
|
|
|
return url;
|
|
}
|
|
|
|
// posts and pages now include all relations by default so we don't want
|
|
// EmbeddedRelationAdapter.buildQuery adding an `?include=` param that
|
|
// overrides the defaults with a more restrictive list
|
|
buildQuery(store, modelName, options) {
|
|
return options;
|
|
}
|
|
}
|