mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-11-23 22:11:09 +03:00
8e66edee2b
fixes https://github.com/TryGhost/Team/issues/481 This change fixes an issue when multiple images with the same name are uploaded in parallel. The current system does not guarantee that the original filename is stored under NAME+`_o`, because the upload for the original file and the resized file are happening in parallel. Solution: - Wait for the storage of the resized image (= the image without the _o suffix) before storing the original file. - When that is stored, use the generated file name of the stored image to generate the filename with the _o suffix. This way, it will always match and we don't risk both files to have a different number suffix. We'll also set the `targetDir` argument when saving the file, to avoid storing the original file in a different directory (when uploading a file around midnight both files could be stored in 2023/01 and 2023/02). Some extra optimisations needed with this fix: - Previously when uploading image.jpg, while it already exists, it would store two filenames on e.g., `image-3.jpg` and `image_o-3.jpg`. Note the weird positioning of `_o`. This probably caused bugs when uploading files named `image-3.jpg`, which would store the original in `image-3_o.jpg`, but this original would never be used by the handle-image-sizes middleware (it would look for `image_o-3.jpg`). This fix would solve this weird naming issue, and make it more consistent. But we need to make sure our middlewares (including handle-image-sizes) will be able to handle both file locations to remain compatible with the old format. This isn't additional work, because it would fix the old bug too. - Prevent uploading files that end with `_o`, e.g. by automatically stripping that suffix from uploaded files. To prevent collisions. Advantage(s): - We keep the original file name, which is better for SEO. - No changes required to the storage adapters. Downside(s): - The storage of both files will nog happen parallel any longer. But I expect the performance implications to be minimal. - Changes to the routing: normalize middleware is removed |
||
|---|---|---|
| .. | ||
| adapter-manager | ||
| admin | ||
| api-framework | ||
| api-version-compatibility-service | ||
| audience-feedback | ||
| bootstrap-socket | ||
| constants | ||
| core | ||
| custom-theme-settings-service | ||
| data-generator | ||
| domain-events | ||
| dynamic-routing-events | ||
| email-analytics-provider-mailgun | ||
| email-analytics-service | ||
| email-content-generator | ||
| email-events | ||
| email-service | ||
| email-suppression-list | ||
| express-dynamic-redirects | ||
| extract-api-key | ||
| html-to-plaintext | ||
| i18n | ||
| importer-revue | ||
| job-manager | ||
| link-redirects | ||
| link-replacer | ||
| link-tracking | ||
| magic-link | ||
| mailgun-client | ||
| member-attribution | ||
| member-events | ||
| members-api | ||
| members-csv | ||
| members-events-service | ||
| members-importer | ||
| members-ssr | ||
| minifier | ||
| mw-api-version-mismatch | ||
| mw-cache-control | ||
| mw-error-handler | ||
| mw-session-from-token | ||
| mw-update-user-last-seen | ||
| mw-vhost | ||
| oembed-service | ||
| offers | ||
| package-json | ||
| payments | ||
| portal | ||
| referrers | ||
| security | ||
| session-service | ||
| settings-path-manager | ||
| staff-service | ||
| stats-service | ||
| stripe | ||
| tiers | ||
| update-check-service | ||
| verification-trigger | ||
| version-notifications-data-service | ||
| webmentions | ||