TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-28 22:43:30 +03:00
Code Issues Projects Releases Wiki Activity
8fde9a05d2
Ghost/ghost/member-attribution
History
Simon Backx 74ecde73db
Moved attribution event handler to events service (#15379) 
fixes https://github.com/TryGhost/Team/issues/1821

This change moves all the event storage logic to one new place: the event storage class in the MembersEventsService, which is initialised in a new members events service wrapper.

Apart from this, this includes some improvements:
- Removed DomainEvents from the constructor arguments to the subscribe method (to make it more clear where to subscribe to and decrease dependencies)
- LastSeenAtUpdater doesn't subscribe in the constructor any longer (removes unclear side effect)
- Moved LastSeenAtUpdater initialisation to new members events service wrapper
- Added missing tests to LastSeenAtUpdater to assure that the MembersEventsService package has 100% coverage.
2022-09-07 16:41:59 +02:00
..
lib Moved attribution event handler to events service (#15379) 2022-09-07 16:41:59 +02:00
test Moved attribution event handler to events service (#15379) 2022-09-07 16:41:59 +02:00
.eslintrc.js Added member attribution events and storage (#15243) 2022-08-18 17:38:42 +02:00
index.js Moved attribution event handler to events service (#15379) 2022-09-07 16:41:59 +02:00
package.json Added member attribution events and storage (#15243) 2022-08-18 17:38:42 +02:00
README.md Added member attribution events and storage (#15243) 2022-08-18 17:38:42 +02:00

README.md

Member Attribution

Usage

Develop

This is a monorepo package.

Follow the instructions for the top-level repo.

  1. git clone this repo & cd into it as usual
  2. Run yarn to install top-level dependencies.

Test

  • yarn lint run just eslint
  • yarn test run lint and tests