Ghost/ghost/admin/app
Steve Larson c3e261627f
Updated analytics button logic for disabled newsletter emails (#21643)
ref https://linear.app/ghost/issue/ONC-594

We had a check to prevent showing the Analytics page link for email-only
posts (newsletters) if newsletters were disabled. I don't see a good
reason to remove this - users then have to re-enable newsletters just to
see the analytics.
2024-11-20 08:43:35 -06:00
..
adapters Fixed infinite save loop due to missing post_revisions include on saves (#18597) 2023-10-12 19:16:45 +00:00
authenticators Added 2fa happy path to Admin 2024-10-21 11:01:40 +01:00
components Fixed picker for local tz use (#21658) 2024-11-19 15:54:50 -06:00
controllers Fixed staff member login when 2FA is ON (#21647) 2024-11-18 18:43:23 +00:00
decorators Fixed hosting management screen not loading after sign-in process (#15763) 2022-11-03 11:14:36 +00:00
errors Improved validation process for members CSV import 2020-07-07 00:28:30 +12:00
helpers Fixed signin and signup button failure state hover colors 2024-10-17 16:54:23 +01:00
initializers Resolved ember-simple-auth deprecations 2022-01-22 00:30:56 +00:00
instance-initializers Fixed hosting management screen not loading after sign-in process (#15763) 2022-11-03 11:14:36 +00:00
mixins Added collections CRUD UI 2023-05-23 17:26:47 +07:00
models Updated analytics button logic for disabled newsletter emails (#21643) 2024-11-20 08:43:35 -06:00
modifiers Fixed onboarding checklist video logo autoplay (#19967) 2024-04-02 13:55:22 +01:00
routes Added 2fa token verification error handling 2024-10-21 11:01:40 +01:00
serializers Added custom excerpt to post revisions (#20323) 2024-06-05 14:47:33 +01:00
services Custom fonts (#21337) 2024-10-24 07:43:08 -04:00
session-stores Migrated session-store to native class syntax 2022-02-02 18:41:16 +00:00
styles Fixes Members filter falling offscreen on mobile viewports (#21438) 2024-10-28 15:24:54 +00:00
templates Removed resend countdown from 2fa flow 2024-10-25 15:26:23 +01:00
transforms Dropped ember-cli-moment-shim dependency 2022-09-24 13:28:23 +02:00
transitions Fixed autofocus not working on modal inputs 2018-06-04 17:48:57 +01:00
utils Allowed transistion to settings when in forceUpgrade is active 2024-11-19 05:28:46 -05:00
validators Excerpt form error fix (#20730) 2024-08-12 09:35:21 +00:00
app.js Dropped ember-cli-moment-shim dependency 2022-09-24 13:28:23 +02:00
index.html Fixed loading animation for Safari 2022-10-17 10:11:07 +02:00
README.md Fixed typos (#18648) 2023-10-31 15:21:44 +00:00
router.js Added 2fa happy path to Admin 2024-10-21 11:01:40 +01:00
transitions.js Removed tour feature 2021-03-02 14:29:26 +00:00

Ghost Admin App

Ember.js application used as a client-side admin for the Ghost blogging platform. This readme is a work in progress guide aimed at explaining the specific nuances of the Ghost Ember app to contributors whose main focus is on this side of things.

CSS

We use pure CSS, which is pre-processed for backwards compatibility by Myth. We do not follow any strict CSS framework, however our general style is pretty similar to BEM.

Styles are primarily broken up into 4 main categories:

  • Patterns - are base level visual styles for HTML elements (eg. Buttons)
  • Components - are groups of patterns used to create a UI component (eg. Modals)
  • Layouts - are groups of components used to create application screens (eg. Settings)

All of these separate files are subsequently imported and compiled in app.css.

Front End Standards

  • 4 spaces for HTML & CSS indentation. Never tabs.
  • Double quotes only, never single quotes.
  • Use tags and elements appropriate for an HTML5 doctype (including self-closing tags)
  • Adhere to the Recess CSS property order.
  • Always a space after a property's colon (.e.g, display: block; and not display:block;).
  • End all lines with a semi-colon.
  • For multiple, comma-separated selectors, place each selector on its own line.
  • Use js- prefixed classes for JavaScript hooks into the DOM, and never use these in CSS as per Slightly Obtrusive JavaScript
  • Avoid over-nesting CSS. Never nest more than 3 levels deep.
  • Use comments to explain "why" not "what" (Good: This requires a z-index in order to appear above mobile navigation. Bad: This is a thing which is always on top!)