Ghost/ghost/core/test/integration/services/email-service
renovate[bot] 96d0883928
🐛 Fixed file card button not being linked in emails (#20023)
ref https://linear.app/tryghost/issue/DES-202/

- bumped Koenig packages to include fix for incorrectly wrapped download image link in email rendering of file card
2024-04-16 10:37:28 +00:00
..
__snapshots__ 🐛 Fixed file card button not being linked in emails (#20023) 2024-04-16 10:37:28 +00:00
batch-sending.test.js Enforced more Mocha lint rules (#19720) 2024-04-16 09:37:06 +02:00
cards.test.js Added an email rendering test for all Koenig cards (#19059) 2023-12-12 16:05:04 -08:00
email-event-storage.test.js Removed usage of unquoted ids in filter strings (#19070) 2023-11-21 09:45:36 +01:00
README.md Added an email rendering test for all Koenig cards (#19059) 2023-12-12 16:05:04 -08:00

What is a golden post?

The golden post is a single lexical post that has at least one example of every card that is available in the Koenig editor (with a few exceptions for cards that should never make it into an email). We have run into problems in the past where a small change to a particular card or to the EmailRenderer itself results in seriously mangled email rendering in one or more clients (usually Outlook).

How do I update the golden post to include a new card?

If you're seeing a failing test like The golden post does not contain the ${card} card, that means that you (or someone else) has added a new node to @tryghost/kg-default-nodes that is not currently represented in the golden post. This test is here to trigger a review of the rendered email of the new card, to make sure it doesn't break the formatting in email clients. To update this test properly, please do the following:

  1. Create a card in the lexical editor, either at koenig.ghost.org or in your local Koenig repo
  2. Use the JSON Output in the bottom right of the demo to copy the lexical payload for the new card
  3. Paste the lexical payload for the card as a top level child of the root node in the golden post fixture at ghost/core/test/utils/fixtures/email-service/golden-post.json
  4. Re-run your tests with UPDATE_SNAPSHOT=1 set to update the snapshot to include the new card
  5. Update (or recreate) the Golden Post on main.ghost.org using the golden-post.json string.
  6. Send a test email to Litmus and examine the rendered output to ensure everything looks right on different clients.