mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-11-28 22:43:30 +03:00
7b443d4b63
no issue
The `config` service has been a source of confusion when writing with modern Ember patterns because it's use of the deprecated `ProxyMixin` forced all property access/setting to go via `.get()` and `.set()` whereas the rest of the system has mostly (there are a few other uses of ProxyObjects remaining) eliminated the use of the non-native get/set methods.
- removed use of `ProxyMixin` in the `config` service by grabbing the API response after fetching and using `Object.defineProperty()` to add native getters/setters that pass through to a tracked object holding the API response data. Ember's autotracking automatically works across the native getters/setters so we can then use the service as if it was any other native object
- updated all code to use `config.{attrName}` directly for getting/setting instead of `.get()` and `.set()`
- removed unnecessary async around `config.availableTimezones` which wasn't making any async calls
77 lines
2.3 KiB
JavaScript
77 lines
2.3 KiB
JavaScript
import Pretender from 'pretender';
|
|
import ghostPaths from 'ghost-admin/utils/ghost-paths';
|
|
import {describe, it} from 'mocha';
|
|
import {expect} from 'chai';
|
|
import {settled} from '@ember/test-helpers';
|
|
import {setupTest} from 'ember-mocha';
|
|
|
|
describe('Integration: Service: config', function () {
|
|
setupTest();
|
|
|
|
let server;
|
|
|
|
beforeEach(function () {
|
|
server = new Pretender();
|
|
});
|
|
|
|
afterEach(function () {
|
|
server.shutdown();
|
|
});
|
|
|
|
it('returns a list of timezones in the expected format', function () {
|
|
const service = this.owner.lookup('service:config');
|
|
const timezones = service.availableTimezones;
|
|
|
|
expect(timezones.length).to.equal(66);
|
|
expect(timezones[0].name).to.equal('Pacific/Pago_Pago');
|
|
expect(timezones[0].label).to.equal('(GMT -11:00) Midway Island, Samoa');
|
|
expect(timezones[1].name).to.equal('Pacific/Honolulu');
|
|
expect(timezones[1].label).to.equal('(GMT -10:00) Hawaii');
|
|
});
|
|
|
|
it('normalizes blogUrl to non-trailing-slash', function (done) {
|
|
let stubBlogUrl = function stubBlogUrl(url) {
|
|
server.get(`${ghostPaths().apiRoot}/config/`, function () {
|
|
return [
|
|
200,
|
|
{'Content-Type': 'application/json'},
|
|
JSON.stringify({})
|
|
];
|
|
});
|
|
|
|
server.get(`${ghostPaths().apiRoot}/site/`, function () {
|
|
return [
|
|
200,
|
|
{'Content-Type': 'application/json'},
|
|
JSON.stringify({
|
|
site: {
|
|
url
|
|
}
|
|
})
|
|
];
|
|
});
|
|
};
|
|
let service = this.owner.lookup('service:config');
|
|
|
|
stubBlogUrl('http://localhost:2368/');
|
|
|
|
service.fetch().then(() => {
|
|
expect(
|
|
service.get('blogUrl'), 'trailing-slash'
|
|
).to.equal('http://localhost:2368');
|
|
});
|
|
|
|
settled().then(() => {
|
|
stubBlogUrl('http://localhost:2368');
|
|
|
|
service.fetch().then(() => {
|
|
expect(
|
|
service.get('blogUrl'), 'non-trailing-slash'
|
|
).to.equal('http://localhost:2368');
|
|
|
|
done();
|
|
});
|
|
});
|
|
});
|
|
});
|