mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-18 07:51:55 +03:00
9ab4b7d4d5
fixes #2111 - modified Post model to support a tag query param that will filter the desired post collection to only include posts that contain the requested tag - in the updated Post model it includes the Tag model under a nested object called 'aspects' - added tests for updated Post model, updating test utils to add more posts_tags relations - adds two new routes to frontend, one for initial tag page, another to page that tag page - for tag pages the array of posts is exposed to the view similarly to the homepeage - on the tag view page the information for the tag is also accessible for further theme usage - the tag view page supports a hierarchy of views, it'll first attempt to use a tag.hbs file if it exists, otherwise fall back to the default index.hbs file - modified pageUrl and pagination helper to have it be compatible with tag paging - added unit tests for frontend controller - added unit tests for handlebar helper modifications - add functional tests for new tag routes
380 lines
13 KiB
JavaScript
380 lines
13 KiB
JavaScript
/*global describe, it, before, after */
|
|
|
|
// # Frontend Route tests
|
|
// As it stands, these tests depend on the database, and as such are integration tests.
|
|
// Mocking out the models to not touch the DB would turn these into unit tests, and should probably be done in future,
|
|
// But then again testing real code, rather than mock code, might be more useful...
|
|
|
|
var request = require('supertest'),
|
|
should = require('should'),
|
|
moment = require('moment'),
|
|
|
|
testUtils = require('../../utils'),
|
|
config = require('../../../server/config'),
|
|
|
|
ONE_HOUR_S = 60 * 60,
|
|
ONE_YEAR_S = 365 * 24 * ONE_HOUR_S,
|
|
cacheRules = {
|
|
'public': 'public, max-age=0',
|
|
'hour': 'public, max-age=' + ONE_HOUR_S,
|
|
'year': 'public, max-age=' + ONE_YEAR_S,
|
|
'private': 'no-cache, private, no-store, must-revalidate, max-stale=0, post-check=0, pre-check=0'
|
|
};
|
|
|
|
describe('Frontend Routing', function () {
|
|
function doEnd(done) {
|
|
return function (err, res) {
|
|
if (err) {
|
|
return done(err);
|
|
}
|
|
|
|
should.not.exist(res.headers['x-cache-invalidate']);
|
|
should.not.exist(res.headers['X-CSRF-Token']);
|
|
should.not.exist(res.headers['set-cookie']);
|
|
should.exist(res.headers.date);
|
|
|
|
done();
|
|
};
|
|
}
|
|
|
|
before(function (done) {
|
|
testUtils.clearData().then(function () {
|
|
// we initialise data, but not a user. No user should be required for navigating the frontend
|
|
return testUtils.initData();
|
|
}).then(function () {
|
|
done();
|
|
}, done);
|
|
|
|
// Setup the request object with the correct URL
|
|
request = request(config().url);
|
|
});
|
|
|
|
describe('Home', function () {
|
|
it('should respond with html', function (done) {
|
|
request.get('/')
|
|
.expect('Content-Type', /html/)
|
|
.expect('Cache-Control', cacheRules['public'])
|
|
.expect(200)
|
|
.end(doEnd(done));
|
|
});
|
|
|
|
it('should not have as second page', function (done) {
|
|
request.get('/page/2/')
|
|
.expect('Location', '/')
|
|
.expect('Cache-Control', cacheRules['public'])
|
|
.expect(302)
|
|
.end(doEnd(done));
|
|
});
|
|
});
|
|
|
|
describe('Welcome post', function () {
|
|
it('should redirect without slash', function (done) {
|
|
request.get('/welcome-to-ghost')
|
|
.expect('Location', '/welcome-to-ghost/')
|
|
.expect('Cache-Control', cacheRules.year)
|
|
.expect(301)
|
|
.end(doEnd(done));
|
|
});
|
|
|
|
it('should respond with html', function (done) {
|
|
request.get('/welcome-to-ghost/')
|
|
.expect('Content-Type', /html/)
|
|
.expect('Cache-Control', cacheRules['public'])
|
|
.expect(200)
|
|
.end(doEnd(done));
|
|
});
|
|
|
|
it('should not work with date permalinks', function (done) {
|
|
// get today's date
|
|
var date = moment().format("YYYY/MM/DD");
|
|
|
|
request.get('/' + date + '/welcome-to-ghost/')
|
|
.expect('Cache-Control', cacheRules.hour)
|
|
.expect(404)
|
|
.expect(/Page Not Found/)
|
|
.end(doEnd(done));
|
|
});
|
|
|
|
it('should 404 for unknown post', function (done) {
|
|
request.get('/spectacular/')
|
|
.expect('Cache-Control', cacheRules.hour)
|
|
.expect(404)
|
|
.expect(/Page Not Found/)
|
|
.end(doEnd(done));
|
|
});
|
|
});
|
|
|
|
describe('RSS', function () {
|
|
it('should redirect without slash', function (done) {
|
|
request.get('/rss')
|
|
.expect('Location', '/rss/')
|
|
.expect('Cache-Control', cacheRules.year)
|
|
.expect(301)
|
|
.end(doEnd(done));
|
|
});
|
|
|
|
it('should respond with xml', function (done) {
|
|
request.get('/rss/')
|
|
.expect('Content-Type', /xml/)
|
|
.expect('Cache-Control', cacheRules['public'])
|
|
.expect(200)
|
|
.end(doEnd(done));
|
|
});
|
|
|
|
it('should not have as second page', function (done) {
|
|
request.get('/rss/2/')
|
|
// TODO this should probably redirect straight to /rss/ with 301?
|
|
.expect('Location', '/rss/1/')
|
|
.expect('Cache-Control', cacheRules['public'])
|
|
.expect(302)
|
|
.end(doEnd(done));
|
|
});
|
|
});
|
|
|
|
// ### The rest of the tests require more data
|
|
|
|
describe('Archive pages', function () {
|
|
|
|
// Add enough posts to trigger pages for both the archive (6 pp) and rss (15 pp)
|
|
// insertPosts adds 5 published posts, 1 draft post, 1 published static page and one draft page
|
|
// we then insert with max 11 which ensures we have 16 published posts
|
|
before(function (done) {
|
|
testUtils.insertPosts().then(function () {
|
|
return testUtils.insertMorePosts(11);
|
|
}).then(function () {
|
|
done();
|
|
}).then(null, done);
|
|
});
|
|
|
|
it('should redirect without slash', function (done) {
|
|
request.get('/page/2')
|
|
.expect('Location', '/page/2/')
|
|
.expect('Cache-Control', cacheRules.year)
|
|
.expect(301)
|
|
.end(doEnd(done));
|
|
});
|
|
|
|
it('should respond with html', function (done) {
|
|
request.get('/page/2/')
|
|
.expect('Content-Type', /html/)
|
|
.expect('Cache-Control', cacheRules['public'])
|
|
.expect(200)
|
|
.end(doEnd(done));
|
|
});
|
|
|
|
it('should redirect page 1', function (done) {
|
|
request.get('/page/1/')
|
|
.expect('Location', '/')
|
|
.expect('Cache-Control', cacheRules['public'])
|
|
// TODO: This should probably be a 301?
|
|
.expect(302)
|
|
.end(doEnd(done));
|
|
});
|
|
|
|
it('should redirect to last page is page too high', function (done) {
|
|
request.get('/page/4/')
|
|
.expect('Location', '/page/3/')
|
|
.expect('Cache-Control', cacheRules['public'])
|
|
.expect(302)
|
|
.end(doEnd(done));
|
|
});
|
|
|
|
it('should redirect to first page is page too low', function (done) {
|
|
request.get('/page/0/')
|
|
.expect('Location', '/')
|
|
.expect('Cache-Control', cacheRules['public'])
|
|
.expect(302)
|
|
.end(doEnd(done));
|
|
});
|
|
});
|
|
|
|
describe('RSS pages', function () {
|
|
it('should redirect without slash', function (done) {
|
|
request.get('/rss/2')
|
|
.expect('Location', '/rss/2/')
|
|
.expect('Cache-Control', cacheRules.year)
|
|
.expect(301)
|
|
.end(doEnd(done));
|
|
});
|
|
|
|
it('should respond with xml', function (done) {
|
|
request.get('/rss/2/')
|
|
.expect('Content-Type', /xml/)
|
|
.expect('Cache-Control', cacheRules['public'])
|
|
.expect(200)
|
|
.end(doEnd(done));
|
|
});
|
|
|
|
it('should redirect page 1', function (done) {
|
|
request.get('/rss/1/')
|
|
.expect('Location', '/rss/')
|
|
.expect('Cache-Control', cacheRules['public'])
|
|
// TODO: This should probably be a 301?
|
|
.expect(302)
|
|
.end(doEnd(done));
|
|
});
|
|
|
|
it('should redirect to last page is page too high', function (done) {
|
|
request.get('/rss/3/')
|
|
.expect('Location', '/rss/2/')
|
|
.expect('Cache-Control', cacheRules['public'])
|
|
.expect(302)
|
|
.end(doEnd(done));
|
|
});
|
|
|
|
it('should redirect to first page is page too low', function (done) {
|
|
request.get('/rss/0/')
|
|
.expect('Location', '/rss/')
|
|
.expect('Cache-Control', cacheRules['public'])
|
|
.expect(302)
|
|
.end(doEnd(done));
|
|
});
|
|
});
|
|
|
|
describe('Static page', function () {
|
|
it('should redirect without slash', function (done) {
|
|
request.get('/static-page-test')
|
|
.expect('Location', '/static-page-test/')
|
|
.expect('Cache-Control', cacheRules.year)
|
|
.expect(301)
|
|
.end(doEnd(done));
|
|
});
|
|
|
|
it('should respond with xml', function (done) {
|
|
request.get('/static-page-test/')
|
|
.expect('Content-Type', /html/)
|
|
.expect('Cache-Control', cacheRules['public'])
|
|
.expect(200)
|
|
.end(doEnd(done));
|
|
});
|
|
});
|
|
|
|
describe('Post with Ghost in the url', function () {
|
|
// All of Ghost's admin depends on the /ghost/ in the url to work properly
|
|
// Badly formed regexs can cause breakage if a post slug starts with the 5 letters ghost
|
|
it('should retrieve a blog post with ghost at the start of the url', function (done) {
|
|
request.get('/ghostly-kitchen-sink/')
|
|
.expect('Cache-Control', cacheRules['public'])
|
|
.expect(200)
|
|
.end(doEnd(done));
|
|
});
|
|
});
|
|
|
|
describe('Static assets', function () {
|
|
it('should retrieve shared assets', function (done) {
|
|
request.get('/shared/img/user-image.png')
|
|
.expect('Cache-Control', cacheRules.hour)
|
|
.expect(200)
|
|
.end(doEnd(done));
|
|
});
|
|
|
|
it('should retrieve theme assets', function (done) {
|
|
request.get('/assets/css/screen.css')
|
|
.expect('Cache-Control', cacheRules.hour)
|
|
.expect(200)
|
|
.end(doEnd(done));
|
|
});
|
|
|
|
it('should retrieve built assets', function (done) {
|
|
request.get('/ghost/scripts/vendor.js')
|
|
.expect('Cache-Control', cacheRules.year)
|
|
.expect(200)
|
|
.end(doEnd(done));
|
|
});
|
|
|
|
// at the moment there is no image fixture to test
|
|
// it('should retrieve image assets', function (done) {
|
|
// request.get('/content/images/some.jpg')
|
|
// .expect('Cache-Control', cacheRules.year)
|
|
// .end(doEnd(done));
|
|
// });
|
|
});
|
|
|
|
describe('Tag pages', function () {
|
|
|
|
// Add enough posts to trigger tag pages
|
|
before(function (done) {
|
|
testUtils.clearData().then(function () {
|
|
// we initialise data, but not a user. No user should be required for navigating the frontend
|
|
return testUtils.initData();
|
|
}).then(function () {
|
|
|
|
return testUtils.insertPosts();
|
|
}).then(function () {
|
|
return testUtils.insertMorePosts(22);
|
|
}).then(function() {
|
|
return testUtils.insertMorePostsTags(22);
|
|
}).then(function () {
|
|
done();
|
|
}).then(null, done);
|
|
|
|
});
|
|
|
|
it('should redirect without slash', function (done) {
|
|
request.get('/tag/injection/page/2')
|
|
.expect('Location', '/tag/injection/page/2/')
|
|
.expect('Cache-Control', cacheRules.year)
|
|
.expect(301)
|
|
.end(doEnd(done));
|
|
});
|
|
|
|
it('should respond with html', function (done) {
|
|
request.get('/tag/injection/page/2/')
|
|
.expect('Content-Type', /html/)
|
|
.expect('Cache-Control', cacheRules['public'])
|
|
.expect(200)
|
|
.end(doEnd(done));
|
|
});
|
|
|
|
it('should redirect page 1', function (done) {
|
|
request.get('/tag/injection/page/1/')
|
|
.expect('Location', '/tag/injection/')
|
|
.expect('Cache-Control', cacheRules['public'])
|
|
// TODO: This should probably be a 301?
|
|
.expect(302)
|
|
.end(doEnd(done));
|
|
});
|
|
|
|
it('should redirect to last page is page too high', function (done) {
|
|
request.get('/tag/injection/page/4/')
|
|
.expect('Location', '/tag/injection/page/2/')
|
|
.expect('Cache-Control', cacheRules['public'])
|
|
.expect(302)
|
|
.end(doEnd(done));
|
|
});
|
|
|
|
it('should redirect to first page is page too low', function (done) {
|
|
request.get('/tag/injection/page/0/')
|
|
.expect('Location', '/tag/injection/')
|
|
.expect('Cache-Control', cacheRules['public'])
|
|
.expect(302)
|
|
.end(doEnd(done));
|
|
});
|
|
});
|
|
|
|
// ### The rest of the tests switch to date permalinks
|
|
|
|
// describe('Date permalinks', function () {
|
|
// before(function (done) {
|
|
// // Only way to swap permalinks setting is to login and visit the URL because
|
|
// // poking the database doesn't work as settings are cached
|
|
// });
|
|
//
|
|
// it('should load a post with date permalink', function (done) {
|
|
//
|
|
// // get today's date
|
|
// var date = moment().format("YYYY/MM/DD");
|
|
//
|
|
//
|
|
// request.get('/' + date + '/welcome-to-ghost/')
|
|
// .expect(200)
|
|
// .expect('Content-Type', /html/)
|
|
// .end(doEnd(done));
|
|
// });
|
|
// });
|
|
|
|
});
|
|
|
|
|
|
|