mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-23 19:02:29 +03:00
22e13acd65
- All var declarations are now const or let as per ES6 - All comma-separated lists / chained declarations are now one declaration per line - This is for clarity/readability but also made running the var-to-const/let switch smoother - ESLint rules updated to match How this was done: - npm install -g jscodeshift - git clone https://github.com/cpojer/js-codemod.git - git clone git@github.com:TryGhost/Ghost.git shallow-ghost - cd shallow-ghost - jscodeshift -t ../js-codemod/transforms/unchain-variables.js . -v=2 - jscodeshift -t ../js-codemod/transforms/no-vars.js . -v=2 - yarn - yarn test - yarn lint / fix various lint errors (almost all indent) by opening files and saving in vscode - grunt test-regression - sorted!
83 lines
2.4 KiB
JavaScript
83 lines
2.4 KiB
JavaScript
const should = require('should');
|
|
const sinon = require('sinon');
|
|
const configUtils = require('../../../../utils/configUtils');
|
|
const imageTransform = require('@tryghost/image-transform');
|
|
const {logging} = require('../../../../../core/server/lib/common');
|
|
const normalize = require('../../../../../core/server/web/api/middleware/normalize-image');
|
|
|
|
describe('normalize', function () {
|
|
let res;
|
|
let req;
|
|
|
|
beforeEach(function () {
|
|
req = {
|
|
file: {
|
|
name: 'test',
|
|
path: '/test/path',
|
|
ext: '.jpg'
|
|
}
|
|
};
|
|
|
|
sinon.stub(imageTransform, 'resizeFromPath');
|
|
sinon.stub(logging, 'error');
|
|
});
|
|
|
|
afterEach(function () {
|
|
sinon.restore();
|
|
configUtils.restore();
|
|
});
|
|
|
|
it('should do manipulation by default', function (done) {
|
|
imageTransform.resizeFromPath.resolves();
|
|
|
|
normalize(req, res, function () {
|
|
imageTransform.resizeFromPath.calledOnce.should.be.true();
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('should add files array to request object with original and resized files', function (done) {
|
|
imageTransform.resizeFromPath.resolves();
|
|
|
|
normalize(req, res, function () {
|
|
req.files.length.should.be.equal(2);
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('should not do manipulation without resize flag set', function (done) {
|
|
configUtils.set({
|
|
imageOptimization: {
|
|
resize: false
|
|
}
|
|
});
|
|
|
|
normalize(req, res, function () {
|
|
imageTransform.resizeFromPath.called.should.be.false();
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('should not create files array when resizing fails', function (done) {
|
|
imageTransform.resizeFromPath.rejects();
|
|
|
|
normalize(req, res, () => {
|
|
logging.error.calledOnce.should.be.true();
|
|
req.file.should.not.be.equal(undefined);
|
|
should.not.exist(req.files);
|
|
done();
|
|
});
|
|
});
|
|
|
|
['.gif', '.svg', '.svgz'].forEach(function (extension) {
|
|
it(`should skip resizing when file extension is ${extension}`, function (done) {
|
|
req.file.ext = extension;
|
|
normalize(req, res, function () {
|
|
req.file.should.not.be.equal(undefined);
|
|
should.not.exist(req.files);
|
|
done();
|
|
});
|
|
});
|
|
});
|
|
});
|