mirror of
https://github.com/TryGhost/Ghost.git
synced 2025-01-07 03:22:21 +03:00
e01ffa3620
no issue - review use of Ember core hooks and add a call to `this._super` if missing - fix a few occurrences of using the wrong component lifecycle hooks that could result in multiple/duplicate event handlers being attached `_super` should always be called when overriding Ember's base hooks so that core functionality or app functionality added through extensions, mixins or addons is not lost. This is important as it guards against issues arising from later refactorings or core changes. As example of lost functionality, there were a number of routes that extended from `AuthenticatedRoute` but then overrode the `beforeModel` hook without calling `_super` which meant that the route was no longer treated as authenticated.
55 lines
1.4 KiB
JavaScript
55 lines
1.4 KiB
JavaScript
import Ember from 'ember';
|
|
import AuthenticatedRouteMixin from 'ember-simple-auth/mixins/authenticated-route-mixin';
|
|
import MobileIndexRoute from 'ghost/routes/mobile-index-route';
|
|
|
|
const {computed, inject} = Ember;
|
|
const {reads} = computed;
|
|
|
|
export default MobileIndexRoute.extend(AuthenticatedRouteMixin, {
|
|
noPosts: false,
|
|
|
|
mediaQueries: inject.service(),
|
|
isMobile: reads('mediaQueries.isMobile'),
|
|
|
|
// Transition to a specific post if we're not on mobile
|
|
beforeModel() {
|
|
this._super(...arguments);
|
|
if (!this.get('isMobile')) {
|
|
return this.goToPost();
|
|
}
|
|
},
|
|
|
|
setupController(controller) {
|
|
controller.set('noPosts', this.get('noPosts'));
|
|
this._super(...arguments);
|
|
},
|
|
|
|
goToPost() {
|
|
// the store has been populated by PostsRoute
|
|
let posts = this.store.peekAll('post');
|
|
let post;
|
|
|
|
return this.get('session.user').then((user) => {
|
|
post = posts.find(function (post) {
|
|
// Authors can only see posts they've written
|
|
if (user.get('isAuthor')) {
|
|
return post.isAuthoredByUser(user);
|
|
}
|
|
|
|
return true;
|
|
});
|
|
|
|
if (post) {
|
|
return this.transitionTo('posts.post', post);
|
|
}
|
|
|
|
this.set('noPosts', true);
|
|
});
|
|
},
|
|
|
|
// Mobile posts route callback
|
|
desktopTransition() {
|
|
this.goToPost();
|
|
}
|
|
});
|