mirror of
https://github.com/TryGhost/Ghost.git
synced 2025-01-03 08:25:06 +03:00
9dbb2785bb
fixes https://github.com/TryGhost/Team/issues/1344 fixes https://github.com/TryGhost/Team/issues/1127 This fixes a couple of bugs with the filter menu on the members page in admin: - When opening the members page, the filters property was passed back from the filter component to the members controller. This caused a bug that the filter columns where not visible on reload. - Fixed handling invalid filter parameters - When updating the URL, the members page now properly reloads - Fixed a bug that 'falsy' values in the NQL filter were removed on reload: - Filtering on unsubscribed members was gone after a page reload - Filtering on 0 emails was gone after a page reload - This is fixed by converting numbers and booleans to strings after parsing the NQL-filter - Fixed a bug where boolean values didn't match any value in the select menu, causing the default option to be visible - Filtering members by 'unsubscribed' -> parsed as false (boolean) -> select menu opened -> false value (boolean) didn't match 'false' (string) so the first option was shown instead (subscribed). - This is also fixed by converting numbers and booleans to strings after parsing the NQL-filter The way this is currently handled is not great. The parsing happens in the filter component, but should happen on a different layer, maybe in a different helper. This is tracked here: https://github.com/TryGhost/Team/issues/1849 |
||
|---|---|---|
| .. | ||
| adapters | ||
| authenticators | ||
| components | ||
| controllers | ||
| errors | ||
| helpers | ||
| initializers | ||
| mixins | ||
| models | ||
| modifiers | ||
| routes | ||
| serializers | ||
| services | ||
| session-stores | ||
| styles | ||
| templates | ||
| transforms | ||
| transitions | ||
| utils | ||
| validators | ||
| app.js | ||
| index.html | ||
| README.md | ||
| router.js | ||
| transitions.js | ||
Ghost Admin App
Ember.js application used as a client-side admin for the Ghost blogging platform. This readme is a work in progress guide aimed at explaining the specific nuances of the Ghost Ember app to contributors whose main focus is on this side of things.
CSS
We use pure CSS, which is pre-processed for backwards compatibility by Myth. We do not follow any strict CSS framework, however our general style is pretty similar to BEM.
Styles are primarily broken up into 4 main categories:
- Patterns - are base level visual styles for HTML elements (eg. Buttons)
- Components - are groups of patterns used to create a UI component (eg. Modals)
- Layouts - are groups of components used to create application screens (eg. Settings)
All of these separate files are subsequently imported and compiled in app.css.
Front End Standards
- 4 spaces for HTML & CSS indentation. Never tabs.
- Double quotes only, never single quotes.
- Use tags and elements appropriate for an HTML5 doctype (including self-closing tags)
- Adhere to the Recess CSS property order.
- Always a space after a property's colon (.e.g, display: block; and not display:block;).
- End all lines with a semi-colon.
- For multiple, comma-separated selectors, place each selector on its own line.
- Use js- prefixed classes for JavaScript hooks into the DOM, and never use these in CSS as per Slightly Obtrusive JavaSript
- Avoid over-nesting CSS. Never nest more than 3 levels deep.
- Use comments to explain "why" not "what" (Good: This requires a z-index in order to appear above mobile navigation. Bad: This is a thing which is always on top!)