mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-26 20:34:02 +03:00
559ca9d866
fixes https://github.com/TryGhost/Ghost/issues/16057 Briefly, Ghost created two Customer objects via the Stripe API when an existing subscriber would upgrade to a paid subscription, one in an API call to create the Customer and then a second as a side effect of an API call to create a Checkout session for the user. The fix is passing the reference to the Customer object to the API call to create the Checkout session; Stripe will no longer redundantly create a Customer object in this case. This largely impacts the owner's experience of the Stripe Dashboard; it will correct their new Customer count (going forward) and make searches for users by name or email address return one responsive object which has the actual subscription in it versus returning two and forcing them to look in each to e.g. refund a transaction or similar.
139 lines
5.8 KiB
JavaScript
139 lines
5.8 KiB
JavaScript
const sinon = require('sinon');
|
|
const should = require('should');
|
|
const rewire = require('rewire');
|
|
const StripeAPI = rewire('../../../lib/StripeAPI');
|
|
const api = new StripeAPI();
|
|
|
|
describe('StripeAPI', function () {
|
|
let mockStripe;
|
|
beforeEach(function () {
|
|
mockStripe = {
|
|
checkout: {
|
|
sessions: {
|
|
create: sinon.stub().resolves()
|
|
}
|
|
}
|
|
};
|
|
const mockStripeConstructor = sinon.stub().returns(mockStripe);
|
|
StripeAPI.__set__('Stripe', mockStripeConstructor);
|
|
api.configure({
|
|
checkoutSessionSuccessUrl: '/success',
|
|
checkoutSessionCancelUrl: '/cancel',
|
|
checkoutSetupSessionSuccessUrl: '/setup-success',
|
|
checkoutSetupSessionCancelUrl: '/setup-cancel',
|
|
secretKey: ''
|
|
});
|
|
});
|
|
|
|
afterEach(function () {
|
|
sinon.restore();
|
|
});
|
|
|
|
it('createCheckoutSession sends success_url and cancel_url', async function (){
|
|
await api.createCheckoutSession('priceId', null, {});
|
|
|
|
should.exist(mockStripe.checkout.sessions.create.firstCall.firstArg.success_url);
|
|
should.exist(mockStripe.checkout.sessions.create.firstCall.firstArg.cancel_url);
|
|
});
|
|
|
|
it('createCheckoutSetupSession sends success_url and cancel_url', async function (){
|
|
await api.createCheckoutSetupSession('priceId', {});
|
|
|
|
should.exist(mockStripe.checkout.sessions.create.firstCall.firstArg.success_url);
|
|
should.exist(mockStripe.checkout.sessions.create.firstCall.firstArg.cancel_url);
|
|
});
|
|
|
|
it('createCheckoutSession sets valid trialDays', async function (){
|
|
await api.createCheckoutSession('priceId', null, {
|
|
trialDays: 12
|
|
});
|
|
|
|
should.not.exist(mockStripe.checkout.sessions.create.firstCall.firstArg.subscription_data.trial_from_plan);
|
|
should.exist(mockStripe.checkout.sessions.create.firstCall.firstArg.subscription_data.trial_period_days);
|
|
should.equal(mockStripe.checkout.sessions.create.firstCall.firstArg.subscription_data.trial_period_days, 12);
|
|
});
|
|
|
|
it('createCheckoutSession uses trial_from_plan without trialDays', async function (){
|
|
await api.createCheckoutSession('priceId', null, {});
|
|
|
|
should.exist(mockStripe.checkout.sessions.create.firstCall.firstArg.subscription_data.trial_from_plan);
|
|
should.equal(mockStripe.checkout.sessions.create.firstCall.firstArg.subscription_data.trial_from_plan, true);
|
|
should.not.exist(mockStripe.checkout.sessions.create.firstCall.firstArg.subscription_data.trial_period_days);
|
|
});
|
|
|
|
it('createCheckoutSession ignores 0 trialDays', async function (){
|
|
await api.createCheckoutSession('priceId', null, {
|
|
trialDays: 0
|
|
});
|
|
|
|
should.exist(mockStripe.checkout.sessions.create.firstCall.firstArg.subscription_data.trial_from_plan);
|
|
should.equal(mockStripe.checkout.sessions.create.firstCall.firstArg.subscription_data.trial_from_plan, true);
|
|
should.not.exist(mockStripe.checkout.sessions.create.firstCall.firstArg.subscription_data.trial_period_days);
|
|
});
|
|
|
|
it('createCheckoutSession ignores null trialDays', async function (){
|
|
await api.createCheckoutSession('priceId', null, {
|
|
trialDays: null
|
|
});
|
|
|
|
should.exist(mockStripe.checkout.sessions.create.firstCall.firstArg.subscription_data.trial_from_plan);
|
|
should.equal(mockStripe.checkout.sessions.create.firstCall.firstArg.subscription_data.trial_from_plan, true);
|
|
should.not.exist(mockStripe.checkout.sessions.create.firstCall.firstArg.subscription_data.trial_period_days);
|
|
});
|
|
|
|
it('createCheckoutSession passes customer ID successfully to Stripe', async function (){
|
|
const mockCustomer = {
|
|
id: 'cust_mock_123456',
|
|
customer_email: 'foo@example.com',
|
|
name: 'Example Customer'
|
|
};
|
|
|
|
await api.createCheckoutSession('priceId', mockCustomer, {
|
|
trialDays: null
|
|
});
|
|
|
|
should.exist(mockStripe.checkout.sessions.create.firstCall.firstArg.customer);
|
|
should.equal(mockStripe.checkout.sessions.create.firstCall.firstArg.customer, 'cust_mock_123456');
|
|
});
|
|
|
|
it('createCheckoutSession passes email if no customer object provided', async function (){
|
|
await api.createCheckoutSession('priceId', undefined, {
|
|
customerEmail: 'foo@example.com',
|
|
trialDays: null
|
|
});
|
|
|
|
should.exist(mockStripe.checkout.sessions.create.firstCall.firstArg.customer_email);
|
|
should.equal(mockStripe.checkout.sessions.create.firstCall.firstArg.customer_email, 'foo@example.com');
|
|
});
|
|
|
|
it('createCheckoutSession passes email if customer object provided w/o ID', async function (){
|
|
const mockCustomer = {
|
|
email: 'foo@example.com',
|
|
name: 'Example Customer'
|
|
};
|
|
|
|
await api.createCheckoutSession('priceId', mockCustomer, {
|
|
trialDays: null
|
|
});
|
|
|
|
should.exist(mockStripe.checkout.sessions.create.firstCall.firstArg.customer_email);
|
|
should.equal(mockStripe.checkout.sessions.create.firstCall.firstArg.customer_email, 'foo@example.com');
|
|
});
|
|
|
|
it('createCheckoutSession passes only one of customer ID and email', async function (){
|
|
const mockCustomer = {
|
|
id: 'cust_mock_123456',
|
|
email: 'foo@example.com',
|
|
name: 'Example Customer'
|
|
};
|
|
|
|
await api.createCheckoutSession('priceId', mockCustomer, {
|
|
trialDays: null
|
|
});
|
|
|
|
should.not.exist(mockStripe.checkout.sessions.create.firstCall.firstArg.customer_email);
|
|
should.exist(mockStripe.checkout.sessions.create.firstCall.firstArg.customer);
|
|
should.equal(mockStripe.checkout.sessions.create.firstCall.firstArg.customer, 'cust_mock_123456');
|
|
});
|
|
});
|