TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-23 22:11:09 +03:00
Code Issues Projects Releases Wiki Activity
a8e1a707d5
Ghost/ghost
History
Chris Raible a8e1a707d5 🐛 Fixed race condition when updating member's last_seen_at timestamp (#20389) 
ref
https://linear.app/tryghost/issue/ENG-1240/race-condition-when-updating-members-last-seen-at-timestamp

When members click a link in an email, Ghost updates the member's
`last_seen_at` timestamp, but it should only update the timestamp if the
member hasn't yet been seen in the current day (based on the
publication's timezone).

Currently there is a race condition present where multiple simultaneous
requests from the same member (if e.g. an email link checker is
following all links in an email) can cause the `last_seen_at` timestamp
to be updated multiple times in the same day for the same member. These
additional queries add a significant load on Ghost and its database,
which can contribute to the exhaustion of the connection pool and
eventually requests may time out.

The primary motivation for this change is to avoid that race condition
by adding a lock to the member row, checking if `last_seen_at` has
already been updated in the current day, and only updating it if it
hasn't.

Another beneficial side-effect of this change is that it avoids locking
the `labels` and `newsletters` tables, which are locked when we update
the `last_seen_at` timestamp in the `members` table currently. This
should improve Ghost's ability to handle a large influx of requests to
redirect endpoints (confirmed with load tests), which tend to happen
immediately after a publisher sends an email.
2024-06-19 15:58:54 -07:00
..
adapter-cache-memory-ttl Configured all unit tests to use dot reporter 2023-10-05 12:24:24 +02:00
adapter-cache-redis Added an optional timeout parameter to AdapterCacheRedis (#20131) 2024-05-02 20:39:23 -07:00
adapter-manager Update TryGhost packages 2024-05-01 17:01:41 +02:00
admin v5.85.1 2024-06-14 16:04:19 +00:00
announcement-bar-settings Configured all unit tests to use dot reporter 2023-10-05 12:24:24 +02:00
api-framework Update TryGhost packages 2024-05-27 16:58:32 +02:00
api-version-compatibility-service Fixed handling requests with mismatching version and missing key 2024-05-02 13:03:26 +02:00
audience-feedback Update TryGhost packages 2024-05-27 16:58:32 +02:00
bookshelf-repository Update TryGhost packages 2024-05-27 16:58:32 +02:00
bootstrap-socket Update TryGhost packages 2024-05-27 16:58:32 +02:00
collections Update TryGhost packages 2024-05-27 16:58:32 +02:00
constants Configured all unit tests to use dot reporter 2023-10-05 12:24:24 +02:00
core 🐛 Fixed race condition when updating member's last_seen_at timestamp (#20389) 2024-06-19 15:58:54 -07:00
custom-theme-settings-service Update TryGhost packages 2024-05-27 16:58:32 +02:00
data-generator Fixed data generator not setting posts.plaintext value 2024-06-13 16:20:53 +01:00
domain-events Update TryGhost packages 2024-05-27 16:58:32 +02:00
donations Update dependency typescript to v5.4.5 2024-04-16 09:08:58 +02:00
dynamic-routing-events Configured all unit tests to use dot reporter 2023-10-05 12:24:24 +02:00
email-addresses Pinned dependencies (#20257) 2024-05-27 15:29:32 +00:00
email-analytics-provider-mailgun Configured all unit tests to use dot reporter 2023-10-05 12:24:24 +02:00
email-analytics-service Update TryGhost packages 2024-05-27 16:58:32 +02:00
email-content-generator Update dependency fs-extra to v11.2.0 2023-11-28 11:54:44 +01:00
email-events Configured all unit tests to use dot reporter 2023-10-05 12:24:24 +02:00
email-service Update dependency html-validate to v8.20.1 2024-06-12 13:08:05 +02:00
email-suppression-list Configured all unit tests to use dot reporter 2023-10-05 12:24:24 +02:00
express-dynamic-redirects Configured all unit tests to use dot reporter 2023-10-05 12:24:24 +02:00
external-media-inliner Add Lexical support to the external-media-inliner (#19149) 2023-11-29 17:56:03 +00:00
extract-api-key Configured all unit tests to use dot reporter 2023-10-05 12:24:24 +02:00
ghost Update dependency @types/node to v20.14.2 2024-06-12 16:09:26 +02:00
html-to-plaintext Configured all unit tests to use dot reporter 2023-10-05 12:24:24 +02:00
i18n Added Greek locale for comments, portal, signup-form, ghost. (#20361) 2024-06-11 16:49:01 -04:00
importer-handler-content-files Configured all unit tests to use dot reporter 2023-10-05 12:24:24 +02:00
importer-revue Update TryGhost packages 2024-05-27 16:58:32 +02:00
in-memory-repository Improved performance for filter strings with multiple neq statements (#20198) 2024-05-13 10:35:27 -05:00
job-manager Update TryGhost packages 2024-05-27 16:58:32 +02:00
link-redirects Updated documentation for LinkRedirects (#20378) 2024-06-12 23:27:15 +00:00
link-replacer Pinned dependencies (#20257) 2024-05-27 15:29:32 +00:00
link-tracking Update TryGhost packages 2024-05-27 16:58:32 +02:00
magic-link Update TryGhost packages 2024-05-27 16:58:32 +02:00
mail-events Update TryGhost packages 2024-05-27 16:58:32 +02:00
mailgun-client Update TryGhost packages 2024-05-27 16:58:32 +02:00
member-attribution Fixed extra arguments being supplied to function calls 2024-05-07 11:44:07 +02:00
member-events Configured all unit tests to use dot reporter 2023-10-05 12:24:24 +02:00
members-api Added logging to track offer redemption (#20329) 2024-06-05 17:48:43 +01:00
members-csv 🔒 Added escaping to member export CSV fields 2024-04-03 10:21:02 +02:00
members-events-service 🐛 Fixed race condition when updating member's last_seen_at timestamp (#20389) 2024-06-19 15:58:54 -07:00
members-importer Update TryGhost packages 2024-05-27 16:58:32 +02:00
members-ssr Removed members caching cookies when no member is logged in (#20349) 2024-06-06 16:28:36 -07:00
mentions-email-report Configured all unit tests to use dot reporter 2023-10-05 12:24:24 +02:00
milestones Update TryGhost packages 2024-05-01 17:01:41 +02:00
minifier Update dependency terser to v5.31.1 2024-06-06 15:59:09 +00:00
model-to-domain-event-interceptor Configured all unit tests to use dot reporter 2023-10-05 12:24:24 +02:00
mw-api-version-mismatch Fixed extra arguments being supplied to function calls 2024-05-07 11:44:07 +02:00
mw-cache-control Configured all unit tests to use dot reporter 2023-10-05 12:24:24 +02:00
mw-error-handler Update TryGhost packages 2024-05-27 16:58:32 +02:00
mw-session-from-token Added function names to more middleware 2024-05-06 17:51:39 +02:00
mw-update-user-last-seen Configured all unit tests to use dot reporter 2023-10-05 12:24:24 +02:00
mw-version-match Update TryGhost packages 2024-05-27 16:58:32 +02:00
mw-vhost Configured all unit tests to use dot reporter 2023-10-05 12:24:24 +02:00
nql-filter-expansions Configured all unit tests to use dot reporter 2023-10-05 12:24:24 +02:00
oembed-service Update TryGhost packages 2024-05-27 16:58:32 +02:00
offers Update TryGhost packages 2024-05-27 16:58:32 +02:00
package-json Update TryGhost packages 2024-05-27 16:58:32 +02:00
payments Update TryGhost packages 2024-05-01 17:01:41 +02:00
post-events Configured all unit tests to use dot reporter 2023-10-05 12:24:24 +02:00
post-revisions Added custom excerpt to post revisions (#20323) 2024-06-05 14:47:33 +01:00
posts-service Update TryGhost packages 2024-05-27 16:58:32 +02:00
recommendations Update dependency @types/node to v20.14.2 2024-06-12 16:09:26 +02:00
referrers Configured all unit tests to use dot reporter 2023-10-05 12:24:24 +02:00
security Update TryGhost packages 2024-05-01 08:49:04 +02:00
session-service Added function names to more middleware 2024-05-06 17:51:39 +02:00
settings-path-manager Update TryGhost packages 2024-05-27 16:58:32 +02:00
slack-notifications Update TryGhost packages 2024-05-27 16:58:32 +02:00
staff-service Added email address alignment protections (#19094) 2023-11-23 10:25:30 +01:00
stats-service Update Types packages 2024-04-30 22:00:55 +02:00
stripe Update TryGhost packages 2024-05-27 16:58:32 +02:00
tiers Update TryGhost packages 2024-05-27 16:58:32 +02:00
update-check-service Update TryGhost packages 2024-05-27 16:58:32 +02:00
verification-trigger Update TryGhost packages 2024-05-01 17:01:41 +02:00
version-notifications-data-service Fixed handling requests with mismatching version and missing key 2024-05-02 13:03:26 +02:00
webmentions Update TryGhost packages 2024-05-27 16:58:32 +02:00
tsconfig.json Disabled TypeScript incremental building 2023-08-09 18:27:56 +02:00